All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Artem Shimko" <a.shimko.dev@gmail.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/2] dt-bindings: net: add DAPU Telecom DAP8211R(I) PHY binding
Date: Fri, 17 Jul 2026 17:33:42 +0000	[thread overview]
Message-ID: <20260717173343.BAB8F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260716173325.653164-2-a.shimko.dev@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The vendor prefix 'dapu' (used in the filename 'dapu,dap8211r.yaml' and the property 'dapu,tx-inverted-clk') is not registered in the 'vendor-prefixes.yaml' file.
--

--- Patch [1]: [PATCH net-next v3 1/2] dt-bindings: net: add DAPU Telecom DAP8211R(I) PHY binding ---
commit 3e68dcf4de91d264592b244d85a077b73ce34c7c
Author: Artem Shimko <a.shimko.dev@gmail.com>

dt-bindings: net: add DAPU Telecom DAP8211R(I) PHY binding

This commit adds device tree binding documentation for the DAPU Telecom
DAP8211R(I) Gigabit Ethernet PHY. It specifies support for RGMII with
configurable TX/RX clock delays and introduces the dapu,tx-inverted-clk
vendor-specific extension.

> diff --git a/Documentation/devicetree/bindings/net/dapu,dap8211r.yaml b/Documentation/devicetree/bindings/net/dapu,dap8211r.yaml
> new file mode 100644
> index 0000000000000..d4012fa17a1e1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dapu,dap8211r.yaml

[ ... ]

> +  tx-internal-delay-ps:
> +    description:
> +      RGMII TX clock delay in picoseconds (0 to maximum).
> +    multipleOf: 150
> +    maximum: 2250
> +    default: 1950
> +
> +  dapu,tx-inverted-clk:

[Severity: Low]
Is the dapu vendor prefix registered in vendor-prefixes.yaml?

Failing to document the dapu prefix in
Documentation/devicetree/bindings/vendor-prefixes.yaml causes standard
device tree validation tools to emit a warning or error about an
undocumented vendor prefix when processing this schema.

> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      If present, the RGMII TX clock to the MAC is inverted (180 degree
> +      phase shift relative to the data lines). This is a vendor-specific

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716173325.653164-1-a.shimko.dev@gmail.com?part=1

  parent reply	other threads:[~2026-07-17 17:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 17:33 [PATCH net-next v3 0/2] Add DAPU Telecom DAP8211R(I) Gigabit Ethernet PHY driver Artem Shimko
2026-07-16 17:33 ` [PATCH net-next v3 1/2] dt-bindings: net: add DAPU Telecom DAP8211R(I) PHY binding Artem Shimko
2026-07-16 19:04   ` Rob Herring (Arm)
2026-07-17 10:54     ` Artem Shimko
2026-07-17 17:33   ` sashiko-bot [this message]
2026-07-16 17:33 ` [PATCH net-next v3 2/2] net: phy: add DAPU Telecom DAP8211R(I) Gigabit Ethernet PHY driver Artem Shimko
2026-07-17 17:33   ` sashiko-bot
2026-07-16 18:11 ` [PATCH net-next v3 0/2] Add " Maxime Chevallier
2026-07-16 18:32   ` Andrew Lunn
2026-07-17 10:51     ` Artem Shimko
2026-07-17 10:50   ` Artem Shimko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260717173343.BAB8F1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=a.shimko.dev@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.