From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE33EC44515 for ; Fri, 17 Jul 2026 18:49:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0C90610E49F; Fri, 17 Jul 2026 18:49:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="p+N0UHZn"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 057A510E49F for ; Fri, 17 Jul 2026 18:49:46 +0000 (UTC) Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 680EF664; Fri, 17 Jul 2026 20:48:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1784314128; bh=+nTllAieJyIjdxvMH1TIW9EUfls0WsTNMkaOsTLg4O4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p+N0UHZnKmbo1Sxh06p6dYRiG4/itMp2EjjMVCSsnHebf0wC9uMLcRzsFMevb5h/U R1oxjVF0kkJClgaigksPAGg/36LGP+XNdX1yjF8ZA9HpFWrWtgMuC5cQI2hMhbXcvg 6ZnDwPTZN/b68uehPqhLxdFIUNhr6i4mNmhOa5Uo= Date: Fri, 17 Jul 2026 21:49:43 +0300 From: Laurent Pinchart To: Johan Hovold Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Tomi Valkeinen , "H. Nikolaus Schaller" , Dmitry Baryshkov Subject: Re: [PATCH] drm/bridge: display-connector: fix i2c adapter leak on probe failure Message-ID: <20260717184943.GF1889304@killaraus.ideasonboard.com> References: <20260717085716.1619275-1-johan@kernel.org> <20260717122035.GB1926197@killaraus.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jul 17, 2026 at 04:51:52PM +0200, Johan Hovold wrote: > On Fri, Jul 17, 2026 at 03:20:35PM +0300, Laurent Pinchart wrote: > > On Fri, Jul 17, 2026 at 10:57:16AM +0200, Johan Hovold wrote: > > > Make sure to drop the i2c adapter device and module references on failed > > > regulator and enable gpio lookup (and regulator enable) during probe > > > (e.g. on probe deferral). > > > > > > Note that of_get_i2c_adapter_by_node() does not return error pointers, > > > but i2c_put_adapter() can handle a NULL argument so the error pointer > > > check at remove works even if it is misleading. > > > > I've already sent a fix for this, see > > > > https://lore.kernel.org/dri-devel/20260705213542.28987-3-laurent.pinchart+renesas@ideasonboard.com/ > > Ah, ok. If that series is blocked perhaps you can send the fix > separately. Done. https://lore.kernel.org/dri-devel/20260717184836.2017386-1-laurent.pinchart+renesas@ideasonboard.com -- Regards, Laurent Pinchart