Re: [LTP] hugemmap/hugemmap38: migrate libhugetlbfs test truncate_reserve_wraparound.c

[linuxtestproject.agent@gmail.com]

Hi Pavithra,

On Fri, 17 Jul 2026 19:06:43 +0000, Pavithra wrote:
> hugemmap/hugemmap38: migrate libhugetlbfs test truncate_reserve_wraparound.c

> +	.hugepages = {4, TST_NEEDS},

The test calls SAFE_MMAP once for hpage_size (one hugepage) and has no
other mappings. With TST_NEEDS the framework will skip the test unless
at least four hugepages are available, which is unnecessarily
restrictive.

Should this be {1, TST_NEEDS}?

> +static void setup(void)
> +{
> +
> +	hpage_size = tst_get_hugepage_size();

There is an extra blank line between the opening brace and the first
statement. Linux kernel coding style does not allow blank lines at the
start of a function body.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp