All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Hrushiraj Gandhi" <hrushirajg23@gmail.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Vicharak Vaaman board
Date: Sat, 18 Jul 2026 07:02:50 +0000	[thread overview]
Message-ID: <20260718070251.4D1141F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260718065900.755631-2-hrushirajg23@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new vendor prefix 'vicharak' is not documented in vendor-prefixes.yaml.
--

--- Patch [1]: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Vicharak Vaaman board ---
commit 83c52c932b9201d9be9114ede15a03da032999a5
Author: Hrushiraj Gandhi <hrushirajg23@gmail.com>

dt-bindings: arm: rockchip: Add Vicharak Vaaman board
    
This commit documents the compatible string for the Vicharak Vaaman, an
RK3399-based single-board computer, in the rockchip bindings.

> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
[ ... ]
> @@ -1306,6 +1306,11 @@ properties:
>            - const: turing,rk1
>            - const: rockchip,rk3588
>  
> +      - description: Vicharak Vaaman
> +        items:
> +          - const: vicharak,vaaman
> +          - const: rockchip,rk3399

[Severity: Low]
Does the new vendor prefix vicharak need to be documented in
vendor-prefixes.yaml?

When introducing a new vendor compatible string, the prefix must be
registered in Documentation/devicetree/bindings/vendor-prefixes.yaml.
Without this entry, schema validation tooling will report an error
when make dt_binding_check is run.

> +
>        - description: WolfVision PF5 mainboard
>          items:
>            - const: wolfvision,rk3568-pf5

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260718065900.755631-1-hrushirajg23@gmail.com?part=1

  reply	other threads:[~2026-07-18  7:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-18  6:58 [PATCH v2 0/2] Add support for Vicharak Vaaman board Hrushiraj Gandhi
2026-07-18  6:58 ` Hrushiraj Gandhi
2026-07-18  6:58 ` [PATCH v2 1/2] dt-bindings: arm: rockchip: Add " Hrushiraj Gandhi
2026-07-18  6:58   ` Hrushiraj Gandhi
2026-07-18  7:02   ` sashiko-bot [this message]
2026-07-18  7:47   ` Krzysztof Kozlowski
2026-07-18  7:47     ` Krzysztof Kozlowski
2026-07-18  6:59 ` [PATCH v2 2/2] arm64: dts: " Hrushiraj Gandhi
2026-07-18  6:59   ` Hrushiraj Gandhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260718070251.4D1141F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hrushirajg23@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.