Re: [PATCH net-next v9 09/12] net: phylink: add .pcs_link_down PCS OP

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The kernel-doc comment for `pcs_link_down()` incorrectly names the function as `pcs_link_up()`, due to a copy-paste error.
--

--- Patch [9]: [PATCH net-next v9 09/12] net: phylink: add .pcs_link_down PCS OP ---
commit 44243b57b5aa440d9df2c5da5110db53f51717a0
Author: Christian Marangi <ansuelsmth@gmail.com>

net: phylink: add .pcs_link_down PCS OP

This commit adds a .pcs_link_down operation to the phylink_pcs_ops
structure, allowing PCS drivers to define specific link teardown behavior.
The new callback is invoked during phylink_link_down() immediately after
the MAC link is brought down.

[ ... ]

> diff --git a/include/linux/phylink.h b/include/linux/phylink.h
> index 15e6b1a39dfe2..ecf4c384fd31c 100644
> --- a/include/linux/phylink.h
> +++ b/include/linux/phylink.h
> @@ -690,6 +692,16 @@ void pcs_an_restart(struct phylink_pcs *pcs);
>  void pcs_link_up(struct phylink_pcs *pcs, unsigned int neg_mode,
>  		 phy_interface_t interface, int speed, int duplex);
>  
> +/**
> + * pcs_link_up() - tear down link between MAC and PCS

[Severity: Low]
This isn't a bug, but should this kernel-doc name be pcs_link_down() to match
the function prototype below it? This copy-paste typo will likely cause a
kernel-doc documentation build warning.

> + * @pcs: a pointer to a &struct phylink_pcs.
> + *
> + * This call will be made just after mac_link_down() to inform the PCS the
> + * link has gone down. PCS should be configured to stop processing packets
> + * for transmission and reception.
> + */
> +void pcs_link_down(struct phylink_pcs *pcs);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717065448.1498335-1-ansuelsmth@gmail.com?part=9