Re: [PATCH v15 2/3] samples: rust: add Rust serial device bus sample device driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect device tree property used for serial baud rate configuration.
--

--- Patch [2]: [PATCH v15 2/3] samples: rust: add Rust serial device bus sample device driver ---
commit 7885024c6abc3e1d37bf3499dc357753c532b4d5
Author: Markus Probst <markus.probst@posteo.de>

samples: rust: add Rust serial device bus sample device driver

This commit adds a sample Rust serial device bus device driver illustrating
the usage of the serial device bus abstractions. The driver probes through
either a match of device or driver name, or a match within the OF ID table.

> diff --git a/samples/rust/rust_driver_serdev.rs b/samples/rust/rust_driver_serdev.rs
> new file mode 100644
> index 0000000000000..a12b1412db30c
> --- /dev/null
> +++ b/samples/rust/rust_driver_serdev.rs
> @@ -0,0 +1,90 @@

[ ... ]

> +    fn probe<'bound>(
> +        sdev: &'bound serdev::Device<Core<'_>>,
> +        _info: Option<&'bound Self::IdInfo>,
> +    ) -> impl PinInit<Self, Error> + 'bound {
> +        let dev = sdev.as_ref();
> +
> +        dev_dbg!(dev, "Probe Rust Serial device bus device driver sample.\n");
> +
> +        if sdev
> +            .set_baudrate(
> +                dev.fwnode()
> +                    .and_then(|fwnode| fwnode.property_read(c"baudrate").optional())

[Severity: Medium]
Does this use the correct device tree property for the serial baud rate?

Standard serial device nodes typically use current-speed rather than
baudrate. If baudrate is queried, will the driver fail to read the
configured rate from standard nodes and silently fall back to the 115200
default? 

Since this is a sample driver, would it be better to query current-speed so
it serves as a correct template for new developers?

> +                    .unwrap_or(115200),
> +            )
> +            .is_err()
> +        {
> +            return Err(EINVAL);
> +        }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260718-rust_serdev-v15-0-208ed2e6ec15@posteo.de?part=2