All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Eikmeyer <dev@deq.rocks>
To: sashiko-reviews@lists.linux.dev
Cc: Andre Eikmeyer <dev@deq.rocks>,
	linux-input@vger.kernel.org, jikos@kernel.org,
	bentiss@kernel.org, gargaditya08@live.com,
	dmitry.torokhov@gmail.com
Subject: Re: [PATCH 1/2] HID: apple: preserve keyboard backlight across T2 resume
Date: Sat, 18 Jul 2026 17:00:51 +0200	[thread overview]
Message-ID: <20260718150106.7774-1-dev@deq.rocks> (raw)
In-Reply-To: <20260718123558.0ABF41F000E9@smtp.kernel.org>

Thanks for pointing this out.

LED_CORE_SUSPENDRESUME was needed with the older apple-bce suspend
implementation for which the original fix was tested. I maintain the
apple-bce source consumed by T2Linux as well as its split replacement,
t2bce.

Both current implementations now suspend the VHCI deterministically and
re-enumerate its devices after resume. The transport takes the keyboard
device offline during suspend, so its backlight does not remain powered
when LED_CORE_SUSPENDRESUME is removed. On resume, however, the flag makes
the LED core issue a synchronous request through the stale HID device
before re-enumeration completes, resulting in -ENODEV.

The new behavior was tested on a MacBookPro15,1 with a butterfly keyboard
and a MacBookAir9,1 with a Magic Keyboard. In both cases the backlight is
off during suspend and restored correctly after resume.


      reply	other threads:[~2026-07-18 15:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-18 12:15 [PATCH 1/2] HID: apple: preserve keyboard backlight across T2 resume Andre Eikmeyer
2026-07-18 12:15 ` [PATCH 2/2] HID: apple: use the standard keyboard backlight LED name Andre Eikmeyer
2026-07-18 12:36   ` sashiko-bot
2026-07-18 15:00     ` Andre Eikmeyer
2026-07-18 12:35 ` [PATCH 1/2] HID: apple: preserve keyboard backlight across T2 resume sashiko-bot
2026-07-18 15:00   ` Andre Eikmeyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260718150106.7774-1-dev@deq.rocks \
    --to=dev@deq.rocks \
    --cc=bentiss@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gargaditya08@live.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.