From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1562E26ED3A for ; Sat, 18 Jul 2026 15:32:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784388779; cv=none; b=ZtKlEpGhav3ykapKxfAFvRS5JhgWM4faFO2fyhMhVU5LDCmcHZ3kQJxbxctP6I0GQeZmzM3dy7bovL8crXzjTObktnEyeulMpnEQ8TBbNeGwGi4ZIpQFzQX3xsffQAqVfi5vTvnPfbyB8GFfjQwGYg7v5R0bmNuMhm0HPquqW4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784388779; c=relaxed/simple; bh=vMxi0GBCmk6kSxxY3msXn6b8DUdRebKtLoidNsiWryg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=MHbGjlxG8KGjf5ory3b+u1Vwwf6lgel+dJe911ntDI0y3yy6WpI3VLpdCu5la8kiEghVsZPU/0J5XM35POdg/pFREXamuP3rMjBjjdLsM1IGMwtG2+licaB1Dzu+Fjydt1rebsNU6/y+dFuLA9eiqsyLwQwqnAWLarFm051kmvY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2cae1a3a744so66733335ad.3 for ; Sat, 18 Jul 2026 08:32:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784388777; x=1784993577; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=lgLs8NK0XHHTysnGduh8WTtXMi/Zls+hjiJh2kwYBOI=; b=BH0/nwJOI0H2txVlgeRU1SHbfWiLCQYuoz7GzC1k5xXPkZqpRwTtW+Kv1mDmhvj1Q2 EAJCgFLsXok8DVVDpdiIakWqOlUQThLB4wUBx3uK4lmIyvzuBPpR8xuUpNSYtAbfgJ9U +U8YUAlig7e9qO/i55xQtk9PNZLTodH8WH2cyVskVvt0ADzcmHQmDve+YzmJr42ywolS XvwojukV2/dc2G+Bl9THkWuj79tvovZsj/38/K7/4bLGwQxNXWbiUDxl3Bc3xB02noNm ciCvXfh97SfgD3LpVqLWGy4+3nlXORd/+BK6sfeUky+fRFOYxbdgA8Koow0QRh9xod8v QHhQ== X-Forwarded-Encrypted: i=1; AHgh+RqrSWl7wcQdPSpPWtJs6oxkwELzNOxwHevqGkjyO44rpYTBPWwWSopXzYyvt/N5FUvbR2gaX/9aqiCrcXI=@vger.kernel.org X-Gm-Message-State: AOJu0YzO8Hln5ci8LmB1lF+r+AcxYYcfMdmENJdAcy4SKwuyJ3sHJOjM SUXNqCSnfNHcU9LW1MZiXB+KPz4DNHa8wz//DNTHmfmVQFk5mT4o38k= X-Gm-Gg: AfdE7ckUEQJ4Qvd9NdKQuCyNvo3Ja96Ph8HQP3zkAF1uTE9aBCz3n/K2nqxAmaCks+x 4Dw/26erSU7c3oTC6pV/hgCoiHq4luQsGdNMpdGCe5kG0WU1Q+hOxpYs89TlwDWo16phQBC5xtf KuCcmEtHIar+L8MHOW2A2KJj4/KU07/FHOnp/3bVlzF9fd95WlX3K+KY3NWHX5PyZB/zSX2T8UZ RJP1hiBDD4WT8ZPD0HNEF/zKjvHV6/9H/4xZTuceevDzCIlmT2NqRXvcDjGQfEl2UQ6zty4GHvI 3aMYV1B3Uab4g+J/jGDP/2Ywc8I7CstKhn+n/rUdL7ftYutBbkshMeU8hQ2T1UTNX4NWvxkxs6x I8vatHCKCsjwmqHdQ+CSIGfVZWVWAucZ5v3zsMSUdotOi7dhg1mxhaLGfGRwPEb4KoPkSSIJvWU cm3cj7IA7/AZ9WQ3J7R3VbzEZ/szcnHENwgFWsqUT464E5tG5C61+JB3E1Xv6Wt6IEvDvGlGNLM xBHcQx7Zg+HZ84= X-Received: by 2002:a17:902:ce0d:b0:2cc:9a86:9c42 with SMTP id d9443c01a7336-2cf349eb316mr75462215ad.45.1784388777183; Sat, 18 Jul 2026 08:32:57 -0700 (PDT) Received: from penguin.tail0a1999.ts.net (61-228-48-72.dynamic-ip.hinet.net. [61.228.48.72]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf344bd3aesm28731535ad.26.2026.07.18.08.32.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 08:32:56 -0700 (PDT) From: Shih-Yuan Lee To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Shih-Yuan Lee Subject: [PATCH v13 1/3] spi: pxa2xx: disable DMA for Apple MacBook8,1 Date: Sat, 18 Jul 2026 23:32:49 +0800 Message-Id: <20260718153251.7353-2-fourdollars@debian.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260718153251.7353-1-fourdollars@debian.org> References: <20260718153251.7353-1-fourdollars@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On MacBook8,1 (early 2015 12" MacBook), the LPSS SPI controller at 00:15.4 suffers from hardware DMA handshake failures and interrupt routing bugs, causing keyboard/touchpad transactions to fail when DMA is enabled. Move the forced PIO mode DMI quirk to spi-pxa2xx-pci.c (the LPSS host controller PCI glue driver) to avoid layering violations in client drivers (such as applespi). Add an explicit DMI match table for MacBook8,1 and a module parameter spi_pxa2xx_force_pio to allow forcing PIO mode on demand. Link: https://bugzilla.kernel.org/show_bug.cgi?id=108331 Signed-off-by: Shih-Yuan Lee --- drivers/spi/spi-pxa2xx-pci.c | 35 +++++++++++++++++++++++++++++++++-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-pxa2xx-pci.c b/drivers/spi/spi-pxa2xx-pci.c index cae77ac18520..31bdaa096d9e 100644 --- a/drivers/spi/spi-pxa2xx-pci.c +++ b/drivers/spi/spi-pxa2xx-pci.c @@ -18,9 +18,14 @@ #include #include +#include #include "spi-pxa2xx.h" +static bool spi_pxa2xx_force_pio; +module_param_named(force_pio, spi_pxa2xx_force_pio, bool, 0444); +MODULE_PARM_DESC(force_pio, "Force PIO mode (disables DMA) for SPI transfers. ([0] = disabled, 1 = enabled)"); + #define PCI_DEVICE_ID_INTEL_QUARK_X1000 0x0935 #define PCI_DEVICE_ID_INTEL_BYT 0x0f0e #define PCI_DEVICE_ID_INTEL_MRFLD 0x1194 @@ -93,6 +98,32 @@ static void lpss_dma_put_device(void *dma_dev) pci_dev_put(dma_dev); } +static const struct dmi_system_id pxa2xx_spi_pci_dmi_table[] = { + { + .ident = "Apple MacBook8,1", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "MacBook8,1"), + }, + }, + { } +}; + +static bool pxa2xx_spi_pci_can_dma(struct pci_dev *dev) +{ + if (spi_pxa2xx_force_pio) { + pci_info(dev, "Forcing PIO mode (disabling DMA)\n"); + return false; + } + + if (dmi_check_system(pxa2xx_spi_pci_dmi_table)) { + pci_info(dev, "MacBook8,1 detected: disabling DMA to force PIO mode\n"); + return false; + } + + return true; +} + static int lpss_spi_setup(struct pci_dev *dev, struct pxa2xx_spi_controller *c) { struct ssp_device *ssp = &c->ssp; @@ -166,7 +197,7 @@ static int lpss_spi_setup(struct pci_dev *dev, struct pxa2xx_spi_controller *c) c->dma_filter = lpss_dma_filter; c->dma_burst_size = 1; - c->enable_dma = 1; + c->enable_dma = pxa2xx_spi_pci_can_dma(dev); return 0; } @@ -238,7 +269,7 @@ static int mrfld_spi_setup(struct pci_dev *dev, struct pxa2xx_spi_controller *c) c->dma_filter = lpss_dma_filter; c->dma_burst_size = 8; - c->enable_dma = 1; + c->enable_dma = pxa2xx_spi_pci_can_dma(dev); return 0; } -- 2.39.5