From: Jason Gunthorpe <jgg@ziepe.ca>
To: Zhu Yanjun <yanjun.zhu@linux.dev>
Cc: Serhat Kumral <serhatkumral1@gmail.com>,
Leon Romanovsky <leon@kernel.org>,
Zhu Yanjun <zyjzyj2000@gmail.com>,
David Ahern <dsahern@kernel.org>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+8c9eede336e3a843750e@syzkaller.appspotmail.com
Subject: Re: [RFC PATCH 1/2] RDMA/rxe: drive UDP tunnel socket lifetime from the GID table
Date: Sat, 18 Jul 2026 13:04:34 -0300 [thread overview]
Message-ID: <20260718160434.GH701389@ziepe.ca> (raw)
In-Reply-To: <f1794905-27b4-42a2-bce8-ff420dd13c6d@linux.dev>
On Sat, Jul 18, 2026 at 09:01:50AM -0700, Zhu Yanjun wrote:
> However, hiding the socket setup failures from the user-space netlink
> interface concerns me. If rxe_setup_udp_tunnel() fails during
> rxe_add_gid() (e.g., due to port 4791 conflicts or transient -ENOMEM),
> rdma link add will return success.
We don't have any way to fully deal with GID creation failures due to how
everything works, but we should be to arrange things so that the
failed GID is at least unusable. This may already be the case, I
haven't check carefully.
So the failure mode is not silent and is reported to userspace through
missing GID table entries.
If you want newlink to also return a failure code we'd have to make it
synchronously create the gid entries and ensure that they are all
created.
I view that as a followup topic though
Jason
next prev parent reply other threads:[~2026-07-18 16:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 14:26 [RFC PATCH 1/2] RDMA/rxe: drive UDP tunnel socket lifetime from the GID table Serhat Kumral
2026-07-18 14:26 ` [RFC PATCH 2/2] RDMA/nldev: remove the unused dellink link op Serhat Kumral
2026-07-18 15:39 ` [RFC PATCH 1/2] RDMA/rxe: drive UDP tunnel socket lifetime from the GID table Jason Gunthorpe
2026-07-18 16:01 ` Zhu Yanjun
2026-07-18 16:04 ` Jason Gunthorpe [this message]
2026-07-19 5:08 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260718160434.GH701389@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dsahern@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=serhatkumral1@gmail.com \
--cc=syzbot+8c9eede336e3a843750e@syzkaller.appspotmail.com \
--cc=yanjun.zhu@linux.dev \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.