Re: [PATCH] staging: fbtft: fix checkpatch errors in fbtft-bus.c

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Removing the trailing comma from the `define_fbtft_write_reg` macro invocations reduces the number of arguments passed from 4 to 3. Since the macro is defined with exactly 4 parameters, this will cause a C preprocessor build failure.
--

--- Patch [1]: [PATCH] staging: fbtft: fix checkpatch errors in fbtft-bus.c ---
commit 282c7bb2732808bae2a5a39160285600d23aa964
Author: Shivesh <chanelshivesh@gmail.com>

staging: fbtft: fix checkpatch errors in fbtft-bus.c

This commit attempts to fix space-related checkpatch errors in fbtft-bus.c.
It does this by removing the trailing comma from macro invocations when the
modifier argument is empty.

> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -62,9 +62,9 @@ out:									      \
>  }                                                                             \
>  EXPORT_SYMBOL(func);
>  
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)

[Severity: Low]
Does removing the trailing comma here cause a build failure?

The define_fbtft_write_reg macro is defined earlier in the file to mandate
exactly 4 parameters:

#define define_fbtft_write_reg(func, buffer_type, data_type, modifier)

By removing the comma, the invocation for 8-bit bus writes only provides 3
arguments instead of 4, which will cause a C preprocessor error.

>  define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
> -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
> +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)

[Severity: Low]
Similarly, will this invocation fail to compile since it also drops the
argument count to 3 instead of the required 4?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/6a5bc4a7.f1c1923d.2d2b59.05d9@mx.google.com?part=1