From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44672C4451B for ; Sat, 18 Jul 2026 22:10:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wlDF9-00046D-Na; Sat, 18 Jul 2026 18:10:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wlDF8-000401-49; Sat, 18 Jul 2026 18:10:46 -0400 Received: from pdx-out-010.esa.us-west-2.outbound.mail-perimeter.amazon.com ([52.12.53.23]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wlDF6-0006ot-AM; Sat, 18 Jul 2026 18:10:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1784412644; x=1815948644; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MBBs+r4D9ciSt9jJWEKbWpQa5N9YAToQOfGqPWyypko=; b=mlBRBarcqJjjD6l6DpuPUfb5q7EKp8dHrDr/YioAgAnVzncFvhqWRpLe oO8qxVm4Y8/UQTgxZ1+YyrQnj0ddAz2Rk6qQDjm8Tw/SGo3lEjmIYnokz WPnCfLdpDTDtF0g+KPaASk/iI0gx/muTjv+lSVPYczt7NovfKPY8OXvcn vec485+1nKJaYuQ1ek58xvnLoSqRxXNOCVa5/lCj6f0aOQ/AZ4XcC3VmH YEJZMEgHlBMCuYMaWOacJN/bfcoOoSpFHY4GnsEfEen+1oX7v+Dxf5QpQ /LYFJC3LzHe5DnPr/QUaRUqYDFb3kGeItgJhE5fgVvNJCOWbLpswxaA8p Q==; X-CSE-ConnectionGUID: B5fxCVjdQ72D+nla9K5uVA== X-CSE-MsgGUID: STLuVnsbTLeqUtl9rQQ6Ag== X-IronPort-AV: E=Sophos;i="6.25,171,1779148800"; d="scan'208";a="23795955" Received: from ip-10-5-6-203.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.6.203]) by internal-pdx-out-010.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2026 22:10:40 +0000 Received: from EX19MTAUWB002.ant.amazon.com [205.251.233.111:22030] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.58.199:2525] with esmtp (Farcaster) id bd32d152-e438-4285-8d5c-6547172343b7; Sat, 18 Jul 2026 22:10:40 +0000 (UTC) X-Farcaster-Flow-ID: bd32d152-e438-4285-8d5c-6547172343b7 Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWB002.ant.amazon.com (10.250.64.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 18 Jul 2026 22:10:40 +0000 Received: from ip-10-253-83-51.amazon.com (172.19.99.218) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 18 Jul 2026 22:10:30 +0000 From: Alexander Graf To: CC: , , , , Song Gao <17746591750@163.com>, Aditya Gupta , Alexey Kardashevskiy , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Farhan Ali , Alistair Francis , "Alistair Francis" , Antony Pavlov , Markus Armbruster , Artyom Tarasenko , BALATON Zoltan , Felipe Balbi , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Christian Borntraeger , Brian Cain , Hendrik Brueckner , Chao Liu , "Huacai Chen" , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Helge Deller , Dorjoy Chowdhury , "Edgar E . Iglesias" , Alexandre Iooss , Eric Farman , Fabiano Rosas , Francisco Iglesias , "Gaurav Sharma" , Gautam Gala , "Harsh Prateek Bora" , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Jan Kiszka , Max Filippov , Joel Stanley , Jared Rossi , Tyrone Ting , Frederic Konrad , Laurent Vivier , "Manos Pitsidianakis" , Bibo Mao , Mark Cave-Ayland , Glenn Miles , Matthew Rosato , Michael Rolnik , "Michael S . Tsirkin" , Niek Linnenbank , Nicholas Piggin , Palmer Dabbelt , Halil Pasic , Paolo Bonzini , Peter Maydell , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Pierrick Bouvier" , Richard Henderson , Sai Pavan Boddu , Samuel Tardieu , Bernhard Beschow , Stafford Horne , Sergio Lopez , "Subbaraya Sundeep" , Thomas Huth , "Ran Wang" , Hao Wu Subject: [RFC PATCH v2 120/137] hw/intc/mips_gic: Register reset handler at realize, not instance_init Date: Sat, 18 Jul 2026 21:36:35 +0000 Message-ID: <20260718213652.37673-121-graf@amazon.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260718213652.37673-1-graf@amazon.com> References: <20260711223707.42139-1-graf@amazon.com> <20260718213652.37673-1-graf@amazon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.19.99.218] X-ClientProxiedBy: EX19D039UWB002.ant.amazon.com (10.13.138.79) To EX19D001UWA001.ant.amazon.com (10.13.138.214) Received-SPF: pass client-ip=52.12.53.23; envelope-from=prvs=65292d44c=graf@amazon.de; helo=pdx-out-010.esa.us-west-2.outbound.mail-perimeter.amazon.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.01, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org mips_gic_init() calls qemu_register_reset(gic_reset, s), but there is no matching qemu_unregister_reset() in an instance_finalize. This leaks a reset handler every time the type is introspected via device-list-properties (object_new + object_unref). The following patch makes each legacy reset handler visible in the composition tree under /machine/reset-container/legacy-reset[*], which turns this pre-existing leak into a device-introspect-test failure. Move the registration to mips_gic_realize(), matching every other in-tree interrupt controller. AI-used-for: code (refactoring) Signed-off-by: Alexander Graf --- hw/intc/mips_gic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/mips_gic.c b/hw/intc/mips_gic.c index 4777c70d6b..c0f1501bcc 100644 --- a/hw/intc/mips_gic.c +++ b/hw/intc/mips_gic.c @@ -394,7 +394,6 @@ static void mips_gic_init(Object *obj) memory_region_init_io(&s->mr, OBJECT(s), &gic_ops, s, "mips-gic", GIC_ADDRSPACE_SZ); sysbus_init_mmio(sbd, &s->mr); - qemu_register_reset(gic_reset, s); } static void mips_gic_realize(DeviceState *dev, Error **errp) @@ -430,6 +429,7 @@ static void mips_gic_realize(DeviceState *dev, Error **errp) for (i = 0; i < s->num_irq; i++) { s->irq_state[i].irq = qdev_get_gpio_in(dev, i); } + qemu_register_reset(gic_reset, s); } static const Property mips_gic_properties[] = { -- 2.47.1