From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5DE93C4451B for ; Sat, 18 Jul 2026 22:11:27 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wlDFe-00056g-7y; Sat, 18 Jul 2026 18:11:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wlDFH-0004PK-Sz; Sat, 18 Jul 2026 18:10:57 -0400 Received: from pdx-out-001.esa.us-west-2.outbound.mail-perimeter.amazon.com ([44.245.243.92]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wlDFG-0006pi-3S; Sat, 18 Jul 2026 18:10:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1784412654; x=1815948654; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=XYX1pHdcrjyubK5N7hVhORucyl2rn9044QM9LF7h6vs=; b=nHsRRLtRrObqFVmxaPGxKEmkoSs+PrM2QpQ6huZJ9mujRviaC4kvlI7r 8h+bDakLKyEpVzEKiVZnBjgWM10mFOF6DuNyqp+apdvMGME7zoSOtSDt3 I8UEbtTaKAydvVfN3fO4YsGfexDE/wvW4v4xClLqOFVO96bYQAaHSgXhO o9noqxktSfarKaMwo0Gr5uwP2kfGBP1GpAMJD7b/JCN/VEE0FHqkPsz0g goPRWNrcs/8YxcqTacr0wZlrMPz26NrFVwtKBVJdZIQwXdyd4hcWDQdNx aFLfi9c1nPBvXAZ2LcMDpGXTNtrsbp33w5+QxJpAIBQcvrnl0KUPl9zGh Q==; X-CSE-ConnectionGUID: t7d5Fp80QHK+OtGgRFOP7A== X-CSE-MsgGUID: +AayU4DqTh+B0/BqKRE/hQ== X-IronPort-AV: E=Sophos;i="6.25,171,1779148800"; d="scan'208";a="23423713" Received: from ip-10-5-0-115.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.0.115]) by internal-pdx-out-001.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2026 22:10:50 +0000 Received: from EX19MTAUWA002.ant.amazon.com [205.251.233.234:27271] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.40.177:2525] with esmtp (Farcaster) id a1fc49ce-f2a9-4500-96a2-641a34b0429e; Sat, 18 Jul 2026 22:10:49 +0000 (UTC) X-Farcaster-Flow-ID: a1fc49ce-f2a9-4500-96a2-641a34b0429e Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWA002.ant.amazon.com (10.250.64.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 18 Jul 2026 22:10:49 +0000 Received: from ip-10-253-83-51.amazon.com (172.19.99.218) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 18 Jul 2026 22:10:40 +0000 From: Alexander Graf To: CC: , , , , Song Gao <17746591750@163.com>, Aditya Gupta , Alexey Kardashevskiy , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Farhan Ali , Alistair Francis , "Alistair Francis" , Antony Pavlov , Markus Armbruster , Artyom Tarasenko , BALATON Zoltan , Felipe Balbi , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Christian Borntraeger , Brian Cain , Hendrik Brueckner , Chao Liu , "Huacai Chen" , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Helge Deller , Dorjoy Chowdhury , "Edgar E . Iglesias" , Alexandre Iooss , Eric Farman , Fabiano Rosas , Francisco Iglesias , "Gaurav Sharma" , Gautam Gala , "Harsh Prateek Bora" , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Jan Kiszka , Max Filippov , Joel Stanley , Jared Rossi , Tyrone Ting , Frederic Konrad , Laurent Vivier , "Manos Pitsidianakis" , Bibo Mao , Mark Cave-Ayland , Glenn Miles , Matthew Rosato , Michael Rolnik , "Michael S . Tsirkin" , Niek Linnenbank , Nicholas Piggin , Palmer Dabbelt , Halil Pasic , Paolo Bonzini , Peter Maydell , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Pierrick Bouvier" , Richard Henderson , Sai Pavan Boddu , Samuel Tardieu , Bernhard Beschow , Stafford Horne , Sergio Lopez , "Subbaraya Sundeep" , Thomas Huth , "Ran Wang" , Hao Wu Subject: [RFC PATCH v2 121/137] hw/core/reset: Give the root reset container and legacy shims a QOM path Date: Sat, 18 Jul 2026 21:36:36 +0000 Message-ID: <20260718213652.37673-122-graf@amazon.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260718213652.37673-1-graf@amazon.com> References: <20260711223707.42139-1-graf@amazon.com> <20260718213652.37673-1-graf@amazon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.19.99.218] X-ClientProxiedBy: EX19D039UWB002.ant.amazon.com (10.13.138.79) To EX19D001UWA001.ant.amazon.com (10.13.138.214) Received-SPF: pass client-ip=44.245.243.92; envelope-from=prvs=65292d44c=graf@amazon.de; helo=pdx-out-001.esa.us-west-2.outbound.mail-perimeter.amazon.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org The root ResettableContainer and the LegacyReset shim objects are long-lived singletons held only by static pointers and refcounts. Give them a canonical path in the composition tree so qom-tree/qom-list can enumerate them and so device_set_realized() can require a QOM parent for every object. /machine/reset-container (ResettableContainer) /machine/reset-container/legacy-reset[N] (LegacyReset shims) get_root_reset_container() is first reached from configure_accelerators() or machine_run_board_init(), both of which run after qemu_create_machine(), so qdev_get_machine() is available. qemu_unregister_reset() switches from object_unref() to object_unparent() to release the child<> ref. AI-used-for: code (refactoring) Signed-off-by: Alexander Graf --- hw/core/reset.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/core/reset.c b/hw/core/reset.c index e7230b49b7..34c1ab84d9 100644 --- a/hw/core/reset.c +++ b/hw/core/reset.c @@ -27,6 +27,7 @@ #include "system/reset.h" #include "hw/core/resettable.h" #include "hw/core/resetcontainer.h" +#include "hw/core/qdev.h" /* * Return a pointer to the singleton container that holds all the Resettable @@ -38,7 +39,9 @@ static ResettableContainer *get_root_reset_container(void) if (!root_reset_container) { root_reset_container = - RESETTABLE_CONTAINER(object_new(TYPE_RESETTABLE_CONTAINER)); + RESETTABLE_CONTAINER(object_new_child(qdev_get_machine(), + "reset-container", + TYPE_RESETTABLE_CONTAINER)); } return root_reset_container; } @@ -94,7 +97,8 @@ static void legacy_reset_class_init(ObjectClass *klass, const void *data) void qemu_register_reset(QEMUResetHandler *func, void *opaque) { - Object *obj = object_new(TYPE_LEGACY_RESET); + Object *obj = object_new_child(OBJECT(get_root_reset_container()), + "legacy-reset[*]", TYPE_LEGACY_RESET); LegacyReset *lr = LEGACY_RESET(obj); lr->func = func; @@ -104,7 +108,8 @@ void qemu_register_reset(QEMUResetHandler *func, void *opaque) void qemu_register_reset_nosnapshotload(QEMUResetHandler *func, void *opaque) { - Object *obj = object_new(TYPE_LEGACY_RESET); + Object *obj = object_new_child(OBJECT(get_root_reset_container()), + "legacy-reset[*]", TYPE_LEGACY_RESET); LegacyReset *lr = LEGACY_RESET(obj); lr->func = func; @@ -156,7 +161,7 @@ void qemu_unregister_reset(QEMUResetHandler *func, void *opaque) if (obj) { qemu_unregister_resettable(obj); - object_unref(obj); + object_unparent(obj); } } -- 2.47.1