From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A3BBC4451B for ; Sat, 18 Jul 2026 21:48:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wlCtd-0006Bs-G6; Sat, 18 Jul 2026 17:48:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wlCta-000604-4G; Sat, 18 Jul 2026 17:48:30 -0400 Received: from pdx-out-003.esa.us-west-2.outbound.mail-perimeter.amazon.com ([44.246.68.102]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wlCtY-0003Rd-E2; Sat, 18 Jul 2026 17:48:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1784411308; x=1815947308; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rGAGY0Wi6cyaSOfwgMEuCJdmHdtO2xjhFVJiVN2futs=; b=snAvnvBoQqiTh0ssfMyMXbJRYqVq7/HIpYGyKQkPovOg9dRAwRGE8kwQ fwncQ2n4DW0BzBzHEtNvIByMr/VuZ8JnioxF21Ws4uUgHbNQ+ZgroRwLk W2FioCOyXmgmRy6oOXBeYnT8+2FQ6WouQ3rrpsiNgedDqTrlpOdxR3/Wx AAiwEsJJBCUxhDiixe6ZtIz6OWG8SsyUmBQ5OQMgmVLp4tdpRpvVOJfyL jIN9jiN/1PaS5VjpoExYhAij366ayZnj13M1KYXokAvP/VoCE7LyIKWDf nXuZIBR3yB8LGEehD+2OSED5KdNV856CA6lQ/5uWJJM+K6r3X7MC1+TXn A==; X-CSE-ConnectionGUID: 7aLDfXvuQ52YPGFfg6tTzg== X-CSE-MsgGUID: ikjamM4BTLOY3s2Qa009Fg== X-IronPort-AV: E=Sophos;i="6.25,171,1779148800"; d="scan'208";a="23941803" Received: from ip-10-5-0-115.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.0.115]) by internal-pdx-out-003.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2026 21:48:16 +0000 Received: from EX19MTAUWB001.ant.amazon.com [205.251.233.104:28310] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.19.34:2525] with esmtp (Farcaster) id 863ce089-3c89-49cf-9e94-6f800fb22f07; Sat, 18 Jul 2026 21:48:16 +0000 (UTC) X-Farcaster-Flow-ID: 863ce089-3c89-49cf-9e94-6f800fb22f07 Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWB001.ant.amazon.com (10.250.64.248) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 18 Jul 2026 21:48:16 +0000 Received: from ip-10-253-83-51.amazon.com (172.19.99.218) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 18 Jul 2026 21:48:06 +0000 From: Alexander Graf To: CC: , , , , Song Gao <17746591750@163.com>, Aditya Gupta , Alexey Kardashevskiy , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Farhan Ali , Alistair Francis , "Alistair Francis" , Antony Pavlov , Markus Armbruster , Artyom Tarasenko , BALATON Zoltan , Felipe Balbi , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Christian Borntraeger , Brian Cain , Hendrik Brueckner , Chao Liu , "Huacai Chen" , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Helge Deller , Dorjoy Chowdhury , "Edgar E . Iglesias" , Alexandre Iooss , Eric Farman , Fabiano Rosas , Francisco Iglesias , "Gaurav Sharma" , Gautam Gala , "Harsh Prateek Bora" , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Jan Kiszka , Max Filippov , Joel Stanley , Jared Rossi , Tyrone Ting , Frederic Konrad , Laurent Vivier , "Manos Pitsidianakis" , Bibo Mao , Mark Cave-Ayland , Glenn Miles , Matthew Rosato , Michael Rolnik , "Michael S . Tsirkin" , Niek Linnenbank , Nicholas Piggin , Palmer Dabbelt , Halil Pasic , Paolo Bonzini , Peter Maydell , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Pierrick Bouvier" , Richard Henderson , Sai Pavan Boddu , Samuel Tardieu , Bernhard Beschow , Stafford Horne , Sergio Lopez , "Subbaraya Sundeep" , Thomas Huth , "Ran Wang" , Hao Wu Subject: [RFC PATCH v2 041/137] hw/core/sysbus: Skip nested devices in foreach_dynamic_sysbus_device() Date: Sat, 18 Jul 2026 21:35:16 +0000 Message-ID: <20260718213652.37673-42-graf@amazon.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260718213652.37673-1-graf@amazon.com> References: <20260711223707.42139-1-graf@amazon.com> <20260718213652.37673-1-graf@amazon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.19.99.218] X-ClientProxiedBy: EX19D042UWB002.ant.amazon.com (10.13.139.175) To EX19D001UWA001.ant.amazon.com (10.13.138.214) Received-SPF: pass client-ip=44.246.68.102; envelope-from=prvs=65292d44c=graf@amazon.de; helo=pdx-out-003.esa.us-west-2.outbound.mail-perimeter.amazon.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org find_sysbus_device() recurses into any non-sysbus child of /machine/peripheral{,-anon} on the assumption that only pure containers appear there. Once user-created devices start QOM-parenting their internal helper sysbus devices under themselves (next patch, and the general direction of this series), those helpers become visible to foreach_dynamic_sysbus_device() and are mis-treated as user-requested dynamic sysbus devices -- sysbus-fdt aborts on the first one it has no binding for. Skip recursion into any non-sysbus TYPE_DEVICE: internal helper devices are board-managed and never candidates for platform-bus placement or FDT node generation. No in-tree caller currently relies on recursion through TYPE_DEVICE: user -device sysbus devices are direct children of the peripheral container. AI-used-for: code (refactoring) Signed-off-by: Alexander Graf --- hw/core/sysbus.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c index bbacb07e1a..85f56b68fb 100644 --- a/hw/core/sysbus.c +++ b/hw/core/sysbus.c @@ -42,7 +42,15 @@ static int find_sysbus_device(Object *obj, void *opaque) sbdev = (SysBusDevice *)dev; if (!sbdev) { - /* Container, traverse it for children */ + /* + * Only recurse into pure containers. A user-created -device + * may internally instantiate helper sysbus children under + * itself; those are board-managed and must not be treated + * as dynamic sysbus devices. + */ + if (object_dynamic_cast(obj, TYPE_DEVICE)) { + return 0; + } return object_child_foreach(obj, find_sysbus_device, opaque); } -- 2.47.1