From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C09C1C4451B for ; Sat, 18 Jul 2026 21:59:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wlD3w-0004Em-Rz; Sat, 18 Jul 2026 17:59:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wlD3u-0004BS-Kc; Sat, 18 Jul 2026 17:59:10 -0400 Received: from pdx-out-002.esa.us-west-2.outbound.mail-perimeter.amazon.com ([44.246.1.125]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wlD3s-0004or-Px; Sat, 18 Jul 2026 17:59:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1784411948; x=1815947948; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5wFHCEJ3Et/505+6rAKfI9MuJkHGEquIWgQUEPU7qyY=; b=GDAWqIBndJBaWwXMQ/uFktcE24hglVGWk4QtQJfoSSTiznuZACdZNhIV 5YMeBNHmCzQY+QUfIeg1T6jMXAeCZ67qNlJ+hTtveqEi43Rt/Jn+ksoDE ya1R2JFIr6ttRsQmAZGsqsN/1euWY96Z3BeRW46xejMN+Rr0VfC1UYTvv +aa4PPPoMkUk+H5gow4FE3XDxRdzlolvR3rR2M1EuP64anQccBaiXavrN Ut/r5zbqEqiJdiM0qA39iKtqr6uwDDwmeyUGMpqRiQVCdHBBoCT0YKxX8 E1jd/yPr8dtZwSj84Ly1D86Ipz842nOYocp8fWh0Z94OSA2PB60C4CRH6 w==; X-CSE-ConnectionGUID: FzvW/uALS9y5ZxcSYYDaow== X-CSE-MsgGUID: qiD9RJq6RMuiHSRx7JUGIw== X-IronPort-AV: E=Sophos;i="6.25,171,1779148800"; d="scan'208";a="23927484" Received: from ip-10-5-9-48.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.9.48]) by internal-pdx-out-002.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2026 21:59:05 +0000 Received: from EX19MTAUWC002.ant.amazon.com [205.251.233.51:5221] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.58.199:2525] with esmtp (Farcaster) id 1a5b5e0f-92b0-48a1-bae7-850cfac8fc5e; Sat, 18 Jul 2026 21:59:05 +0000 (UTC) X-Farcaster-Flow-ID: 1a5b5e0f-92b0-48a1-bae7-850cfac8fc5e Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWC002.ant.amazon.com (10.250.64.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 18 Jul 2026 21:59:04 +0000 Received: from ip-10-253-83-51.amazon.com (172.19.99.218) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 18 Jul 2026 21:58:55 +0000 From: Alexander Graf To: CC: , , , , Song Gao <17746591750@163.com>, Aditya Gupta , Alexey Kardashevskiy , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Farhan Ali , Alistair Francis , "Alistair Francis" , Antony Pavlov , Markus Armbruster , Artyom Tarasenko , BALATON Zoltan , Felipe Balbi , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Christian Borntraeger , Brian Cain , Hendrik Brueckner , Chao Liu , "Huacai Chen" , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Helge Deller , Dorjoy Chowdhury , "Edgar E . Iglesias" , Alexandre Iooss , Eric Farman , Fabiano Rosas , Francisco Iglesias , "Gaurav Sharma" , Gautam Gala , "Harsh Prateek Bora" , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Jan Kiszka , Max Filippov , Joel Stanley , Jared Rossi , Tyrone Ting , Frederic Konrad , Laurent Vivier , "Manos Pitsidianakis" , Bibo Mao , Mark Cave-Ayland , Glenn Miles , Matthew Rosato , Michael Rolnik , "Michael S . Tsirkin" , Niek Linnenbank , Nicholas Piggin , Palmer Dabbelt , Halil Pasic , Paolo Bonzini , Peter Maydell , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Pierrick Bouvier" , Richard Henderson , Sai Pavan Boddu , Samuel Tardieu , Bernhard Beschow , Stafford Horne , Sergio Lopez , "Subbaraya Sundeep" , Thomas Huth , "Ran Wang" , Hao Wu Subject: [RFC PATCH v2 079/137] hw/audio: Give -audio model= devices a QOM parent Date: Sat, 18 Jul 2026 21:35:54 +0000 Message-ID: <20260718213652.37673-80-graf@amazon.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260718213652.37673-1-graf@amazon.com> References: <20260711223707.42139-1-graf@amazon.com> <20260718213652.37673-1-graf@amazon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.19.99.218] X-ClientProxiedBy: EX19D043UWA001.ant.amazon.com (10.13.139.45) To EX19D001UWA001.ant.amazon.com (10.13.138.214) Received-SPF: pass client-ip=44.246.1.125; envelope-from=prvs=65292d44c=graf@amazon.de; helo=pdx-out-002.esa.us-west-2.outbound.mail-perimeter.amazon.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org audio_model_devices_init() is the '-audio model=' command-line path, so parent the created device under /machine/peripheral-anon like -device without id= would. The intel-hda .init helper for '-audio model=hda' additionally creates an hda-duplex codec on the controller's HDA bus; the codec is a natural child of the controller device it just spawned. Both sites drop the extra unref: the child<> property now holds the reference. AI-used-for: code (refactoring) Signed-off-by: Alexander Graf --- hw/audio/intel-hda.c | 4 ++-- hw/audio/model.c | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index cd4743a405..f51c98511a 100644 --- a/hw/audio/intel-hda.c +++ b/hw/audio/intel-hda.c @@ -1313,9 +1313,9 @@ static void intel_hda_and_codec_init(const char *audiodev) intel_hda = qdev_device_add_from_qdict(props, false, &error_fatal); hdabus = QLIST_FIRST(&intel_hda->child_bus); - codec = qdev_new_orphan("hda-duplex"); + codec = qdev_new(OBJECT(intel_hda), "codec", "hda-duplex"); qdev_prop_set_string(codec, "audiodev", audiodev); - qdev_realize_and_unref(codec, hdabus, &error_fatal); + qdev_realize(codec, hdabus, &error_fatal); object_unref(intel_hda); } diff --git a/hw/audio/model.c b/hw/audio/model.c index bd8ca35153..308b899459 100644 --- a/hw/audio/model.c +++ b/hw/audio/model.c @@ -110,10 +110,11 @@ void audio_model_init(void) } if (c->typename) { - DeviceState *dev = qdev_new_orphan(c->typename); + DeviceState *dev = qdev_new(machine_get_container("peripheral-anon"), + "audio[*]", c->typename); BusState *bus = qdev_find_default_bus(DEVICE_GET_CLASS(dev), &error_fatal); qdev_prop_set_string(dev, "audiodev", audiodev_id); - qdev_realize_and_unref(dev, bus, &error_fatal); + qdev_realize(dev, bus, &error_fatal); } else { c->init(audiodev_id); } -- 2.47.1