From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7935FC44521 for ; Sat, 18 Jul 2026 22:01:35 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wlD5w-00075p-JN; Sat, 18 Jul 2026 18:01:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wlD5Y-0006MH-Ua; Sat, 18 Jul 2026 18:00:55 -0400 Received: from pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com ([52.42.203.116]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wlD5W-00059H-67; Sat, 18 Jul 2026 18:00:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1784412050; x=1815948050; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qmO8d/rDXj0cALhLa0MQcV3mYO09GhDUo5aekxJsoCQ=; b=Hc2YYu34wLdUPKQmozlnvFOFa3I5YTfgP+yqAqCh+8h6g3G/GPRVzMFu 4bSNYvSmAZ75hK/G99MDcnrd08EB1IX0jEBd/ja24Z2sV0JfI+Luhz7+L Ta54VP7qSLKqLm7fFGAdkvunzE7o0SWUE9H+o6re/QFSwVZ0oDVllVALF W0Msdfe//EYn+CvuUAU55PfI0ey38kmAalwQxlCb0Ft2vCt2ZHW4D9bHr ELVH8AJvQi4Qi9uXEEI1mJcyvNI9zG2kHUDwt+hCYNQnINXFjqBSb1PPr VbUsGJ2L1p4GqobHqqbsWIY8615sDHufGS+/INWcZoyQx3jvYuHgfGwft w==; X-CSE-ConnectionGUID: D9Yy9egZSK+Cg3adSv38EA== X-CSE-MsgGUID: lCOYz2D4RcKdNnn8U3il5Q== X-IronPort-AV: E=Sophos;i="6.25,171,1779148800"; d="scan'208";a="23940282" Received: from ip-10-5-0-115.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.0.115]) by internal-pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2026 22:00:46 +0000 Received: from EX19MTAUWC001.ant.amazon.com [205.251.233.53:12516] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.48.250:2525] with esmtp (Farcaster) id 6ac860b7-bfed-4bc8-848d-9aa050ba6359; Sat, 18 Jul 2026 22:00:46 +0000 (UTC) X-Farcaster-Flow-ID: 6ac860b7-bfed-4bc8-848d-9aa050ba6359 Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWC001.ant.amazon.com (10.250.64.174) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 18 Jul 2026 22:00:46 +0000 Received: from ip-10-253-83-51.amazon.com (172.19.99.218) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 18 Jul 2026 22:00:36 +0000 From: Alexander Graf To: CC: , , , , Song Gao <17746591750@163.com>, Aditya Gupta , Alexey Kardashevskiy , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Farhan Ali , Alistair Francis , "Alistair Francis" , Antony Pavlov , Markus Armbruster , Artyom Tarasenko , BALATON Zoltan , Felipe Balbi , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Christian Borntraeger , Brian Cain , Hendrik Brueckner , Chao Liu , "Huacai Chen" , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Helge Deller , Dorjoy Chowdhury , "Edgar E . Iglesias" , Alexandre Iooss , Eric Farman , Fabiano Rosas , Francisco Iglesias , "Gaurav Sharma" , Gautam Gala , "Harsh Prateek Bora" , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Jan Kiszka , Max Filippov , Joel Stanley , Jared Rossi , Tyrone Ting , Frederic Konrad , Laurent Vivier , "Manos Pitsidianakis" , Bibo Mao , Mark Cave-Ayland , Glenn Miles , Matthew Rosato , Michael Rolnik , "Michael S . Tsirkin" , Niek Linnenbank , Nicholas Piggin , Palmer Dabbelt , Halil Pasic , Paolo Bonzini , Peter Maydell , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Pierrick Bouvier" , Richard Henderson , Sai Pavan Boddu , Samuel Tardieu , Bernhard Beschow , Stafford Horne , Sergio Lopez , "Subbaraya Sundeep" , Thomas Huth , "Ran Wang" , Hao Wu Subject: [RFC PATCH v2 085/137] isa: Remove *_orphan() creator variants Date: Sat, 18 Jul 2026 21:36:00 +0000 Message-ID: <20260718213652.37673-86-graf@amazon.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260718213652.37673-1-graf@amazon.com> References: <20260711223707.42139-1-graf@amazon.com> <20260718213652.37673-1-graf@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [172.19.99.218] X-ClientProxiedBy: EX19D036UWC003.ant.amazon.com (10.13.139.214) To EX19D001UWA001.ant.amazon.com (10.13.138.214) Received-SPF: pass client-ip=52.42.203.116; envelope-from=prvs=65292d44c=graf@amazon.de; helo=pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org All boards create their ISA devices with an explicit QOM parent now. Drop isa_new_orphan(), isa_try_new_orphan() and isa_create_simple_orphan(). Reviewed-by: Philippe Mathieu-Daudé AI-used-for: code (refactoring) Signed-off-by: Alexander Graf --- hw/isa/isa-bus.c | 19 ------------------- include/hw/isa/isa.h | 3 --- 2 files changed, 22 deletions(-) diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c index 7a6a595ce7..22452e5048 100644 --- a/hw/isa/isa-bus.c +++ b/hw/isa/isa-bus.c @@ -172,25 +172,6 @@ ISADevice *isa_create_simple(Object *parent, const char *id, return dev; } -ISADevice *isa_new_orphan(const char *name) -{ - return ISA_DEVICE(qdev_new_orphan(name)); -} - -ISADevice *isa_try_new_orphan(const char *name) -{ - return ISA_DEVICE(qdev_try_new_orphan(name)); -} - -ISADevice *isa_create_simple_orphan(ISABus *bus, const char *name) -{ - ISADevice *dev; - - dev = isa_new_orphan(name); - isa_realize_and_unref(dev, bus, &error_fatal); - return dev; -} - bool isa_realize_and_unref(ISADevice *dev, ISABus *bus, Error **errp) { return qdev_realize_and_unref(&dev->parent_obj, &bus->parent_obj, errp); diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h index 79bfe16361..9bbaa3c258 100644 --- a/include/hw/isa/isa.h +++ b/include/hw/isa/isa.h @@ -86,10 +86,7 @@ ISADevice *isa_new(Object *parent, const char *id, const char *type); ISADevice *isa_try_new(Object *parent, const char *id, const char *type); ISADevice *isa_create_simple(Object *parent, const char *id, ISABus *bus, const char *type); -ISADevice *isa_new_orphan(const char *name); -ISADevice *isa_try_new_orphan(const char *name); bool isa_realize_and_unref(ISADevice *dev, ISABus *bus, Error **errp); -ISADevice *isa_create_simple_orphan(ISABus *bus, const char *name); ISADevice *isa_vga_init(Object *parent, ISABus *bus); -- 2.47.1