From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F82FC4450A for ; Sat, 18 Jul 2026 23:36:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F01A10E36C; Sat, 18 Jul 2026 23:36:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="eHUiRiXF"; dkim-atps=neutral Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by gabe.freedesktop.org (Postfix) with ESMTPS id 61F2F10E36C for ; Sat, 18 Jul 2026 23:36:02 +0000 (UTC) Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4955158f26aso4605665e9.3 for ; Sat, 18 Jul 2026 16:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784417761; x=1785022561; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qVQM0So1MCL7ilj5LYZg6mzfa82XvkJyQz/kOpkAFIY=; b=eHUiRiXFN3/IIHQsLXhi6ZfDp/VfWyJok2eUMUr416SXiE5ewPausSaanbqiZ3IMmF 7adgylXuPr6dSZz8qAHZs2zKICeUJ1JFZNGhBDPG1teqewaksIQHGJ3oOgsTpeyXa849 FNRsA9rNDo53ot2zWifRnist57xdLevU2wHVFMqnXgFrUlzs1eO55/jnplNB2Zj3jJwb RYjYfvMwPyS37y0SMAEqpjjhZH2I9gWJWHQXSy6X+LqPTK5a7YlLTvZfYJwHmQpQp7W7 p0mw7m/sNXf5cP7m3P9WQlyLjufmvhYr7Z2H1ynbU/52L+GWCvb4r55QRu7JAGfAba1/ g6LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784417761; x=1785022561; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qVQM0So1MCL7ilj5LYZg6mzfa82XvkJyQz/kOpkAFIY=; b=iTTybltjXT5NhNiMn4ADcI4c4kC7vSEfOxileSLrQt8DM9r+JIUjSx+bqFumxnGdFz vP+eTGKzyX4zbgZkMkft8o9wDTeGdCOw6cuUMTZtcUQo45n7cAjzNzoqJLtqhDl2Axyk cFHK1oG5noofkRkMkwOGasjemJ9uxPUrsIQnOixPgv8QYguO5PYHrei181Am0mCKn38K NVOMD5LeNzh6XiQwQOO05eoBloMhIfLWmLIwEm2p/0y4Vw+FwRXx0N3nfbF0oPaDwVTK IOSeNXgIfGJ4s1jrYq7n5gKN3SnJ5RGFCs3EkUvitzfMK5KV65LDE9a9cJ//75n2W8C1 8qtA== X-Gm-Message-State: AOJu0Yy4nPlOkVRDO1cvDhIOJ1XXyIRRlHBtpTrvw9Idrm0Ez5nGCENY 3xNl84T7TSBJwl6IcY+GHNNjyM6b5DtY8ji3OuvhUSYFhG2hA4kPaWvp X-Gm-Gg: AfdE7cl3H8VHHM9dq1Cty9ZjT7z3YrS6dCezF1qYfRvU50ZTtuAPKHlCmaxION4N4ug bpC3srW0CcCfkupUFGhN705CjAGJVEWEBObB/uM2AepnYI5VOk7uNyGdM9gZ8gApspJ2+9spZBn qDJnlnRf3b3zyjbWYJM11UrS/ziT/En1rFxA5bXsEZ7AfjpNJJmjRpLB4/Dv1cnZ40NTf/pWUSF 1C8B8ksDElFT7s66ZLvpzOFYSzMN4kDQv0T1IqOtRIEyUK4HYxM8mGpHtpH6SMSN6pHUZxaDhGI TSBsugcWEmwd1z4G516TzcpjD1oaWtRDqdHyhg0Q0uY20oOqY8G4oJ44pNceudXhOJdplt8IH5k oNssX4mspeqvzQt7JilbOzVqw02xhnFu4dXsojcy9+CI1bBMa/QcnOsyadY7FqkSGe/9L5HEILs gVM7rpB+DlKA== X-Received: by 2002:a05:600c:4e94:b0:495:571e:e5d3 with SMTP id 5b1f17b1804b1-495571ee75fmr14134205e9.36.1784417760679; Sat, 18 Jul 2026 16:36:00 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:645b:9e5c:7fe3:c09f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2a24b6sm160964675e9.3.2026.07.18.16.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 16:36:00 -0700 (PDT) From: Diogo Silva Date: Sun, 19 Jul 2026 01:35:32 +0200 Subject: [PATCH 01/15] drm/exynos: remove dependency on DRM simple helpers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260719-drm_simple_encoder_init-v1-1-a78c509e3062@gmail.com> References: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> In-Reply-To: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Also check the return value from drm_encoder_init() to avoid silent failures. Signed-off-by: Diogo Silva --- drivers/gpu/drm/exynos/exynos_dp.c | 13 +++++++++++-- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 14 ++++++++++++-- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 11 +++++++++-- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 14 ++++++++++++-- drivers/gpu/drm/exynos/exynos_hdmi.c | 15 +++++++++++++-- 5 files changed, 57 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c index b80540328150..1598892c602b 100644 --- a/drivers/gpu/drm/exynos/exynos_dp.c +++ b/drivers/gpu/drm/exynos/exynos_dp.c @@ -24,11 +24,11 @@ #include #include #include +#include #include #include #include #include -#include #include #include "exynos_drm_crtc.h" @@ -79,6 +79,10 @@ static void exynos_dp_nop(struct drm_encoder *encoder) /* do nothing */ } +static const struct drm_encoder_funcs exynos_dp_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs exynos_dp_encoder_helper_funcs = { .mode_set = exynos_dp_mode_set, .enable = exynos_dp_nop, @@ -95,7 +99,12 @@ static int exynos_dp_bind(struct device *dev, struct device *master, void *data) dp->drm_dev = drm_dev; - drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_TMDS); + ret = drm_encoder_init(drm_dev, encoder, &exynos_dp_encoder_funcs, + DRM_MODE_ENCODER_TMDS, NULL); + if (ret) { + dev_err(dp->dev, "Failed to initialize encoder\n"); + return ret; + } drm_encoder_helper_add(encoder, &exynos_dp_encoder_helper_funcs); diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c index 0dc36df6ada3..4e42a1da81d1 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c @@ -12,10 +12,10 @@ #include #include +#include #include #include #include -#include #include