From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BFEDC4450A for ; Sat, 18 Jul 2026 23:36:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1AEED10E612; Sat, 18 Jul 2026 23:36:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Lfg87Mg8"; dkim-atps=neutral Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB17310E628 for ; Sat, 18 Jul 2026 23:36:37 +0000 (UTC) Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-49547fc63a0so7752435e9.2 for ; Sat, 18 Jul 2026 16:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784417796; x=1785022596; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UCTzuFV7eFCGxIzO9ORcmzHtSM3Ggk/jrKBR0xDgYaA=; b=Lfg87Mg8ZyfUmDiZ765yGLtDfXE70Qzvf65K8g4vKU4wto0GtjFg18j497rvmh66qm WDWI6PduS04JQ2sKfBYCZQQFO6bPWxbv+VKcfSn0mLR9N72+rkbHmD9Ss7HVTcKlA6Tc C0KTY+47n1p3bbyC5mgnQBnJbCeTxgmOESuEjeUGvMUGiaOJwn9MMyeyT99XXNBmzCpW EdjGeCEEBTm7u7VJrlrZUJTwZgApmmo1wubWhHAx9+3RlOZuQm9/0wBrv+K9fUPqVZKl 6zz7Gv55n9cf4TpZx0TVS5gtn8TfxYeUMB/L3dr7c5IYgch0k4adiDvkEYcMVhZ6Knp3 ImFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784417796; x=1785022596; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UCTzuFV7eFCGxIzO9ORcmzHtSM3Ggk/jrKBR0xDgYaA=; b=ldjKbP3zx+JmBvUQ89L/49viAArtOb36+WncP9GFbq3v0ljKUGCNP/heAb3qJWvoAT ghXU2Rp1w36hA1RUWz2PAPdnWHqC2Dnk9LaqUm7ey69nQHc32YB4CjVkFOgf0r3ilhve a2S4bi+nBU9ku8Em38J4j5qHKlGvZDRHsU5U/fy3LbeSL9BuZt0tzDaDimkO0h9LxDI+ PrtQpy/4gp/yLCCeZJaZC7+Ql1t+KJUl+5lzrJwX+EWMSaVuzE2WOZ2gVjczWZPkLLR5 v//Q2t7UexFbkz2Zoir491RvGLhOMRlUM0wSmKJahO6qbJFZJyjWWfzC7PR2lB2zgDsc apOw== X-Gm-Message-State: AOJu0Yzd3VwemAtTcuj+3GgKO8E0tU4a2q9JNPd9Zac+LVs8L05tS4MM PyA0vOMd+OQF2UvTN5RTMk/BChTyC+RLT0Gz4o1wsR8UmhOLYvN6bOta X-Gm-Gg: AfdE7ck9toBWXxBj+yWkrBhhPP2+k4PO7+ovqeJ7r/KGNs5QIYFUAKzUiI0UaC7ae25 PI67XClxbPfANRhRkQio8Fg7xNyu7/uZEUTjWbbIijmLH29lycAnLfgMohbXFo32bR1pwj5NcWc /B1s4XgSYADug1m4dxefXhFpCnDC5ZOJtpJwj1FaqO2sO2Ve3EPsbn7cjPtAZevwE3Hf7weKJGB OspXwDSuIfsZ6G3nyeGiq2Oh0nu/jqqw189MZjeQWt+dOQhQwhv4noqBr0Ea4AIfp29dAZEV51F lO/nMSVzT1d/HBTVdl/vuU3eIGcz53jc+P+I3vr8P2/MOgkgU+QUFns4JK7lqiw6P7GTwr2Bnze BcA9EZmnXuqOvsmNW6L8O+prd6lu1vrp68QwRjU4v/Ipoq9ZgMcJ8Kx4WWG/VRrw86O+zUDJftF XmG7a0iNJSJQ== X-Received: by 2002:a05:600c:3b91:b0:495:4c62:9d43 with SMTP id 5b1f17b1804b1-4954c629e5emr98503215e9.34.1784417796224; Sat, 18 Jul 2026 16:36:36 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:645b:9e5c:7fe3:c09f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2a24b6sm160964675e9.3.2026.07.18.16.36.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 16:36:35 -0700 (PDT) From: Diogo Silva Date: Sun, 19 Jul 2026 01:35:42 +0200 Subject: [PATCH 11/15] drm/hisilicon/kirin: remove dependency on DRM simple helpers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260719-drm_simple_encoder_init-v1-11-a78c509e3062@gmail.com> References: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> In-Reply-To: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Signed-off-by: Diogo Silva --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c index 15042365dec0..62c5bd3277da 100644 --- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c @@ -20,11 +20,11 @@ #include #include #include +#include #include #include #include #include -#include #include "dw_dsi_reg.h" @@ -687,6 +687,10 @@ static int dsi_encoder_atomic_check(struct drm_encoder *encoder, return 0; } +static const struct drm_encoder_funcs dw_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs dw_encoder_helper_funcs = { .atomic_check = dsi_encoder_atomic_check, .mode_valid = dsi_encoder_mode_valid, @@ -708,7 +712,8 @@ static int dw_drm_encoder_init(struct device *dev, } encoder->possible_crtcs = crtc_mask; - ret = drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_DSI); + ret = drm_encoder_init(drm_dev, encoder, &dw_encoder_funcs, + DRM_MODE_ENCODER_DSI, NULL); if (ret) { DRM_ERROR("failed to init dsi encoder\n"); return ret; -- 2.54.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48A98C44525 for ; Sat, 18 Jul 2026 23:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+iE88nFKDF6cvvKUg7jDUUY9gkpeCQnX+eufapiNOw8=; b=yzRewwk2NJvm7P AwiDNUxpMzwAJ7B0JMgcsdIZWM7HxzBQdvaP9E80QqXhRrHTtVEdOhW7iYWYEAfrY4RfttOVkiNgl c2EJua7/Y9+IwuXVxa++sO3cVG4tCMcPTkk+9F6EZbMWY2p34x9VUvBQKDcUNL8tiF4j5IlkpW1Tk usYdpVy2U/kGYUYXo4u25XBYOpGka1QXW6cd+PdKLXVNM/PyTks1WSnkLL4TAcSSfdbRPtMasDqT4 4ICVaaeStvw8CfZXkjfP/+y/rl/A0dvtdI82ZK43Rbd5cebMCIwcTtxUghEZ9Gg+4WRLUq00oliSF oB2ZthTGBYdD/XwMtXGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlEaH-00000004cGv-0f9G; Sat, 18 Jul 2026 23:36:41 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlEaE-00000004cBn-0YmL for linux-amlogic@lists.infradead.org; Sat, 18 Jul 2026 23:36:39 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4954a32cf1eso6889385e9.3 for ; Sat, 18 Jul 2026 16:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784417796; x=1785022596; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UCTzuFV7eFCGxIzO9ORcmzHtSM3Ggk/jrKBR0xDgYaA=; b=lSsyZOfe7NiC2Mc40EcaW1wzWmtipGbsPJvPkre6sY3bJdHiVY4FvzqqLIWy5fL/0I jC1aoHDoPlqZvdMgXDQbZIRv/DhaZUuJWxhKy04i5FmR+v21v2JliwRiYfsOTs1zQC7/ J3zZAQwq4vsO7TY8O6qR46F91RgFAlNEU/krgIn0JU/UgfOPmyfnW66s7AUnfNfWgNc8 EY2ghzG0yjHk8jy0y/DLrwl/JYgOvDjEup1ZLoV/gonyXh5xj899MeYJrFzQ7RU+oFpk DtFRik4YkaqT69zZX29BMiqMB9vvr2rQ+vfb7igX2LCwjF9SWiLjHKyHKXMgoBRMR5my ZVQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784417796; x=1785022596; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UCTzuFV7eFCGxIzO9ORcmzHtSM3Ggk/jrKBR0xDgYaA=; b=pSa0dTALuhxHqp/9UPz/zvNym1ChOqdhC8GJemu1Cnwy/C8s9bdI8JSmK9gKbequ5D mlfndbCQE6MWloe0usnyfXQ7CuY/wSx+X2u1EowIlBxVgKwYqNubjejTAimreYCYdwKZ 1QgWZIBBFQf4c1ljzJed3JArvoqnGOiI+rJZKURwZi/HWJ0wN2i1iL0RZPkKjvn6fiT6 WhZMSf3YVNiBszGVcRYABV7BPSlrsSk6J/0vAdySoo3MJYaMACq8iOXSdFHs+cBDAh5D YdhD+TS6ZtwgWVjrGdTZCTV2h1KqsCDHRf98m/ZB6pDrTcNJU+M05rd30oaN5+NPYMAh 5oXA== X-Forwarded-Encrypted: i=1; AHgh+RpyOSN0rnPvx3YXQ8wZKbmKzTPUDACKnul8/uKXpZ+oGLTRj5q778P6SmsBf5TXv2u1WsNAwAHHviRZ3j6m@lists.infradead.org X-Gm-Message-State: AOJu0Yw6v9uBIEszgv59TftZEuVN3UYBfbh9jqiJBA6XmrILb2rWKR6F V+6HRs1YifZhQqvIYZWkDQITZ283Z8lKux2ANc7/tsLApqiFjcgm60dj X-Gm-Gg: AfdE7cnNBMIUQV4uxFryGiuq/rW2gFtPvFY7S8MBl/SAOnLBRv16heFrjsIgvY9qQuM AEeBNMfi71fnDlpDBWJft7mPHiHeU4h6YqhWb3KipclpavNTeIQHNqo3h8zeNs6hHyR3ni2SAsP bPwRSFSHjhDbRnzVK0RqM/2tRBap7xrEULtpMkSxcvb5KGsjxUw8aTaBVNxJ8g4HxmvQQHJRfBv HXHKksTp+rBc3RQwCt2vBzHaO2byn0v66L20/Pt+vhFwzu2xeQ+PqpnOdYgc4B9qJzAwSCHpbh+ 2oK9HhblD1PemF06G+cwauXdOvSj+gOxnNlvj2UYaEWSRKv19jbZ4sjdF2yhnbbSLNT7f+KTHUN pL3Z5ouFFRI9NSyjN9swmF94XJ5ELvp0X39Vg8fcpFoMO33VvNH0wRLOe0KkQiAumDru5ApCgyu ZI2nEtC7ALIw== X-Received: by 2002:a05:600c:3b91:b0:495:4c62:9d43 with SMTP id 5b1f17b1804b1-4954c629e5emr98503215e9.34.1784417796224; Sat, 18 Jul 2026 16:36:36 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:645b:9e5c:7fe3:c09f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2a24b6sm160964675e9.3.2026.07.18.16.36.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 16:36:35 -0700 (PDT) From: Diogo Silva Date: Sun, 19 Jul 2026 01:35:42 +0200 Subject: [PATCH 11/15] drm/hisilicon/kirin: remove dependency on DRM simple helpers MIME-Version: 1.0 Message-Id: <20260719-drm_simple_encoder_init-v1-11-a78c509e3062@gmail.com> References: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> In-Reply-To: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260718_163638_256537_1CFB0440 X-CRM114-Status: GOOD ( 11.91 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Signed-off-by: Diogo Silva --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c index 15042365dec0..62c5bd3277da 100644 --- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c @@ -20,11 +20,11 @@ #include #include #include +#include #include #include #include #include -#include #include "dw_dsi_reg.h" @@ -687,6 +687,10 @@ static int dsi_encoder_atomic_check(struct drm_encoder *encoder, return 0; } +static const struct drm_encoder_funcs dw_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs dw_encoder_helper_funcs = { .atomic_check = dsi_encoder_atomic_check, .mode_valid = dsi_encoder_mode_valid, @@ -708,7 +712,8 @@ static int dw_drm_encoder_init(struct device *dev, } encoder->possible_crtcs = crtc_mask; - ret = drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_DSI); + ret = drm_encoder_init(drm_dev, encoder, &dw_encoder_funcs, + DRM_MODE_ENCODER_DSI, NULL); if (ret) { DRM_ERROR("failed to init dsi encoder\n"); return ret; -- 2.54.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic