From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14D5CC4450A for ; Sat, 18 Jul 2026 23:36:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6235210E374; Sat, 18 Jul 2026 23:36:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="eAXk0GhU"; dkim-atps=neutral Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id DDB4D10E374 for ; Sat, 18 Jul 2026 23:36:20 +0000 (UTC) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4953ddae026so28559825e9.3 for ; Sat, 18 Jul 2026 16:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784417779; x=1785022579; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/m2It/8MnIxoX8xbOWjx4p2UhJgFTMfhBAqsULip3yI=; b=eAXk0GhUnOaSVe6TSZP3W+cDIR1TabdzsT2HT8mzFxIuNVVidSi7c2+3D5q57yVVki jiVdM43OsVwnwfiPXqLGjLkHzUNV/QsqVYGNGbssq01zvSt+lBTARIob8WXQ8IPT9KDS +28VKhCxQ4X10AuHNd5zHg8/qmUSeGLRHJb85BvvH+9iWjT36MC3zPlRweUxxQJOvIlG OskOBDYC+IEGgjb9iR9zy1+TBPXOFkW8wiWepaAVNeiXPyhptAE2eFZ9sYRXGK5i7JjU yQFPmgl6qamzFc40EqOaMH/C7qshtuXb44CP94U8/0sUNhuNzYbsg8YQrT5hAuoVAase XGIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784417779; x=1785022579; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/m2It/8MnIxoX8xbOWjx4p2UhJgFTMfhBAqsULip3yI=; b=B9wMuqctMbpbbPLuKQGC8ylEpg/9AK/CNE8Tx4M76HWVRQ29h021MFPsDxuf5uqufG yR8Dl5RMxm4z3nSCo2rVcjyUvPlmLfCPiNlhXfzhZWBQmWuUkmf26BPgQnWVqXHSrwFq IoZJ/NjrWzsGCdplyS+OMksIAasdy+t7L6P/Y9P8x55KmWz1IrX4GZDX+qOBo7rIGQqK baGqeN5iudf+XCRGOVc6aIRFJ+VKiKzz1xqlzKanQqbLguuJAe1NtU//QbWeecv7vO4L Ja00gFMw2XV9F5tNG+vbff1O2U2UWurscnGat4stEWuZxaSXRO4SvfHqvw5h9RlBZAEX eylg== X-Gm-Message-State: AOJu0YyZ8225xiLDkwfjdxBN+7ACLYzzThBzQZycBgyVWA3vKiqJZIEF o3sAa2nIqnBJGxh/81TFhbT3LuGBEpPSB0PmQt7Uajmx4TNdr+Yuvp29 X-Gm-Gg: AfdE7cmyKJ7OyUyIns8cuKY5RjhgWvkgPeanHcHgp3r2oTYkYUS+36OmtNqyQWuqCfT ALsIy28eHYiOQtkLdgW5H3/VXBDYcCbue774xrBEdu03oQ7DN9o1h+m/zBI4UoD38rsMV/w5/gE OQqUp9nqKvbZVjGOX0LaBojhJG+YM6GRn6GESPVM2qCAts85w+5hcFVlROj9i0D03KY6pPjK7Xq CAE3YnJHdz375wUJyg/V4WBR+kyvGRngJ8cxrN+g9G6mR6vAY4j6S/D+HUH6Y7wB/55ijyboqqs kmzyDzrgYM8WSU37/cvzL3KjYeFR5PM9X/IpyvYON1oq8nOKgLAxemrp+14joxiODhHDp/gZmxg MukS7o5YYEktgKDAJFTI4NwcDWJPf/3FAufSwN9c5VcLS2pCwx/MW23I/EjvTpER0ekgmFWS1Mw ISvTsryD/tP5P9OTCqeYuN X-Received: by 2002:a7b:ca50:0:b0:495:3fe1:4ce4 with SMTP id 5b1f17b1804b1-4954a40c110mr70449165e9.26.1784417779234; Sat, 18 Jul 2026 16:36:19 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:645b:9e5c:7fe3:c09f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2a24b6sm160964675e9.3.2026.07.18.16.36.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 16:36:18 -0700 (PDT) From: Diogo Silva Date: Sun, 19 Jul 2026 01:35:37 +0200 Subject: [PATCH 06/15] drm/virtio: remove dependency on DRM simple helpers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260719-drm_simple_encoder_init-v1-6-a78c509e3062@gmail.com> References: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> In-Reply-To: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Also check the return value from drm_encoder_init() to avoid silent failures. Signed-off-by: Diogo Silva --- drivers/gpu/drm/virtio/virtgpu_display.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index 44ffffec550f..67023d91d40b 100644 --- a/drivers/gpu/drm/virtio/virtgpu_display.c +++ b/drivers/gpu/drm/virtio/virtgpu_display.c @@ -28,11 +28,11 @@ #include #include #include +#include #include #include #include #include -#include #include #include @@ -232,6 +232,10 @@ static enum drm_mode_status virtio_gpu_conn_mode_valid(struct drm_connector *con return MODE_BAD; } +static const struct drm_encoder_funcs virtio_gpu_enc_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs virtio_gpu_enc_helper_funcs = { .mode_set = virtio_gpu_enc_mode_set, .enable = virtio_gpu_enc_enable, @@ -306,7 +310,11 @@ static int vgdev_output_init(struct virtio_gpu_device *vgdev, int index) if (vgdev->has_edid) drm_connector_attach_edid_property(connector); - drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_VIRTUAL); + ret = drm_encoder_init(dev, encoder, &virtio_gpu_enc_funcs, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (ret) + return ret; + drm_encoder_helper_add(encoder, &virtio_gpu_enc_helper_funcs); encoder->possible_crtcs = 1 << index; -- 2.54.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70C53C4450A for ; Sat, 18 Jul 2026 23:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sGOMte3bRLStp+BwLxJrlR2ZjK34PAt9AOANy6YWgfI=; b=hHA8btJeepcO1Y 5jwBjLT0g33NNR49zgRCTGAWkiHDENKZquM0llz1FhhInp9ajMFsyhF4p7vlaw1pfNfzlr9IGlzgL MytpSvYBDGKJ0RnebWoALMFQy1QA5wQp6GaoD/9m2LzjZ5FsJcC/iplf1DREhPSiOnpQNpjruNvoO MZJVQh7E2HmqbteMrHjx4YVkG1V02plnGIYN6EPTvQLT7sjJxskUeQ2dwYlAwqhNJQ3MAa47217Sm 1lvHT/oTzOCVihWtBEZ3RZ+BaOPIpp6/ZXk/ZvbYvXF3hEBhh/zfMX9QG8DAdIHD5GPpnCt50tM+r kRRsn1xIXnpts3cpjIPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlEa0-00000004bvk-1OIz; Sat, 18 Jul 2026 23:36:24 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlEZw-00000004brO-3gZ7 for linux-amlogic@lists.infradead.org; Sat, 18 Jul 2026 23:36:22 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4953ddae026so28559805e9.3 for ; Sat, 18 Jul 2026 16:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784417779; x=1785022579; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/m2It/8MnIxoX8xbOWjx4p2UhJgFTMfhBAqsULip3yI=; b=GZkQZyrJlB8YHZbZJE7hhHbAN4e3qhvy5VR1bDb026dNPFKqekEkFLvQkKwsO+6aom mL65owsfi8K6s4P61+LRUFk7VzH4i9rY2t7WW110yGXWz1jNMOqx9nZekUYWdCF929sX Gl6PWDMS0PbUVuYTuRgEZ4hkS2bzmCmZAkqZXKbV7VZTruigZyemYXXjrHb8kPxl7P1x OXLJpaBNAsT0HwVkgCphF68YaK0M7TakON5BYGreit2/2liugE2JpNrsT7Hjt+KmPrsU fnJU0qTwpDIH4JNeofvEAze5rAo7EU37Ow1TYKvrxv+X6oo5rzjMfm+XlI8J3y1sTnAI SrwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784417779; x=1785022579; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/m2It/8MnIxoX8xbOWjx4p2UhJgFTMfhBAqsULip3yI=; b=qwksYlqhSaOmRuRF2QpbE3imoaHmF1oCVFZ2WQqaW5V63b9ssUxQnsAkuBONb8Gp6r IWjbW217wA8rKoXAcZJkzvtNdI1H2WpCxAwHucdsP4vdkJB35bz/gALpeH/yU8kOa4O8 sxAvRekc+YohjYwzwryN+ZfMzRhbMvfWC0lZrfReloeI2bfsSit0eEZCYaLfBTndn6b8 XWhVu8/4ZeweyMy2bQLYqk0Nt74uZ4Std8fVFuhtJsH+GEKOE/g3ph4CVkIgwX0TlFkA fl0y34xIMRqE2Xw0F68BMb0r91OGwwT6XItCpaPzAiZiUnZvRtNsf9Hp7uKPlwIQg3SN 3HkA== X-Forwarded-Encrypted: i=1; AHgh+RoZI984CJj2Hieok01GN70z4K9kyHVx/Y3DSDmWTNuyNi4NbWLNoJHjU9YLYqmh5Oit7v2jfP4IFHuiYFkj@lists.infradead.org X-Gm-Message-State: AOJu0YyrQQgy4n8tzU9GS0WA0jrXY4fP8zTLdRsun3M306UAVUTWWe5D csrgV4DzSG5BHcLfn0P96tyRi29LUTmNMNFjCQDnLNT9ZNv1uN1UeGY0 X-Gm-Gg: AfdE7cn8pj2u/UaREAHYDpiFceO5ybUf3ylB63B2g9AO1yU5BhyyIup7R1LQYsvtoQK sq9jveFMDzGX1o9WUC+j7pZTar7VDHgD9xIOcbNJrnpt4x4XEgeLc//cjEa+8DVbhczahY+Maqe KI/xJPHEZmuM6/aS6LjtEL6DUwYQWIfjNmQsfJB+P2eVf/cEmEPd8AZ2efqvCfWfqsXDE2uqfjk 3RrBflkveVZgCb5GGINWt4j/9x8ddZ+naHgAFW1Sf/O0Hrt4AmWkIefWp/SyDd81VrDD8069lel piUsQmpari6sphG3DjT8bivbCB8LlslBSqSjln/XYTHaJ0H6V2ghsdMNEqzyDjbS/Wae/dUmKKA 0QMGopnm3ZeETRSCQeumGgGLTPmTwA4uzOzqsZaVFm7nCXDS+nAkxzlP8JY/36rZ8ytJu0NdsCV s81FNALaSZ6a2/yukKiDYu X-Received: by 2002:a7b:ca50:0:b0:495:3fe1:4ce4 with SMTP id 5b1f17b1804b1-4954a40c110mr70449165e9.26.1784417779234; Sat, 18 Jul 2026 16:36:19 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:645b:9e5c:7fe3:c09f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2a24b6sm160964675e9.3.2026.07.18.16.36.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 16:36:18 -0700 (PDT) From: Diogo Silva Date: Sun, 19 Jul 2026 01:35:37 +0200 Subject: [PATCH 06/15] drm/virtio: remove dependency on DRM simple helpers MIME-Version: 1.0 Message-Id: <20260719-drm_simple_encoder_init-v1-6-a78c509e3062@gmail.com> References: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> In-Reply-To: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260718_163620_992332_1E62073F X-CRM114-Status: GOOD ( 12.64 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Also check the return value from drm_encoder_init() to avoid silent failures. Signed-off-by: Diogo Silva --- drivers/gpu/drm/virtio/virtgpu_display.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index 44ffffec550f..67023d91d40b 100644 --- a/drivers/gpu/drm/virtio/virtgpu_display.c +++ b/drivers/gpu/drm/virtio/virtgpu_display.c @@ -28,11 +28,11 @@ #include #include #include +#include #include #include #include #include -#include #include #include @@ -232,6 +232,10 @@ static enum drm_mode_status virtio_gpu_conn_mode_valid(struct drm_connector *con return MODE_BAD; } +static const struct drm_encoder_funcs virtio_gpu_enc_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs virtio_gpu_enc_helper_funcs = { .mode_set = virtio_gpu_enc_mode_set, .enable = virtio_gpu_enc_enable, @@ -306,7 +310,11 @@ static int vgdev_output_init(struct virtio_gpu_device *vgdev, int index) if (vgdev->has_edid) drm_connector_attach_edid_property(connector); - drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_VIRTUAL); + ret = drm_encoder_init(dev, encoder, &virtio_gpu_enc_funcs, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (ret) + return ret; + drm_encoder_helper_add(encoder, &virtio_gpu_enc_helper_funcs); encoder->possible_crtcs = 1 << index; -- 2.54.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic