Re: [PATCH 2/2] thunderbolt: Add device links for Apple T2 NHI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The boolean variable `ret` is returned uninitialized when `has_t2_chip` is true and no device links are successfully created.
--

--- Patch [2]: [PATCH 2/2] thunderbolt: Add device links for Apple T2 NHI ---
Note: The format of this report has been altered to provide a free-form summary
of the findings rather than inline diff quoting, due to recitation restrictions
on the original patch code.

commit 02f82ba0cab274de03252dcd3722c98f27a73abf
Author: Andre Eikmeyer <andre@negmaster.com>
thunderbolt: Add device links for Apple T2 NHI

This commit adds support for Thunderbolt NHI on T2 Macs by searching for root
ports in ACPI named TRP0, TRP1, etc. It creates device links back to the NHI
so that PCIe tunnels can be re-established after sleep.

[Severity: High]
Could this return an uninitialized value?

In tb_apple_add_links(), the boolean variable ret is declared without an
initial value. If the system has a T2 chip, the code enters a nested loop
searching for PCIe root ports to link. If no root ports match the required
ACPI prefix, or if device link creation fails for all found ports, the loops
complete and the function returns ret without ever having assigned it.

If the uninitialized stack value evaluates to true, might this cause the
caller to incorrectly assume device links were successfully established,
potentially skipping necessary fallback paths like tb_acpi_add_links?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260719180308.1398-1-atharvatiwarilinuxdev@gmail.com?part=2