From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ED9A1ADFE4 for ; Sun, 19 Jul 2026 05:24:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784438651; cv=none; b=tMgzyXbmEKFUpvPcFOuPlZbuLs8nQNsHsjYXIMDUzl1tFfLfug5sSVo1bZ+t32RkPmxmO+o+x0MQ83Sr/+r4e/0leFgZz9YpUht7TCSr9InlzrIzO+XMERhoAa/nQEfUzop+hQnhREe3zZ20JxRY+am939ieirgTdNwmx7aDcjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784438651; c=relaxed/simple; bh=YQINm/hL5Pv54QGTQ3nDUrj/PzPVwZCjLBFQqUQCFr0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kszJXsTBKrXaydAA/ZJWPmQCOH6W+08aoCoIyEmKT8tKDGEwaGmEvLwDU6wTIe83D4d/i+b3yMdadBEAgnZRWwArhdulMJectrHMg5oIwj33fzGf4YvGh74wJRrSrbJEKxdroeA1HmiWqMiTIdxiwyAWvRzaRZLX/3DhiZjyRsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=quqpTFN5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="quqpTFN5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85E551F000E9; Sun, 19 Jul 2026 05:24:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784438650; bh=LyhqfgXrPH6boL4wQUGh4q510FblANQqedDujnNThMA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=quqpTFN5XTFqzE1HNZvxGrI1FcZnZjdB7igURs52zKdskxW1Re+fsifHNMO7v6rmW 8G+lbAc+6Vpb40wa4zILxO4rnsR6x44tevF+xgeBEoHacEsNG/ohxhLdwm5PFI6oy6 yFF9a4xd7j23TxW89gi7HJo7Ud7YmH2M36OmCF+M= Date: Sun, 19 Jul 2026 07:24:01 +0200 From: Greg KH To: kadu04t Cc: luis.augenstein@tngtech.com, maximilian.huber@tngtech.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scripts/sbom: catch ValueError from malformed shell quoting Message-ID: <2026071939-fiber-colonize-dc8d@gregkh> References: <20260718184457.1861-1-otakurack@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260718184457.1861-1-otakurack@gmail.com> On Sat, Jul 18, 2026 at 03:44:57PM -0300, kadu04t wrote: > parse_inputs_from_commands() only caught CmdParsingError and IndexError > when dispatching to command parsers, but several parsers call > shlex.split() internally, which raises ValueError on malformed shell > quoting (e.g. an unterminated quote). This exception was not caught, > so a single malformed build command would abort SBOM generation > entirely, even with fail_on_unknown_build_command=False, defeating the > purpose of tolerant mode. > > Catch ValueError alongside CmdParsingError and IndexError so such > commands are logged as a warning/error and skipped instead of aborting > the whole run. > > Add tests covering a malformed quoting command and a command missing a > required positional argument. > > Signed-off-by: kadu04t Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - It looks like you did not use your "real" name for the patch on either the Signed-off-by: line, or the From: line (both of which have to match). Please read the kernel file, Documentation/process/submitting-patches.rst for how to do this correctly. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot