From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72699C44512 for ; Mon, 20 Jul 2026 01:20:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CL5aC7j9kOl/jrcV2reHCJSM/bJlgXel97CMiOFpM04=; b=3FfRBbx/inuGNO SoBkv0oJdoPgv6VFbVuEH9rPyw18QJWiM4u7ZUmVH/jKNeYjrqTpOdeoGsKH4bFOvB26tYmFLnNJi qyiEQW513yBbclo1ddg4EmnfjH7V9Dw+gE9mo+vhELjBwVUmw1+kEZJnaIwTJY6DieLVNPWV5be5F 9G+QZL8JTDNIeUX3DEwjyri2XCLvEAJNtnT580LPixqZDSOEjApUKyjbnueVDW04bCIsLCgFRuD9J 3yMZXEHnuf5odJSrHeog4JafofvX246H7x73qC2ffqxcq8k++78v25pbd8vg85o4GKKFMfZQK0Lei oa4XquK56alWju+saHng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlcgO-00000005abp-0SFH; Mon, 20 Jul 2026 01:20:36 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlcgM-00000005abf-2Lgz for linux-phy@lists.infradead.org; Mon, 20 Jul 2026 01:20:35 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 090CA429DF; Mon, 20 Jul 2026 01:20:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68C3F1F000E9; Mon, 20 Jul 2026 01:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784510432; bh=2PLb8I13jer0vsrN/Qv6Kj67tynSbToxe6erdn09OCs=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=eSfUPHl+KfxSnth1p3GxD9iC4WTOl7Xnhml9k2kLxjUUK94discBitMmLcPiO+Gbz 7jxjvkl9HfnFqpIxj2wGS/xxq0JxMhmvPNvglRopnxPqxear6pCxr9hY4LGnkqIWKK 3+hLGumQnRHpa01sjHwNLlwGrwm3G0eKW4qrpXe3hETztvEKUO6UpNdYaS7YlKG4Sf uBmaYqhweYIn1sevS5DtmmPk3pCDbzQA7kqnYfODCTvo83sWqO3UHN1jVQQ5S1jR5O 7DxY4YJjbOrc+aBMS5JU+w9zHSNXpEYjvZjfL0nWuki0o0GQZ77NysqelEqrBo+pRW vy4UeVWaZmAPA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v13 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema To: =?utf-8?b?QnJ5YW4gTydEb25vZ2h1ZQ==?= Cc: olteanv@gmail.com, neil.armstrong@linaro.org, vkoul@kernel.org, media-ci@linuxtv.org, linux-phy@lists.infradead.org, conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org In-Reply-To: <20260720-x1e-csi2-phy-v13-1-160c31958863@linaro.org> References: <20260720-x1e-csi2-phy-v13-0-160c31958863@linaro.org> <20260720-x1e-csi2-phy-v13-1-160c31958863@linaro.org> Date: Mon, 20 Jul 2026 01:20:32 +0000 Message-Id: <20260720012032.68C3F1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gVGhlIG5ld2x5IGFk ZGVkIHN0YW5kYWxvbmUgYHFjb20seDFlODAxMDAtY3NpMi1waHlgIGJpbmRpbmcgY2xhaW1zIGhh cmR3YXJlIHJlc291cmNlcyBhbmQgY2hhbmdlcyB0aGUgT0YgZ3JhcGggdG9wb2xvZ3kgd2l0aG91 dCBtYXRjaGluZyB1cGRhdGVzIHRvIHRoZSBleGlzdGluZyBgcWNvbSx4MWU4MDEwMC1jYW1zcy55 YW1sYCBzY2hlbWEuCi0gW01lZGl1bV0gVGhlIGBwYXR0ZXJuUHJvcGVydGllc2AgZm9yIGBwb3J0 QDBgIGFsbG93cyBhcmJpdHJhcnkgZW5kcG9pbnQgbm9kZXMsIGJ5cGFzc2luZyB0aGUgc3BsaXQt bW9kZSBkYXRhLWxhbmUgY29uc3RyYWludHMuCi0tCgotLS0gUGF0Y2ggWzFdOiBbUEFUQ0ggdjEz IDEvMl0gZHQtYmluZGluZ3M6IHBoeTogcWNvbTogQWRkIENTSTIgQy1QSFkvRFBIWSBzY2hlbWEg LS0tCmNvbW1pdCAyMWUwYzJlYWM4MWY4YTA4MjJhNDAxZGFkNzNiMWJlMWIyYjM4YjVlCkF1dGhv cjogQnJ5YW4gTydEb25vZ2h1ZSA8YnJ5YW4ub2Rvbm9naHVlQGxpbmFyby5vcmc+CgpkdC1iaW5k aW5nczogcGh5OiBxY29tOiBBZGQgQ1NJMiBDLVBIWS9EUEhZIHNjaGVtYQoKVGhpcyBjb21taXQg YWRkcyBhIG5ldyBiYXNlIHNjaGVtYSBmb3IgdGhlIE1JUEkgQ1NJMiBQSFlzIG9uIFF1YWxjb21t ClNvQ3MsIHN1cHBvcnRpbmcgRFBIWSBtb2RlcyAod2l0aCBDUEhZIGxlZnQgZm9yIGZ1dHVyZSB3 b3JrKS4gSXQgaW5jbHVkZXMKc3VwcG9ydCBmb3IgYSBzcGxpdC1tb2RlIHdoZXJlIHR3byBzZW5z b3JzIGNhbiBiZSBjb25uZWN0ZWQgdG8gb25lIFBIWS4KCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50 YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9waHkvcWNvbSx4MWU4MDEwMC1jc2kyLXBoeS55YW1s IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BoeS9xY29tLHgxZTgwMTAwLWNz aTItcGh5LnlhbWwKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAwMDAwMDAu Ljg4MGZlNjAyOTQ1Y2IKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL3BoeS9xY29tLHgxZTgwMTAwLWNzaTItcGh5LnlhbWwKPiBAQCAtMCww ICsxLDE5NSBAQAoKWyAuLi4gXQoKPiArcHJvcGVydGllczoKPiArICBjb21wYXRpYmxlOgo+ICsg ICAgY29uc3Q6IHFjb20seDFlODAxMDAtY3NpMi1waHkKPiArCj4gKyAgcmVnOgo+ICsgICAgbWF4 SXRlbXM6IDEKCltTZXZlcml0eTogTWVkaXVtXQpEb2VzIHRoaXMgbmV3IHJlZyBkZWZpbml0aW9u IG92ZXJsYXAgd2l0aCB0aGUgYmFzZSBhZGRyZXNzZXMgYWxyZWFkeQpjbGFpbWVkIGJ5IHFjb20s eDFlODAxMDAtY2Ftc3MueWFtbD8KCklmIGEgZGV2aWNlIHRyZWUgaW1wbGVtZW50cyB0aGlzIG5l dyBiaW5kaW5nIGFsb25nc2lkZSB0aGUgZXhpc3RpbmcgQ0FNU1MKYmluZGluZywgaXQgc2VlbXMg aXQgd2lsbCBwcm9kdWNlIGR0YyB3YXJuaW5ncyBmb3Igb3ZlcmxhcHBpbmcgdW5pdAphZGRyZXNz ZXMuIEZ1cnRoZXJtb3JlLCBkcml2ZXJzIG1pZ2h0IGZhaWwgdG8gcHJvYmUgZHVlIHRvIC1FQlVT WSB3aGVuCmNsYWltaW5nIG92ZXJsYXBwaW5nIG1lbW9yeSByZWdpb25zIGxpa2UgMHgwYWNlNDAw MC4KClsgLi4uIF0KCj4gKyAgdmRkYS0xcDItc3VwcGx5Ogo+ICsgICAgZGVzY3JpcHRpb246IFBo YW5kbGUgdG8gMS4yViByZWd1bGF0b3Igc3VwcGx5IHRvIGEgUEhZLgo+ICsKPiArICBwb3J0czoK PiArICAgICRyZWY6IC9zY2hlbWFzL2dyYXBoLnlhbWwjL3Byb3BlcnRpZXMvcG9ydHMKCltTZXZl cml0eTogTWVkaXVtXQpXaWxsIHRoZXNlIHBvcnQgZGVmaW5pdGlvbnMgY2hhbmdlIHRoZSBEVCB0 b3BvbG9neSBieSBwbGFjaW5nIHRoZSBQSFkgYXMKYW4gaW50ZXJtZWRpYXRlIG5vZGU/CgpUaGUg ZXhpc3RpbmcgQ0FNU1MgYmluZGluZyBwb3J0cyBjdXJyZW50bHkgYXNzdW1lIGEgZGlyZWN0IHNl bnNvcgpjb25uZWN0aW9uLiBEbyB3ZSBuZWVkIG1hdGNoaW5nIHVwZGF0ZXMgaW4gcWNvbSx4MWU4 MDEwMC1jYW1zcy55YW1sIHRvCmFjY29tbW9kYXRlIHRoaXMgbmV3IHN0YW5kYWxvbmUgUEhZIGJp bmRpbmc/Cgo+ICsKPiArICAgIHByb3BlcnRpZXM6Cj4gKyAgICAgIHBvcnRAMDoKPiArICAgICAg ICAkcmVmOiAvc2NoZW1hcy9ncmFwaC55YW1sIy8kZGVmcy9wb3J0LWJhc2UKPiArICAgICAgICBk ZXNjcmlwdGlvbjoKPiArICAgICAgICAgIFNlbnNvciBpbnB1dC4gQWx3YXlzIHByZXNlbnQuIEEg c2luZ2xlIHNlbnNvciBpcyBkZXNjcmliZWQgYnkgYQo+ICsgICAgICAgICAgc2luZ2xlIGVuZHBv aW50IHdpdGggb25lIHRvIGZvdXIgZGF0YSBsYW5lcy4gRFBIWSBzcGxpdCBtb2RlLAo+ICsgICAg ICAgICAgd2hlcmUgdHdvIGluZGVwZW5kZW50IHNlbnNvcnMgc2hhcmUgdGhlIHNhbWUgUEhZLCBp cyBkZXNjcmliZWQKPiArICAgICAgICAgIGJ5IHR3byBlbmRwb2ludHM7IGVuZHBvaW50QDAgd2l0 aCBleGFjdGx5IHR3byBkYXRhLWxhbmVzIGFuZAo+ICsgICAgICAgICAgZW5kcG9pbnRAMSB3aXRo IGV4YWN0bHkgb25lIGRhdGEtbGFuZS4KPiArICAgICAgICB1bmV2YWx1YXRlZFByb3BlcnRpZXM6 IGZhbHNlCj4gKwo+ICsgICAgICAgIHBhdHRlcm5Qcm9wZXJ0aWVzOgo+ICsgICAgICAgICAgIl5l bmRwb2ludChAWzAtOWEtZl0rKT8kIjoKPiArICAgICAgICAgICAgJHJlZjogL3NjaGVtYXMvbWVk aWEvdmlkZW8taW50ZXJmYWNlcy55YW1sIwo+ICsgICAgICAgICAgICB1bmV2YWx1YXRlZFByb3Bl cnRpZXM6IGZhbHNlCj4gKyAgICAgICAgICAgIHByb3BlcnRpZXM6Cj4gKyAgICAgICAgICAgICAg ZGF0YS1sYW5lczoKPiArICAgICAgICAgICAgICAgIG1pbkl0ZW1zOiAxCj4gKyAgICAgICAgICAg ICAgICBtYXhJdGVtczogNAo+ICsKPiArICAgICAgICAgICAgcmVxdWlyZWQ6Cj4gKyAgICAgICAg ICAgICAgLSBkYXRhLWxhbmVzCj4gKyAgICAgICAgICAgICAgLSByZW1vdGUtZW5kcG9pbnQKPiAr Cj4gKyAgICAgICAgYWxsT2Y6Cj4gKyAgICAgICAgICAtIGlmOgo+ICsgICAgICAgICAgICAgIHJl cXVpcmVkOgo+ICsgICAgICAgICAgICAgICAgLSBlbmRwb2ludEAxCgpbU2V2ZXJpdHk6IE1lZGl1 bV0KRG9lcyB0aGlzIGNvbnN0cmFpbnQgbG9naWMgbGVhdmUgYSBsb29waG9sZSBmb3IgaW52YWxp ZCBzcGxpdC1tb2RlCmNvbmZpZ3VyYXRpb25zPwoKQmVjYXVzZSB0aGUgaWYtYmxvY2sgb25seSBl dmFsdWF0ZXMgdG8gdHJ1ZSB3aGVuIGVuZHBvaW50QDEgaXMgcHJlc2VudCwKYSBkZXZpY2UgdHJl ZSBjb25maWd1cmluZyBlbmRwb2ludEAwIGFuZCBlbmRwb2ludEAyIHdvdWxkIGJ5cGFzcyB0aGUK c3RyaWN0IGRhdGEtbGFuZSBsaW1pdHMuCgpCb3RoIGVuZHBvaW50cyB3b3VsZCBmYWxsIGJhY2sg dG8gdGhlIGdlbmVyaWMgcnVsZSBhYm92ZSwgYWxsb3dpbmcgdXAgdG8KNCBsYW5lcyBlYWNoLCB3 aGljaCBzaWxlbnRseSBjaXJjdW12ZW50cyB0aGUgc3BsaXQtbW9kZSBoYXJkd2FyZQpjb25zdHJh aW50cyAod2hpY2ggb25seSBhbGxvdyAyIGFuZCAxIGxhbmVzIHJlc3BlY3RpdmVseSkuIFNob3Vs ZCB0aGUKcGF0dGVyblByb3BlcnRpZXMgYmUgcmVzdHJpY3RlZCB0byBleGFjdGx5IGVuZHBvaW50 QDAgYW5kIGVuZHBvaW50QDEsIG9yCnRoZSBpZi1jb25kaXRpb24gYnJvYWRlbmVkPwoKLS0gClNh c2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDcy MC14MWUtY3NpMi1waHktdjEzLTAtMTYwYzMxOTU4ODYzQGxpbmFyby5vcmc/cGFydD0xCgotLSAK bGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw czovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FD1842050 for ; Mon, 20 Jul 2026 01:20:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784510434; cv=none; b=Q5DIX3wE1lwiFJyy+Ciglem1EUZujV/SJO2DKOrMKQ/hF9X7AmlqMM+aH9iqrbq3C1ddTyUpSEDJWxU4KeAp6f0U/nlPNeKYVqxJ34jfALFGHa2ET+9ezrnyspPiQewP6RZP2XUteZv8SBXC7S+fPOiLpr3yPb0SoNMR35xVXqg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784510434; c=relaxed/simple; bh=H1iSQGFiuKxX4CU6d/eK6tc04WhMDwUhxtxpl50nDB8=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=eaYeAJWQvPLrzcC8FPk1artW919R/RSGYgojRbMCXZbvXeHM8+nN/7RpQyAHibFHJqrmDe8Nxr2NRrWXHVXSs9DVhR9z0f6YdrttQx30f5gALMSStahDEOVBOdR/XfR8zQsavgK78weMfTKyngVGl56Dni7dCC4P8LpAuy4Fly0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eSfUPHl+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eSfUPHl+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68C3F1F000E9; Mon, 20 Jul 2026 01:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784510432; bh=2PLb8I13jer0vsrN/Qv6Kj67tynSbToxe6erdn09OCs=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=eSfUPHl+KfxSnth1p3GxD9iC4WTOl7Xnhml9k2kLxjUUK94discBitMmLcPiO+Gbz 7jxjvkl9HfnFqpIxj2wGS/xxq0JxMhmvPNvglRopnxPqxear6pCxr9hY4LGnkqIWKK 3+hLGumQnRHpa01sjHwNLlwGrwm3G0eKW4qrpXe3hETztvEKUO6UpNdYaS7YlKG4Sf uBmaYqhweYIn1sevS5DtmmPk3pCDbzQA7kqnYfODCTvo83sWqO3UHN1jVQQ5S1jR5O 7DxY4YJjbOrc+aBMS5JU+w9zHSNXpEYjvZjfL0nWuki0o0GQZ77NysqelEqrBo+pRW vy4UeVWaZmAPA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v13 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?QnJ5YW4gTydEb25vZ2h1ZQ==?= Cc: olteanv@gmail.com, neil.armstrong@linaro.org, vkoul@kernel.org, media-ci@linuxtv.org, linux-phy@lists.infradead.org, conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org In-Reply-To: <20260720-x1e-csi2-phy-v13-1-160c31958863@linaro.org> References: <20260720-x1e-csi2-phy-v13-0-160c31958863@linaro.org> <20260720-x1e-csi2-phy-v13-1-160c31958863@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 20 Jul 2026 01:20:32 +0000 Message-Id: <20260720012032.68C3F1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Medium] The newly added standalone `qcom,x1e80100-csi2-phy` binding clai= ms hardware resources and changes the OF graph topology without matching up= dates to the existing `qcom,x1e80100-camss.yaml` schema. - [Medium] The `patternProperties` for `port@0` allows arbitrary endpoint n= odes, bypassing the split-mode data-lane constraints. -- --- Patch [1]: [PATCH v13 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY = schema --- commit 21e0c2eac81f8a0822a401dad73b1be1b2b38b5e Author: Bryan O'Donoghue dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema This commit adds a new base schema for the MIPI CSI2 PHYs on Qualcomm SoCs, supporting DPHY modes (with CPHY left for future work). It includes support for a split-mode where two sensors can be connected to one PHY. > diff --git a/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy= .yaml b/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml > new file mode 100644 > index 0000000000000..880fe602945cb > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml > @@ -0,0 +1,195 @@ [ ... ] > +properties: > + compatible: > + const: qcom,x1e80100-csi2-phy > + > + reg: > + maxItems: 1 [Severity: Medium] Does this new reg definition overlap with the base addresses already claimed by qcom,x1e80100-camss.yaml? If a device tree implements this new binding alongside the existing CAMSS binding, it seems it will produce dtc warnings for overlapping unit addresses. Furthermore, drivers might fail to probe due to -EBUSY when claiming overlapping memory regions like 0x0ace4000. [ ... ] > + vdda-1p2-supply: > + description: Phandle to 1.2V regulator supply to a PHY. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports [Severity: Medium] Will these port definitions change the DT topology by placing the PHY as an intermediate node? The existing CAMSS binding ports currently assume a direct sensor connection. Do we need matching updates in qcom,x1e80100-camss.yaml to accommodate this new standalone PHY binding? > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + description: > + Sensor input. Always present. A single sensor is described by a > + single endpoint with one to four data lanes. DPHY split mode, > + where two independent sensors share the same PHY, is described > + by two endpoints; endpoint@0 with exactly two data-lanes and > + endpoint@1 with exactly one data-lane. > + unevaluatedProperties: false > + > + patternProperties: > + "^endpoint(@[0-9a-f]+)?$": > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + properties: > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + required: > + - data-lanes > + - remote-endpoint > + > + allOf: > + - if: > + required: > + - endpoint@1 [Severity: Medium] Does this constraint logic leave a loophole for invalid split-mode configurations? Because the if-block only evaluates to true when endpoint@1 is present, a device tree configuring endpoint@0 and endpoint@2 would bypass the strict data-lane limits. Both endpoints would fall back to the generic rule above, allowing up to 4 lanes each, which silently circumvents the split-mode hardware constraints (which only allow 2 and 1 lanes respectively). Should the patternProperties be restricted to exactly endpoint@0 and endpoint@1, or the if-condition broadened? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260720-x1e-csi2-p= hy-v13-0-160c31958863@linaro.org?part=3D1