From: sashiko-bot@kernel.org
To: "Xiang Lei" <leixiang@kylinos.cn>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] PCI/P2PDMA: Fix use-after-free in pci_p2pdma_add_resource() error path
Date: Mon, 20 Jul 2026 01:35:18 +0000 [thread overview]
Message-ID: <20260720013518.8F2C01F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260720012109.24164-1-leixiang@kylinos.cn>
> In pci_p2pdma_add_resource(), a devm action is registered to call
> pci_p2pdma_unmap_mappings() with the 'p2p_pgmap' context. If the subsequent
> call to gen_pool_add_owner() fails, the code jumps to the 'pages_free'
> error path.
>
> In this error path, 'p2p_pgmap' is explicitly freed via devm_kfree().
> However, the previously registered devm action is never removed. This
> leaves a dangling pointer in the device's devres list. When the device
> is unbound and devres is cleaning up resources, the unmap action will be
> called with the already-freed 'p2p_pgmap', resulting in a use-after-free
> bug.
>
> Fix this by properly calling devm_remove_action() in the error path before
> freeing 'p2p_pgmap'.
>
> Fixes: 7e9c7ef83d78 ("PCI/P2PDMA: Allow userspace VMA allocations through sysfs")
> Assisted-by: Antigravity:Gemini [tools]
> Signed-off-by: Xiang Lei <leixiang@kylinos.cn>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260720012109.24164-1-leixiang@kylinos.cn?part=1
prev parent reply other threads:[~2026-07-20 1:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 9:51 [PATCH] PCI/P2PDMA: Fix use-after-free in pci_p2pdma_add_resource() error path leixiang
2026-07-17 10:00 ` sashiko-bot
2026-07-17 10:48 ` Greg Kroah-Hartman
2026-07-20 1:16 ` Xiang Lei
2026-07-20 1:21 ` [PATCH v2] " Xiang Lei
2026-07-20 1:35 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720013518.8F2C01F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=leixiang@kylinos.cn \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.