From: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Wadim Mueller" <wafgo01@gmail.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Maxwell Doose" <maxwell@maxwelld.cc>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Marcelo Schmitt" <marcelo.schmitt1@gmail.com>,
"Rodrigo Alencar" <455.rodrigo.alencar@gmail.com>
Subject: Re: [PATCH v5 2/4] dt-bindings: iio: flow: add Sensirion SLF3S liquid flow sensor
Date: Mon, 20 Jul 2026 03:28:11 +0100 [thread overview]
Message-ID: <20260720032759.579e16cf@jic23-huawei> (raw)
In-Reply-To: <b2c6cc45-5a52-4992-b72b-dfde02cbc94d@kernel.org>
On Sun, 19 Jul 2026 08:19:34 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 14/07/2026 10:53, Wadim Mueller wrote:
> > Document the bindings for the Sensirion SLF3S family of digital
> > liquid-flow sensors on I2C. The family currently covers the
> > SLF3S-0600F, SLF3S-1300F and SLF3S-4000B variants.
> >
> > All variants share the same register map and are fully detectable
> > from the product-information register at probe time, so
> > sensirion,slf3s-1300f serves as the fallback compatible for the
> > other variants.
> >
> > The active calibration medium (water / IPA) is runtime-switchable
> > via the in_volumeflow_medium sysfs attribute and therefore not a
> > DT property.
> >
> > Signed-off-by: Wadim Mueller <wafgo01@gmail.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > ---
> > .../bindings/iio/flow/sensirion,slf3s.yaml | 58 +++++++++++++++++++
> > MAINTAINERS | 7 +++
> > 2 files changed, 65 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/flow/sensirion,slf3s.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/flow/sensirion,slf3s.yaml b/Documentation/devicetree/bindings/iio/flow/sensirion,slf3s.yaml
> > new file mode 100644
> > index 000000000000..c054a505b75d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/flow/sensirion,slf3s.yaml
> > @@ -0,0 +1,58 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/flow/sensirion,slf3s.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sensirion SLF3S liquid flow sensor
> > +
> > +maintainers:
> > + - Wadim Mueller <wafgo01@gmail.com>
> > +
> > +description:
> > + Family of digital liquid-flow sensors from Sensirion with I2C interface. All
> > + family members share the same register map; sub-types differ only in the flow
> > + scale factor and the calibrated measurement range. The sub-type can be
> > + identified from the product-information register.
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - const: sensirion,slf3s-1300f
> > + - items:
> > + - enum:
> > + - sensirion,slf3s-0600f
> > + - sensirion,slf3s-4000b
> > + - const: sensirion,slf3s-1300f
>
> This is fine with me, also fine with separate non-compatible compatibles.
Thanks!
I'd prefer separate to avoid confusing me at least! :)
It needs new version anyway as the driver (patch 4) doesn't seem to have
reached me or patchwork.
Jonathan
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2026-07-20 2:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 8:53 [PATCH v5 0/4] iio: flow: Sensirion SLF3S liquid flow sensor Wadim Mueller
2026-07-14 8:53 ` [PATCH v5 1/4] iio: types: add IIO_VOLUMEFLOW channel type Wadim Mueller
2026-07-14 8:53 ` [PATCH v5 2/4] dt-bindings: iio: flow: add Sensirion SLF3S liquid flow sensor Wadim Mueller
2026-07-19 6:19 ` Krzysztof Kozlowski
2026-07-20 2:28 ` Jonathan Cameron [this message]
2026-07-14 8:53 ` [PATCH v5 3/4] iio: core: add IIO_VAL_DECIMAL64_FEMTO format type Wadim Mueller
2026-07-20 2:29 ` [PATCH v5 0/4] iio: flow: Sensirion SLF3S liquid flow sensor Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720032759.579e16cf@jic23-huawei \
--to=jonathan.cameron@oss.qualcomm.com \
--cc=455.rodrigo.alencar@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=maxwell@maxwelld.cc \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=wafgo01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.