From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB7143B8D50 for ; Mon, 20 Jul 2026 07:22:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784532169; cv=none; b=gi5i4y0M+Bw/YqY51yzJ1OYH62qIl+P8y9JxtVdrrtLWb+KItqKwj7hxhdXQgt9bojKasj4HCM7nGhgnRJfioxA4ndOilGgc0gIe+urpTR5os/8gVP+oWDEMpHdnZkpR2b3HTKpmRwRSPicQdFI6zHvZxXReIclUcWQi4EeJwD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784532169; c=relaxed/simple; bh=OOTKP4pnSAz8xHGhbXtlqxKf0IRGK3PLKQEbgiMxO9Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nEHhadxV98nYjvVQMu9/7un7Ot+M/zgdpln2zSzUUod9j+tNhMhsgrsrtFU6jQ1LbYoXmPq9l0Bd+8fDwYiVbD5fy9KqywqXrHzpfbWDKldcMGc7GItGT/tvy4uwV0RFbvcYL7WOeM+FKViQev2oq/Qt5yTUVWP0hbEKc06oqZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dTk5rB2g; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dTk5rB2g" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c96bfabc8d4so3781976a12.3 for ; Mon, 20 Jul 2026 00:22:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784532165; x=1785136965; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IL4Hj7AEoE4Tzg2meurW+8WK6UP5mdpnN7tRwvqUA8A=; b=dTk5rB2gD/Ih8l1aEpFtjkX3Yf9iXQddBOAQhMIAWQJxL2clVGgdK4zLS0T0wDyhdB kvLLLSEisXudEj32hhAit6t8s1manzzLNozKKcvjaBiwtzsZWg8dq4YGrxt5A4Mj6MeL 3D9Do65nOPHk9glI+am9sgytgP7J0Os/KztQvXS/UhFigZXvwMpeY/EQa30e0Q1TyOzY ZbRJnA8hzbNT3HFMY0XCRptAmixIi6TdEXiuFCPJIGjXstuTDzaNOfNTkZIItXFxpRMR SdriiTjLJtHeU0eOfEV2HXvZKlXgDmmb9m9qM2U8T4HZmVE2L6QHev3ZsZB4M59evpBX Elrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784532165; x=1785136965; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=IL4Hj7AEoE4Tzg2meurW+8WK6UP5mdpnN7tRwvqUA8A=; b=aGvKCiQB+pK/IK1TwQImyqfmUAE8Zze7kiGKY51O1OdAAOUzxyyauOsPyvYSflHaQU iCdaO72JEGgi+kMqNQ/JPAI94UbO7lRM5IHBVuuuSxN70MErYd6C9vwlYnNle3kjxrCh h36Y/WJ6JgjiNdqYr/oG5gBga0lFGz5LeHNrPjHgaIPpTMoLxu44NztggWEv8mmK4p1k loSmpRipnX7h01FpNetehXUyXMBRbBiy+SdwbCbgMLutIrZTfxNJ8ap8Cb8QDifVysKQ KnlMbO5UmVvU0zVrm+7wzxZPzgr9fYTI/Jietg6gYPL0CohfyDs/lD2XJ2S9DFbj7twH c4zQ== X-Forwarded-Encrypted: i=1; AHgh+RpyGtxcGOFw2flyXCkcpCqmNSvGb5hVesbzomQp5BDLP5xrcuxGq6V6cxhB++HCvHMvoi2etpo6QlRPnMo=@vger.kernel.org X-Gm-Message-State: AOJu0YzSAdf3Op646eV4fhaZ4eObjuYzC0OJaqwFnI6H+CbqK0Q5I39/ Mx9vbgljjbewqybEuri/84rs/R82Z3yWmhkBL0s5tcbksWs5YC+8EAx/ X-Gm-Gg: AfdE7ckywuAbwC24YTKDYWl4f1R2bLPgo6c1zTasXxah/GJrGbBzxFNOS7jfnjMj6uL v9EQ25Ae6LYMn9jhcP7eKqRkF/Bkr83NUNSI1QVTzmbNJ+CCKcsD/BwXLDsVUx0rTOnclZI0DQM w/1S3/ymIbVnNREeleLOy1+vfdM17vviVga5lJact3Vddg87zwpujTbE8TKWUJ8jIqRLlaDJgMe JcbO3z7Gd2+fSVbg8lMFMGy+Lb1SEdSwzO21BICSZvHI/flxd3Yxbljnbex3qtcHrWvSbGEX4yJ bR1a51yOsloIHgujOiW4NMEsDyvwOzReJlitXMFnRJJsbvsAT+ZKWlxdg8p8q55Rs02ZfEbUjmd bozTRngXUZ2NdnwjMy02lwMyNlmKZUrT7dmgYhkARY8Js9edqXhAu1JPuvHBnCjHPEfFQ88W50m U/gu+zCq1b99nI+i9jTQNLgFkX6Sx52aee//kOwn2oFS1oi7yuWCFxfZpSRfUIKTQIm7DuSurnQ yWX1Up0DEgH1/4QId1E8VaHy5iwmvADIlF9jKudsar5Od9JKMyxZRFwSAVngMZsNHoc2yO70rul yOTv2BtYnHOpjq0= X-Received: by 2002:a05:6a21:a8b:b0:3bf:6ac8:8d29 with SMTP id adf61e73a8af0-3c3ad7a8ed5mr14170724637.21.1784532164879; Mon, 20 Jul 2026 00:22:44 -0700 (PDT) Received: from cs-1047136853211-default.asia-southeast1-b.c.z168d0f9edf9bc766-tp.internal (43.173.126.34.bc.googleusercontent.com. [34.126.173.43]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cb519de26a5sm4064176a12.22.2026.07.20.00.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 00:22:44 -0700 (PDT) From: Aditya Prakash Srivastava To: Jens Axboe , Christian Brauner , Alexander Viro Cc: Jan Kara , io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Aditya Prakash Srivastava Subject: [PATCH 1/2] fs: make listxattr and removexattr helpers non-static Date: Mon, 20 Jul 2026 07:22:12 +0000 Message-ID: <20260720072213.2719-2-aditya.ansh182@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260720072213.2719-1-aditya.ansh182@gmail.com> References: <20260720072213.2719-1-aditya.ansh182@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for adding IORING_OP_REMOVEXATTR, FREMOVEXATTR, LISTXATTR, and FLISTXATTR support in io_uring, we need to invoke the respective VFS-layer list/remove helpers from within io_uring. Make the following four helpers non-static and declare them in fs/internal.h: - file_listxattr() - filename_listxattr() - file_removexattr() - filename_removexattr() No functional change is introduced. Signed-off-by: Aditya Prakash Srivastava --- fs/internal.h | 7 +++++++ fs/xattr.c | 8 +++----- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/fs/internal.h b/fs/internal.h index 355d93f92208..1294424431f3 100644 --- a/fs/internal.h +++ b/fs/internal.h @@ -297,6 +297,13 @@ int filename_setxattr(int dfd, struct filename *filename, unsigned int lookup_flags, struct kernel_xattr_ctx *ctx); int setxattr_copy(const char __user *name, struct kernel_xattr_ctx *ctx); int import_xattr_name(struct xattr_name *kname, const char __user *name); +ssize_t file_listxattr(struct file *f, char __user *list, size_t size); +ssize_t filename_listxattr(int dfd, struct filename *filename, + unsigned int lookup_flags, + char __user *list, size_t size); +int file_removexattr(struct file *f, struct xattr_name *kname); +int filename_removexattr(int dfd, struct filename *filename, + unsigned int lookup_flags, struct xattr_name *kname); int may_write_xattr(struct mnt_idmap *idmap, struct inode *inode); diff --git a/fs/xattr.c b/fs/xattr.c index d58979115200..1004b1d22cc4 100644 --- a/fs/xattr.c +++ b/fs/xattr.c @@ -953,14 +953,12 @@ listxattr(struct dentry *d, char __user *list, size_t size) return error; } -static ssize_t file_listxattr(struct file *f, char __user *list, size_t size) { audit_file(f); return listxattr(f->f_path.dentry, list, size); } -static ssize_t filename_listxattr(int dfd, struct filename *filename, unsigned int lookup_flags, char __user *list, size_t size) @@ -1036,7 +1034,7 @@ removexattr(struct mnt_idmap *idmap, struct dentry *d, const char *name) return vfs_removexattr(idmap, d, name); } -static int file_removexattr(struct file *f, struct xattr_name *kname) +int file_removexattr(struct file *f, struct xattr_name *kname) { int error = mnt_want_write_file(f); @@ -1049,8 +1047,8 @@ static int file_removexattr(struct file *f, struct xattr_name *kname) return error; } -static int filename_removexattr(int dfd, struct filename *filename, - unsigned int lookup_flags, struct xattr_name *kname) +int filename_removexattr(int dfd, struct filename *filename, + unsigned int lookup_flags, struct xattr_name *kname) { struct path path; int error; -- 2.47.3