From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBF76C44521 for ; Mon, 20 Jul 2026 07:43:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nce4AadG06uaebLMKC6KG2ngaMNUbaB+n+SVtHtd2/o=; b=oAvV+C6i3xS40q MHZO4z3IODUp7Daje6wlN6R8ViNcyU/m3FZe69SdwftUHQasVqHlQ+mPtKOMT9p3xtdQwe19opEUi FryQ1sSk9PGBxGwAtl1/QNLmw8y+8/CknP35UEZ9BKGDtrDxRZYvvjIO7UsM5TbaSRF5SkFx540Hr MJ4/h4BJ4HjckOU+wXdsSUuwbcnFWDOFwNtcpvlUhdrngHwNhVgrEUsLqT6oXeA2hs+bS/8t+zwrt sxY+ZomZgIQOC6IR1ieId2/oKc1/E/K/xa+Th+L+JTZrlhzBB+kmMIkh6thZCwlpXEGw8513pyegF fgtyaHRSeEs+gUFsfjkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wliew-000000067zr-2UK8; Mon, 20 Jul 2026 07:43:30 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wliev-000000067zZ-0f4n for linux-i3c@lists.infradead.org; Mon, 20 Jul 2026 07:43:29 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 84DDE413FB; Mon, 20 Jul 2026 07:43:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F18B1F000E9; Mon, 20 Jul 2026 07:43:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784533408; bh=gmm3vhVK/eoXr8/4cb+GWd9+j4TO3tlIDB0ZHWDbv6Q=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=hGepy3gONjYzxxJnTulCmOlHOEqSCnrTKWsBbq/Iit0tdqVekQe7e63zxqvl6tzv+ rfH5Os1kBlC9UVnKSd+jW0fXBqoaE/ImQAmL6MaiN6oP/b31pvM8NgzpXaWrBstRX0 UuZYPKFnNL0DqP6hgewKICbmInNuSBxZ98jIZ1v7oZfIEwUGjDj2B7kfqq60MyQfXX zQ2W3WgLFMn0PI/+XGwy1H55upTPh4vGoSeBcUbFamJKlvFeh7eg8DmTzyvVis2lMH gt7FOrNnVpmLfLA0XBGKndiJYfx413CviNOjvDbD6qfj2qJuuc3BF5YM6+FbcH52Uo rqiF+gd6BIAhQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: i3c: dw: Document missing optional core reset To: "Shubham Patil" Cc: linux-i3c@lists.infradead.org, robh@kernel.org, Frank.Li@kernel.org, "Alexandre Belloni" , conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260720073510.1869623-2-shubhamsanjay.patil@amd.com> References: <20260720073510.1869623-1-shubhamsanjay.patil@amd.com> <20260720073510.1869623-2-shubhamsanjay.patil@amd.com> Date: Mon, 20 Jul 2026 07:43:27 +0000 Message-Id: <20260720074328.1F18B1F000E9@smtp.kernel.org> X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIFRoZSBiaW5kaW5nIHNj aGVtYSBhZGRzIHRoZSBgcmVzZXRzYCBwcm9wZXJ0eSBidXQgaW50ZW50aW9uYWxseSBvbWl0cyBg cmVzZXQtbmFtZXNgLiBUaGUgZHJpdmVyIHN0cmljdGx5IHJlcXVpcmVzIGByZXNldC1uYW1lcyA9 ICJjb3JlX3JzdCJgIHRvIGZpbmQgdGhlIHJlc2V0IGNvbnRyb2wsIGNhdXNpbmcgaXQgdG8gc2ls ZW50bHkgaWdub3JlIHRoZSByZXNldC4KLS0KCi0tLSBQYXRjaCBbMV06IFtQQVRDSCB2MiAxLzJd IGR0LWJpbmRpbmdzOiBpM2M6IGR3OiBEb2N1bWVudCBtaXNzaW5nIG9wdGlvbmFsIGNvcmUgcmVz ZXQgLS0tCmNvbW1pdCA2NzNiMDYwODhhOWI1OTg3NWQ3MTdkYjJjOWFmYjU2Mjk1YWM4N2E5CkF1 dGhvcjogU2h1YmhhbSBQYXRpbCA8c2h1YmhhbXNhbmpheS5wYXRpbEBhbWQuY29tPgoKZHQtYmlu ZGluZ3M6IGkzYzogZHc6IERvY3VtZW50IG1pc3Npbmcgb3B0aW9uYWwgY29yZSByZXNldAoKVGhp cyBjb21taXQgZG9jdW1lbnRzIGFuIG9wdGlvbmFsIGNvcmUgcmVzZXQgcHJvcGVydHkgZm9yIHRo ZSBEZXNpZ25XYXJlIEkzQwptYXN0ZXIgSVAuIEl0IGFkZHMgdGhlIHJlc2V0cyBwcm9wZXJ0eSB3 aXRoIGEgbWF4SXRlbXMgb2YgMSB0byB0aGUgc2NoZW1hCmJ1dCBleHBsaWNpdGx5IGRyb3BzIHRo ZSByZXNldC1uYW1lIHByb3BlcnR5LgoKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL2kzYy9zbnBzLGR3LWkzYy1tYXN0ZXIueWFtbCBiL0RvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9pM2Mvc25wcyxkdy1pM2MtbWFzdGVyLnlhbWwKPiBpbmRl eCBlODAzNDU3ZDNmNTU0Li5kYzdlZTM4MDAxZDZkIDEwMDY0NAo+IC0tLSBhL0RvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9pM2Mvc25wcyxkdy1pM2MtbWFzdGVyLnlhbWwKPiArKysg Yi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvaTNjL3NucHMsZHctaTNjLW1hc3Rl ci55YW1sCj4gQEAgLTM4LDYgKzM4LDkgQEAgcHJvcGVydGllczoKPiAgICBpbnRlcnJ1cHRzOgo+ ICAgICAgbWF4SXRlbXM6IDEKPiAgCj4gKyAgcmVzZXRzOgo+ICsgICAgbWF4SXRlbXM6IDEKPiAr CgpbU2V2ZXJpdHk6IEhpZ2hdClNpbmNlIHRoaXMgc2NoZW1hIGludGVudGlvbmFsbHkgb21pdHMg cmVzZXQtbmFtZXMsIGRldmljZSB0cmVlcyBjYW5ub3QKcHJvdmlkZSBpdCB3aXRob3V0IGJyZWFr aW5nIHNjaGVtYSB2YWxpZGF0aW9uLgoKSG93ZXZlciwgZG9lc24ndCB0aGUgZHJpdmVyIGV4cGxp Y2l0bHkgcmVseSBvbiByZXNldC1uYW1lcyB0byBmaW5kIHRoaXMKcmVzZXQgY29udHJvbD8KCkxv b2tpbmcgYXQgZHdfaTNjX2NvbW1vbl9wcm9iZSgpIGluIGRyaXZlcnMvaTNjL21hc3Rlci9kdy1p M2MtbWFzdGVyLmM6CgoJbWFzdGVyLT5jb3JlX3JzdCA9IGRldm1fcmVzZXRfY29udHJvbF9nZXRf b3B0aW9uYWxfZXhjbHVzaXZlX2RlYXNzZXJ0ZWQoCgkJCQkJJnBkZXYtPmRldiwgImNvcmVfcnN0 Iik7CgpCZWNhdXNlIHRoaXMgc2VhcmNoZXMgZm9yIHRoZSAiY29yZV9yc3QiIHN0cmluZyBpbiB0 aGUgcmVzZXQtbmFtZXMKcHJvcGVydHksIHdvbid0IGl0IGZhaWwgdG8gZmluZCB0aGUgcmVzZXQg YW5kIHNpbGVudGx5IHJldHVybiBOVUxMCndpdGhvdXQgdGhlIHByb3BlcnR5IGJlaW5nIGRlZmlu ZWQgaW4gdGhlIGRldmljZSB0cmVlPwoKVGhpcyB3b3VsZCB0dXJuIGFsbCBzdWJzZXF1ZW50IHJl c2V0IG9wZXJhdGlvbnMgaW50byBuby1vcHMuIFNob3VsZApyZXNldC1uYW1lcyBiZSBhZGRlZCBi YWNrIHRvIHRoZSBiaW5kaW5nIHRvIG1hdGNoIHRoZSBkcml2ZXIncwpleHBlY3RhdGlvbnM/Cgo+ ICAgIHBvd2VyLWRvbWFpbnM6Cj4gICAgICBtYXhJdGVtczogMQo+CgotLSAKU2FzaGlrbyBBSSBy ZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwNzIwMDczNTEwLjE4 Njk2MjMtMS1zaHViaGFtc2FuamF5LnBhdGlsQGFtZC5jb20/cGFydD0xCgotLSAKbGludXgtaTNj IG1haWxpbmcgbGlzdApsaW51eC1pM2NAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWkzYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98E0539934B for ; Mon, 20 Jul 2026 07:43:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784533417; cv=none; b=kNwCj+c5dgotuzKifyYv897K72+fOc+R7qIJ4dQxpYg6XSbjsusPsQuUGvRni8vd9Fjse5LI5166LCZ4QWehdHUrkbK75vdN2qw+9fWqUpfBRPqEQJUieJIoG0Bg7nt6/fy17UZcX/cHHu/5+p58XzdHs96/ZYltPqv7t9NOUY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784533417; c=relaxed/simple; bh=ZyN+sy1SalzdpOzo0iwNDubc1ysxjgttasOmwInoZOI=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=BoXRqfIPPGbJ5YxPyMoB7CNEP1ho9yK1Ia0n+WbcSCA/Ogh0cG7Pxt5zxNfNpK8o9nKtO7srpUkHKx0z2xkaqi/jGMZjB/NVnDIGfRa/OAGbtIdaFSDg4GlBHHOcV7SXNhIAYMj2W53FhPoKsSSulXAKs54JC9uefRpkSHoeFZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hGepy3gO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hGepy3gO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F18B1F000E9; Mon, 20 Jul 2026 07:43:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784533408; bh=gmm3vhVK/eoXr8/4cb+GWd9+j4TO3tlIDB0ZHWDbv6Q=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=hGepy3gONjYzxxJnTulCmOlHOEqSCnrTKWsBbq/Iit0tdqVekQe7e63zxqvl6tzv+ rfH5Os1kBlC9UVnKSd+jW0fXBqoaE/ImQAmL6MaiN6oP/b31pvM8NgzpXaWrBstRX0 UuZYPKFnNL0DqP6hgewKICbmInNuSBxZ98jIZ1v7oZfIEwUGjDj2B7kfqq60MyQfXX zQ2W3WgLFMn0PI/+XGwy1H55upTPh4vGoSeBcUbFamJKlvFeh7eg8DmTzyvVis2lMH gt7FOrNnVpmLfLA0XBGKndiJYfx413CviNOjvDbD6qfj2qJuuc3BF5YM6+FbcH52Uo rqiF+gd6BIAhQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: i3c: dw: Document missing optional core reset Reply-To: sashiko-reviews@lists.linux.dev To: "Shubham Patil" Cc: linux-i3c@lists.infradead.org, robh@kernel.org, Frank.Li@kernel.org, "Alexandre Belloni" , conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260720073510.1869623-2-shubhamsanjay.patil@amd.com> References: <20260720073510.1869623-1-shubhamsanjay.patil@amd.com> <20260720073510.1869623-2-shubhamsanjay.patil@amd.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 20 Jul 2026 07:43:27 +0000 Message-Id: <20260720074328.1F18B1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] The binding schema adds the `resets` property but intentionally om= its `reset-names`. The driver strictly requires `reset-names =3D "core_rst"= ` to find the reset control, causing it to silently ignore the reset. -- --- Patch [1]: [PATCH v2 1/2] dt-bindings: i3c: dw: Document missing option= al core reset --- commit 673b06088a9b59875d717db2c9afb56295ac87a9 Author: Shubham Patil dt-bindings: i3c: dw: Document missing optional core reset This commit documents an optional core reset property for the DesignWare I3C master IP. It adds the resets property with a maxItems of 1 to the schema but explicitly drops the reset-name property. > diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yam= l b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml > index e803457d3f554..dc7ee38001d6d 100644 > --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml > +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml > @@ -38,6 +38,9 @@ properties: > interrupts: > maxItems: 1 > =20 > + resets: > + maxItems: 1 > + [Severity: High] Since this schema intentionally omits reset-names, device trees cannot provide it without breaking schema validation. However, doesn't the driver explicitly rely on reset-names to find this reset control? Looking at dw_i3c_common_probe() in drivers/i3c/master/dw-i3c-master.c: master->core_rst =3D devm_reset_control_get_optional_exclusive_deasserted( &pdev->dev, "core_rst"); Because this searches for the "core_rst" string in the reset-names property, won't it fail to find the reset and silently return NULL without the property being defined in the device tree? This would turn all subsequent reset operations into no-ops. Should reset-names be added back to the binding to match the driver's expectations? > power-domains: > maxItems: 1 > --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260720073510.1869= 623-1-shubhamsanjay.patil@amd.com?part=3D1