From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE70E3064B5 for ; Mon, 20 Jul 2026 08:50:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784537458; cv=none; b=oiQvcDJkWdLQhx1x0W/MqOnVv62ni0F0wM5eBi4k6KZWVKfAMcOI06TKOFW9JkXQU2OcEB7EKSulK7T0MwEQ6T3zbqsLJSNn+6X2tclYthKkrIk5f+27ohGfjgUSI9cUptCfRv1HUtZpsHum0MD7Zl5mR3PpRbh39pyyXWQUzB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784537458; c=relaxed/simple; bh=vmF0k0EuYiPEGnCAocsDj12Z7l953oukZnNxrz/xTjU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RgYqCHmccpf71+prFCXYxr+fK+jfP7BlCI7U3OM2DYFOA2ZC6Tped+diTEhZNiUIY2QocmxRW4r2hdyNfCiwd9liFHd57cyV6wYNw3NCUZMgsfJmr+fcg5CAaTdU05G8P4GF60qfBNS4HAUFjy8OGHlGzyu+Lwvruqx0Tp2Hz9Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mjq7pu1m; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mjq7pu1m" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ceab75934dso102619435ad.2 for ; Mon, 20 Jul 2026 01:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784537457; x=1785142257; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=RVeFOQVTpiRlKBlmYWsJDVlKLQYAX1ODqxNV2wyX7Ts=; b=mjq7pu1mNVfVuLz2dvWI7VfU0UignorDk3fquv4tOw/Jcj03OO3RxHkDRsRL5hsnjH TG89xqhU97r2C71Ort4hNjLy62a4jmfeCOXLF0MlyM7j5SFJetOYScbPq/Kk0S81Z5D1 lXeiM95iVeqL9Zdkc2v8AFX1XtX1kx6rYmxwW1ZCVlaMDtT/369Zv0voY+s6tFgLB3L6 u6tDXnmKLI0OuM8csML858TILec6rDmBu5Mme8DuKbWvOYncAIs3ZnuNuofUcKtu0v20 LUoq7FgHaeXB0A2eZhJbhvpm0p9FIA/7cu3UE0vZnUB3ttvYvNxUfwm8/Fprdr8mgpD/ IAug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784537457; x=1785142257; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RVeFOQVTpiRlKBlmYWsJDVlKLQYAX1ODqxNV2wyX7Ts=; b=LRf3zfZ4wXOK2R+hmREZ7jkT/Ogmuwfh04+vEwfkhDuB4z/4h4GXT+sPPUlKmUj6Z0 ORI66D9yh+LL+ruuPhsf7zBqGBp0d7xDyfmr5+Wo1hKr9v578YD1h66gVZ+tWpCSQ3qS RfliGIgPDgaBSSkmF87+aOXaMffrfKFlQwNaKkxifWq+zPyDOa2vyL6HYNdrZ3dbXsTD oNvmHi37wWbFaEGIpVah5BUIyV5DAkxSDK3bI8tDd81V1+6w2J9ruZs+fuhjEuUCrxlI CaHVbg53V9ty7SYQCNgK1FreaBOIgIxHn1HoT16cE1AbbsBfpOgDqfQ8m4vFygdVU+Ju 3YXQ== X-Forwarded-Encrypted: i=1; AHgh+RrmX6biJiqyahdN/C5Y7WrHdK4epZWSTiHqtsSgvw/upHHE4pEtES6MS7CSCE6YYJ7i+S4uYgE6oFV6Ynw=@vger.kernel.org X-Gm-Message-State: AOJu0YzRyYLjIhYRam0rIQeNBl+E2O/8BaiLxQAnbW+GgkEDYST+88I8 urRRaN/pSMwMs25Slzti6n9gO8Oxlr1uRozogBF52b7tplo3G3m9lfqQ X-Gm-Gg: AfdE7clxVR9L8aYeXb1sIsiCSQTbandXA6m84W2AulYmfBsEpC2ZSxnRm58clLiYWP3 KRuCYgn6QIAFf6KhhyJG6+CTPYUKSfAo18EqQC6bJRoS/HyAI5+d24c643OqDIoJNE8ibXvt1K8 /OC+edywYMV9+M82oDhiLry+fEf6ofBHmrzRJipV7wC/UIhYkxuyDxkbeiKWRyD9LtJZUS72Nhl 81hDrlvc9Y5m9LJ0hwt+L3p02HgtU5IOVoY/r1QOa5UyVbpSalga1RsV7eU99xYP4z5crmXZzUU 2lEAnGuTf8pPvNltmaO+0LuC5yGz1339DpVogS/UKHQ/0doecXQV8U3VYduTc/O8GzR37akqZf1 wfs9c77aSUbJQO1bHDHxDoebuhNbCAqOPDsvs1SvuJ7ZDbsevt2f3j077QZdFYdpWoSsMb9eC39 Txx4TWLUav9zVWEhC3jzaSCyziRVE6z+bK7uaU X-Received: by 2002:a17:902:ea0d:b0:2ce:f9db:a9e0 with SMTP id d9443c01a7336-2cf34887b36mr146940535ad.16.1784537457051; Mon, 20 Jul 2026 01:50:57 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf346da095sm52955985ad.49.2026.07.20.01.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 01:50:56 -0700 (PDT) From: phucduc.bui@gmail.com To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 1/2] Input: snvs_pwrkey: Improve probe error handling Date: Mon, 20 Jul 2026 15:50:40 +0700 Message-ID: <20260720085041.224896-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Use dev_err_probe() for devm_clk_get_optional_enabled() to handle deferred probe correctly. Return the original error from platform_get_irq() instead of replacing it with -EINVAL. Drop the redundant error message after devm_request_irq(), as the helper already reports request failures internally. Signed-off-by: bui duc phuc --- drivers/input/keyboard/snvs_pwrkey.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/snvs_pwrkey.c index 954055aaf6e2..fa08ac561bf2 100644 --- a/drivers/input/keyboard/snvs_pwrkey.c +++ b/drivers/input/keyboard/snvs_pwrkey.c @@ -142,16 +142,15 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev) } clk = devm_clk_get_optional_enabled(&pdev->dev, NULL); - if (IS_ERR(clk)) { - dev_err(&pdev->dev, "Failed to get snvs clock (%pe)\n", clk); - return PTR_ERR(clk); - } + if (IS_ERR(clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(clk), + "Failed to get snvs clock\n"); pdata->wakeup = of_property_read_bool(np, "wakeup-source"); pdata->irq = platform_get_irq(pdev, 0); if (pdata->irq < 0) - return -EINVAL; + return pdata->irq; error = of_property_read_u32(np, "power-off-time-sec", &val); if (!error) { @@ -209,10 +208,8 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev) error = devm_request_irq(&pdev->dev, pdata->irq, imx_snvs_pwrkey_interrupt, 0, pdev->name, pdev); - if (error) { - dev_err(&pdev->dev, "interrupt not available.\n"); + if (error) return error; - } error = input_register_device(input); if (error < 0) { -- 2.43.0