From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD8D14343E2 for ; Mon, 20 Jul 2026 15:49:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562542; cv=none; b=XtqpKiO5U3iNfZy9NdIewlSG+QfwuU444MivGtx4q0HOSUZfAwaGkvyHL3JBVu4iGl4pZRRQ/G2T83ZKMqRmH/eHw5JnqlFEXAwcYNyeqU2m5OT9fsVrbLyhNkN35wyNcgK2q9qYuTMaBk+u1uFNfleMMMqz14nyQg4HF+8zknM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562542; c=relaxed/simple; bh=ABP2T/ie+8nz0bogKvgwnV6IYL90+z68khp+tMMS9Rc=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=vCiF6WZ753r6DU+boozZ3UgxfFGQeJU50EKh3W9tGU8DY5zNT1pPJc+M3PPPe1ZE92tvdlcza1uLsYVjyhPTGqUams7h3YLZde4GzatDL2gZ+roENpFfeL8xEshsbKDMXSvP7nDfRcCifeCwLdWeEvNaXaygFU28K+2nswaYcdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VTyJKnZ4; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VTyJKnZ4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F9A41F000E9; Mon, 20 Jul 2026 15:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784562540; bh=Xe1naFap2vMoinniMbjZyhDXWKPA2QlWCTW+nUSZ6WA=; h=Subject:To:Cc:From:Date; b=VTyJKnZ4EJVmQx+f27XfbmLl1SVJRMnv5Ex2Wz9ckTu/QhwZPTGho/dS+1vmM31yk BlpmnRBBSr8YFndfWG44vjItM9PFOQqXF7Rk8oV/COloKS6vmQ2OYY6ErmVOMY1L0a Q3hZKidEs+Dfi0DvehWzgMeSau5/7ABeVj8dQSYQ= Subject: FAILED: patch "[PATCH] wifi: libertas_tf: fix use-after-free in lbtf_free_adapter()" failed to apply to 6.12-stable tree To: maoyixie.tju@gmail.com,johannes.berg@intel.com Cc: From: Date: Mon, 20 Jul 2026 17:43:09 +0200 Message-ID: <2026072009-saddlebag-problem-d820@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.12-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.12.y git checkout FETCH_HEAD git cherry-pick -x aa6dcd5c8dd9ba1d7d0f60093bcda41c0d6d438d # git commit -s git send-email --to '' --in-reply-to '2026072009-saddlebag-problem-d820@gregkh' --subject-prefix 'PATCH 6.12.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From aa6dcd5c8dd9ba1d7d0f60093bcda41c0d6d438d Mon Sep 17 00:00:00 2001 From: Maoyi Xie Date: Mon, 22 Jun 2026 15:53:38 +0800 Subject: [PATCH] wifi: libertas_tf: fix use-after-free in lbtf_free_adapter() lbtf_free_adapter() calls timer_delete(&priv->command_timer), which does not wait for a running command_timer_fn() callback. lbtf_free_adapter() runs on the teardown path right before ieee80211_free_hw() frees priv, both in lbtf_remove_card() and in the probe error path. command_timer is armed by mod_timer() in lbtf_cmd() whenever a firmware command is sent. command_timer_fn() dereferences priv. If a command times out as the device is removed, command_timer_fn() runs concurrently with teardown and dereferences priv after it has been freed. This is the same use-after-free that commit 03cc8f90d053 ("wifi: libertas: fix use-after-free in lbs_free_adapter()") fixed in the sibling libertas driver. The libertas_tf variant has the identical pattern and was left unchanged. Use timer_delete_sync() so any in-flight callback completes before priv is freed. Fixes: 06b16ae53192 ("libertas_tf: main.c, data paths and mac80211 handlers") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie Link: https://patch.msgid.link/178211481807.2212567.8773346114561900100@maoyixie.com Signed-off-by: Johannes Berg diff --git a/drivers/net/wireless/marvell/libertas_tf/main.c b/drivers/net/wireless/marvell/libertas_tf/main.c index fb20fe31cd36..42be6fa22f9c 100644 --- a/drivers/net/wireless/marvell/libertas_tf/main.c +++ b/drivers/net/wireless/marvell/libertas_tf/main.c @@ -174,7 +174,7 @@ static void lbtf_free_adapter(struct lbtf_private *priv) { lbtf_deb_enter(LBTF_DEB_MAIN); lbtf_free_cmd_buffer(priv); - timer_delete(&priv->command_timer); + timer_delete_sync(&priv->command_timer); lbtf_deb_leave(LBTF_DEB_MAIN); }