From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFB973A5E72 for ; Mon, 20 Jul 2026 10:30:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784543435; cv=none; b=dRRqo0fcs0DF3sYcYRYy++LbxaPYKPU4yUUWLRvkHskUR6r/JZxtyzIM9rrIAR9t3+XH83VCKU9tX/um35jedebZH5iSa2rj41AkNF7ciMKtW7lu9g97VsN6uf+biFhcxjFEqpVUi+vPb23BgrV1QGvY9xWYFnJymscBdH8Z8WE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784543435; c=relaxed/simple; bh=9v8IcUjat8TEIAwG7AjNbu0pZK52X7TrT1s9XlSPBt0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=D7MqPYuUs1hTWUGZZZ0xHGfjvBjg2FjiZul2jCHywIn+miH1a8gQ3Lapi4AviU1M63I9J0qWKwwaZCnaf63q31JknFM2fjF/J42e5sZ/Pj6Xe+/rHXyLgCLp1Il8L+wEp1aDyWlCIpru8rbFgZRY/MNHmBQPi21dO1/sSHted0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mSQqc5t/; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mSQqc5t/" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2ceae1ed204so76809455ad.0 for ; Mon, 20 Jul 2026 03:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784543432; x=1785148232; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=W6kuUw7/fNv5m3n/7oR0Zyz7m4/Uu2x3pL7qRujVGGo=; b=mSQqc5t/MFcxx6bU7ftZwFiEJoQQ78rZvAkNLsxmF/9fi3dSmXIDbCa9MGiB0/ceAe Q6A1n9XjCRG5frXJyQw3MZq9mGLyZ4EnGd5W989oew1yXlkxf18L9UaUWlH+eZMx9lDL nyVwlf9C04AT8x9GYBr1D2x9BOUWoq21kxeLz+OKbAjvmv/MiPYcUP3H5AOhXUHIzNBD aHAGIqkDgumCd7cK3LzHNU+74HZruxF5C2wARMfS9ltPqWQrofCmx8h82osYRNbU5mX1 zR9cnwZhYqDWV/yELZ8egTnHStk7gxabrA1o1VGzl9UIDb223ucxwpvYEfdx8ln61hZu 1uXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784543432; x=1785148232; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=W6kuUw7/fNv5m3n/7oR0Zyz7m4/Uu2x3pL7qRujVGGo=; b=KmAw6UyQqdlImhbEbZxRmifyVCzj5BTwRcGwCu1Ezv30XK4fImja5peCmMUUB0pO/j Uw9DYyDFtp7r6Sajfuqev40bZbZukkhDm6fcGqba5zah8O7JMzkQQKosiN1nVU4RWAF4 91Ch06p9m+gLAg7wcZSzbwSXLBc6Iu3482YkMPrqpnmlkoV6GRNj995GBiL/NyZNxeHL Kvl7HB+fXbRhRPCf2kc59ho8cSXKVZLlFEyh5QZdoB0m5e690Ys6nJSGSdM4pM4oC27i WRNTH95vT4G+95t2pkp+geXCkkFc+8bjSvGoi4MvM/NQPq0PUDEJKzDknIq0hwmGp/Jq /7bg== X-Forwarded-Encrypted: i=1; AHgh+RoGIQ00p67v+1kukvqBnYxCVK/RNI3XEcepACxybuEpAUKjk/kCxE+CdOK6n5XCWE8u18DoFRrFURVlb48=@vger.kernel.org X-Gm-Message-State: AOJu0YyA1OGRBh14JZT+HLCkN1elLWxIUJ46UU2dDipxZ8cd7dvdhST/ dP1woAFdiZhH1sf7Zr9u4+9uzDkgJzbf57pI6os56RZkscZiScpcWB5/2bO609k= X-Gm-Gg: AfdE7clCZtVwX8yeUCwXPHBQmZp8AUMJdAfzCqVnIBLow1axrh9QLeiX6xRUHwyCMnN h5s0GXm2Hi71teF7rCJEhHMnHTKTUSUK6sScA0W/LBU5r6QkJry+Yexb8x0dv4b8q9Rjly3hWMe VcrdWWLWJCSQANsFmi7kRfUKb/1/v5SLhZ6MzqXYdlvXUG5xbHHkWY23fCmRK8sjwwKIOZmPbxH nXorypbKttIMo/yo36XNvYPC2+i6AbK97idJqjxuc7MTHLXnMQozLUFy4GiIjowFL3QN+0tDnMp gDe+h4YgOcuDUklxq3UosttcyHW3AalQlVvd4562F09HvHGcP/oSi3w7RGY1E8lzOAe01SNsy/i UPpFlNbo56avPTM3qsTLOBQmZT9Sk10jpgKY41/Q4ZIFqrlT66AbVdW76xG8X2YbYH12ti1ceDB hRJoMVmPQPDWIOuGZ3B2cuEMbcag== X-Received: by 2002:a05:6a20:3ca3:b0:3c3:7ecd:72df with SMTP id adf61e73a8af0-3c3ad86ab89mr15283565637.30.1784543431946; Mon, 20 Jul 2026 03:30:31 -0700 (PDT) Received: from t-rex ([2401:4900:c200:8f2e:8d2c:f805:595:9600]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a20c158sm38054425eec.29.2026.07.20.03.30.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 03:30:31 -0700 (PDT) From: kr494167@gmail.com To: lee@kernel.org, pavel@kernel.org Cc: s.trumtrar@pengutronix.de, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, surendra Subject: [PATCH] leds: lp5860: reject out-of-range channel IDs Date: Mon, 20 Jul 2026 16:00:17 +0530 Message-ID: <20260720103017.88090-1-kr494167@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: surendra lp5860_iterate_subleds() detects a channel ID greater than the hardware limit, but returns the successful result of fwnode_property_read_u32(). The caller therefore treats the malformed sub-LED description as valid and uses the invalid ID for register addressing. Return -EINVAL when the channel ID is out of range. Fixes: f0a66563aa2d ("leds: Add support for TI LP5860 LED driver chip") Signed-off-by: surendra --- drivers/leds/rgb/leds-lp5860-core.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/leds/rgb/leds-lp5860-core.c b/drivers/leds/rgb/leds-lp5860-core.c index e21d5f2302be..75498311b080 100644 --- a/drivers/leds/rgb/leds-lp5860-core.c +++ b/drivers/leds/rgb/leds-lp5860-core.c @@ -114,12 +114,18 @@ static int lp5860_iterate_subleds(struct lp5860_led *led, struct led_init_data * } ret = fwnode_property_read_u32(led_node, "reg", &channel); - if (ret < 0 || channel > LP5860_MAX_LED) { + if (ret < 0) { dev_err_probe(led->chip->dev, ret, "%pfwP: 'reg' property is missing. Skipping.\n", led_node); fwnode_handle_put(led_node); return ret; } + if (channel > LP5860_MAX_LED) { + dev_err(led->chip->dev, "%pfwP: 'reg' property is out of range.\n", + led_node); + fwnode_handle_put(led_node); + return -EINVAL; + } led->mc_cdev.subled_info[subled].color_index = color_index; led->mc_cdev.subled_info[subled].channel = channel; -- 2.55.0