From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A334C39A05E for ; Mon, 20 Jul 2026 10:32:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784543546; cv=none; b=QhStCnGd0DgSMhQU/MUOyeBPpzdNNuEsWbIBn09JFBqDmcx9UktTPharZRuVbT56yswDfFLqyk+zNwkV7QoqdX1TJBNVrfba5QndTHuatfRRdDTK8SSIicEE63iSIyJsGLKhossnFtp+NhZxu5Qggmi9U02hjW+VPL8vDVv4JU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784543546; c=relaxed/simple; bh=4UVlqGkw1S1+oTRFOkBCr9MCEyTu/Ys3IOW1KIAVgVU=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=NBGo07gjlhPgJMg5+H7kwjT9j51rPNgfFSh91v2HqHYecPGYwLLI1OFd32NhEfcxkmPA5mcUNeDoh6Ze+oEeAc8XouGvotdWRn0H+HAUwU5tXIpHBd7vAN3YIPrsiXQP5Gn3ghg/Af1Qg88ASVaavb97Ll0zHfds4tcL1WxB+o0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Nk70z+hK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nk70z+hK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5C971F000E9; Mon, 20 Jul 2026 10:32:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784543544; bh=cZ4KvFsj7lin1MOwAQcffs7M9qMgzSuLVTIResijBP8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Nk70z+hKnXiY1Z98GcEBTeIbJFgUrROF7nsCkoze+Sj6PwjFIdZPSUGPHm1MOYgfz wtdUYYaJe4z0BSbZvuD2CQ2u6/+z36IPB637igk9czvARPRg9x8jufz+hGU+U+Bh9i U+EfNY38EFBFkHBQ0TDhISyf+5yl65eeHjLHls8CTmGLvo3l417sRCXfw6AN0x7s0Z SU7jWuJncEo188QKWBP5/0mLQWlIgC7gfP1yww1cVf4j3YQsIuzQ2vXkyCYnnAy4Aa yA4O7yrnXxYU268ywoK5r+TWjZSsyvbWpIrtF0FFESd0YBD1WPioYzTSZCj4d0N/17 DSQbEr77kxshQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 2/3] arm64: dts: nuvoton: ma35d1: add USB controllers and dual-port PHY node Reply-To: sashiko-reviews@lists.linux.dev To: "Joey Lu" Cc: olteanv@gmail.com, linux-phy@lists.infradead.org, vkoul@kernel.org, robh@kernel.org, devicetree@vger.kernel.org, neil.armstrong@linaro.org, conor+dt@kernel.org In-Reply-To: <20260720102222.251179-3-a0987203069@gmail.com> References: <20260720102222.251179-1-a0987203069@gmail.com> <20260720102222.251179-3-a0987203069@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 20 Jul 2026 10:32:23 +0000 Message-Id: <20260720103223.E5C971F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The `usb_phy` node is placed inside a `simple-bus` without a `reg` = property, triggering a `simple_bus_reg` dtc warning. -- --- Patch [2]: [PATCH v4 2/3] arm64: dts: nuvoton: ma35d1: add USB controll= ers and dual-port PHY node --- commit cf3aea78de55506203f48556a640406a6dccb9bc Author: Joey Lu arm64: dts: nuvoton: ma35d1: add USB controllers and dual-port PHY node This commit adds the USB subsystem nodes for the MA35D1 SoC, including the DWC2 gadget, EHCI/OHCI hosts, and a dual-port PHY node. It also updates the board files to configure pinctrl and enable the nodes. > diff --git a/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi b/arch/arm64/boot/dt= s/nuvoton/ma35d1.dtsi > index 7228ad4735b5c..5a7a39b1b5143 100644 > --- a/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi > +++ b/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi > @@ -88,6 +88,14 @@ sys: system-management@40460000 { > #reset-cells =3D <1>; > }; > =20 > + usb_phy: usb-phy { [Severity: Low] Does placing this node inside the soc simple-bus without a reg property trigger a simple_bus_reg dtc compiler warning? The Device Tree specification states that children of a simple-bus must represent memory-mapped devices, so nodes without a reg or ranges property usually trigger a warning when placed directly under a simple-bus. > + compatible =3D "nuvoton,ma35d1-usb2-phy"; > + clocks =3D <&clk HUSBH0_GATE>; > + nuvoton,sys =3D <&sys>; > + #phy-cells =3D <1>; > + status =3D "disabled"; > + }; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260720102222.2511= 79-1-a0987203069@gmail.com?part=3D2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 299CCC44515 for ; Mon, 20 Jul 2026 10:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PQQX+g1X9lF99xrbF8uKNCqCdv0KDGmwYPh9lT36HYI=; b=LeSdnA7fEmgWKh +NjZxFBPZKquon46x+PTW0Ln6xOgU0cmJf5UveQ8a9UAl7JsGc9/mMXi9OzkpLSYw81JjxgX8fyaw wJtyrfpQEAviBza2EIvAdLhAC3Yrtq/p4Zo7+NCsUYgv0GDdHWgYAWfG9y8BNO4lItqzYMeV8zTUN zgAQQqHZHd1VjzKpGEwJ3fMODy58Ez6O8MMPC9O+9dkZZ32HlM3/RP7n/lDN6E4jTvY0vMC1UdTaz OLKPzbGtCwuS47nMKyZmNW/qA+P4ygjvl5pqnSj/fq9Cez2MIg6r1sY1mrJ140i0LKA4sj1NV78xE CEOnuUCuWD1X5OGHTrjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wllIP-00000006UZ8-3ZxN; Mon, 20 Jul 2026 10:32:25 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wllIP-00000006UZ0-0p3t for linux-phy@lists.infradead.org; Mon, 20 Jul 2026 10:32:25 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id A051F60254; Mon, 20 Jul 2026 10:32:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5C971F000E9; Mon, 20 Jul 2026 10:32:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784543544; bh=cZ4KvFsj7lin1MOwAQcffs7M9qMgzSuLVTIResijBP8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Nk70z+hKnXiY1Z98GcEBTeIbJFgUrROF7nsCkoze+Sj6PwjFIdZPSUGPHm1MOYgfz wtdUYYaJe4z0BSbZvuD2CQ2u6/+z36IPB637igk9czvARPRg9x8jufz+hGU+U+Bh9i U+EfNY38EFBFkHBQ0TDhISyf+5yl65eeHjLHls8CTmGLvo3l417sRCXfw6AN0x7s0Z SU7jWuJncEo188QKWBP5/0mLQWlIgC7gfP1yww1cVf4j3YQsIuzQ2vXkyCYnnAy4Aa yA4O7yrnXxYU268ywoK5r+TWjZSsyvbWpIrtF0FFESd0YBD1WPioYzTSZCj4d0N/17 DSQbEr77kxshQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 2/3] arm64: dts: nuvoton: ma35d1: add USB controllers and dual-port PHY node To: "Joey Lu" Cc: olteanv@gmail.com, linux-phy@lists.infradead.org, vkoul@kernel.org, robh@kernel.org, devicetree@vger.kernel.org, neil.armstrong@linaro.org, conor+dt@kernel.org In-Reply-To: <20260720102222.251179-3-a0987203069@gmail.com> References: <20260720102222.251179-1-a0987203069@gmail.com> <20260720102222.251179-3-a0987203069@gmail.com> Date: Mon, 20 Jul 2026 10:32:23 +0000 Message-Id: <20260720103223.E5C971F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gVGhlIGB1c2JfcGh5YCBu b2RlIGlzIHBsYWNlZCBpbnNpZGUgYSBgc2ltcGxlLWJ1c2Agd2l0aG91dCBhIGByZWdgIHByb3Bl cnR5LCB0cmlnZ2VyaW5nIGEgYHNpbXBsZV9idXNfcmVnYCBkdGMgd2FybmluZy4KLS0KCi0tLSBQ YXRjaCBbMl06IFtQQVRDSCB2NCAyLzNdIGFybTY0OiBkdHM6IG51dm90b246IG1hMzVkMTogYWRk IFVTQiBjb250cm9sbGVycyBhbmQgZHVhbC1wb3J0IFBIWSBub2RlIC0tLQpjb21taXQgY2YzYWVh NzhkZTU1NTA2MjAzZjQ4NTU2YTY0MDQwNmE2ZGNjYjliYwpBdXRob3I6IEpvZXkgTHUgPGEwOTg3 MjAzMDY5QGdtYWlsLmNvbT4KCmFybTY0OiBkdHM6IG51dm90b246IG1hMzVkMTogYWRkIFVTQiBj b250cm9sbGVycyBhbmQgZHVhbC1wb3J0IFBIWSBub2RlCgpUaGlzIGNvbW1pdCBhZGRzIHRoZSBV U0Igc3Vic3lzdGVtIG5vZGVzIGZvciB0aGUgTUEzNUQxIFNvQywgaW5jbHVkaW5nIHRoZQpEV0My IGdhZGdldCwgRUhDSS9PSENJIGhvc3RzLCBhbmQgYSBkdWFsLXBvcnQgUEhZIG5vZGUuIEl0IGFs c28gdXBkYXRlcwp0aGUgYm9hcmQgZmlsZXMgdG8gY29uZmlndXJlIHBpbmN0cmwgYW5kIGVuYWJs ZSB0aGUgbm9kZXMuCgo+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL251dm90b24v bWEzNWQxLmR0c2kgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL251dm90b24vbWEzNWQxLmR0c2kKPiBp bmRleCA3MjI4YWQ0NzM1YjVjLi41YTdhMzliMWI1MTQzIDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJt NjQvYm9vdC9kdHMvbnV2b3Rvbi9tYTM1ZDEuZHRzaQo+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9k dHMvbnV2b3Rvbi9tYTM1ZDEuZHRzaQo+IEBAIC04OCw2ICs4OCwxNCBAQCBzeXM6IHN5c3RlbS1t YW5hZ2VtZW50QDQwNDYwMDAwIHsKPiAgCQkJI3Jlc2V0LWNlbGxzID0gPDE+Owo+ICAJCX07Cj4g IAo+ICsJCXVzYl9waHk6IHVzYi1waHkgewoKW1NldmVyaXR5OiBMb3ddCkRvZXMgcGxhY2luZyB0 aGlzIG5vZGUgaW5zaWRlIHRoZSBzb2Mgc2ltcGxlLWJ1cyB3aXRob3V0IGEgcmVnIHByb3BlcnR5 CnRyaWdnZXIgYSBzaW1wbGVfYnVzX3JlZyBkdGMgY29tcGlsZXIgd2FybmluZz8KClRoZSBEZXZp Y2UgVHJlZSBzcGVjaWZpY2F0aW9uIHN0YXRlcyB0aGF0IGNoaWxkcmVuIG9mIGEgc2ltcGxlLWJ1 cyBtdXN0CnJlcHJlc2VudCBtZW1vcnktbWFwcGVkIGRldmljZXMsIHNvIG5vZGVzIHdpdGhvdXQg YSByZWcgb3IgcmFuZ2VzIHByb3BlcnR5CnVzdWFsbHkgdHJpZ2dlciBhIHdhcm5pbmcgd2hlbiBw bGFjZWQgZGlyZWN0bHkgdW5kZXIgYSBzaW1wbGUtYnVzLgoKPiArCQkJY29tcGF0aWJsZSA9ICJu dXZvdG9uLG1hMzVkMS11c2IyLXBoeSI7Cj4gKwkJCWNsb2NrcyA9IDwmY2xrIEhVU0JIMF9HQVRF PjsKPiArCQkJbnV2b3RvbixzeXMgPSA8JnN5cz47Cj4gKwkJCSNwaHktY2VsbHMgPSA8MT47Cj4g KwkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gKwkJfTsKCi0tIApTYXNoaWtvIEFJIHJldmlldyDC tyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA3MjAxMDIyMjIuMjUxMTc5LTEt YTA5ODcyMDMwNjlAZ21haWwuY29tP3BhcnQ9MgoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QK bGludXgtcGh5QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtcGh5Cg==