From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 597FD39902B for ; Mon, 20 Jul 2026 10:37:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784543866; cv=none; b=f1nomI2KLJaTTunFdrV/XzoV4EiRQGSE586CB8Di9jL4VqZAzU1Fxgnlu2U0Ay2bbrMKZ10ZyLKyb6CP/0SK05PXso6plpIq8Cl9ZPhbSCSNQW0VpW9COtGvnO9WhhwMNVtdaNA0ZaQ0kBqM4ImXOOqKeaYmCrLaArSyd5Lq/rs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784543866; c=relaxed/simple; bh=5zXzbrMwUejUbMzW5JpHO5ucJIzu4vBKsITMaMIt9rg=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=jLhXakD1eBatMB5zYg4boc/UAz0SzelosetdeAuCiGhpIu5CAyi/c0eoHG+A1XayVSOUduuhBqCKFHZUWebnnrNZZzFjv5qFjzzGjbIK0NhrAJdhXGIoS/CLUP5tgw6t9Q+fOBweNKxfx/PTVd/WQK7XZ03K3vHmsm+BZgQCGoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EMWwmDeB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EMWwmDeB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71DE21F000E9; Mon, 20 Jul 2026 10:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784543864; bh=5zXzbrMwUejUbMzW5JpHO5ucJIzu4vBKsITMaMIt9rg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=EMWwmDeBapJDjjr0gD89d322Z5Hg/A/xku0FPNHeflWr9wFlugzUHET7wa2RYRcAV tNO+9TgsFBy4Zh2xYJIDOBPrLQKQZVwvgjrJa3j7B57d0RBuKgi1IPB/rilh6zGLmQ LQi08aUbU/SaeVAhR6RH+F4P6ZAHW7LjoNJXBnqafHunobHMD2j55ZEFB4KkcmGrbB DxMolyKKcc53E3aZsmxhm2b/HQy78y1HX+08J+pQzvUWCMIhySGUFTwJIu4BiDMjRB lMtao9JCEbeMvcrkoy248a1SvT67b09WY0o1wt2HL33nluVza1sPuspPMiB7b2otQg hVzQIJYYxdAQQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 3/3] phy: nuvoton: phy-ma35d1-usb2: extend to dual-port with OTG support Reply-To: sashiko-reviews@lists.linux.dev To: "Joey Lu" Cc: olteanv@gmail.com, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, vkoul@kernel.org In-Reply-To: <20260720102222.251179-4-a0987203069@gmail.com> References: <20260720102222.251179-1-a0987203069@gmail.com> <20260720102222.251179-4-a0987203069@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 20 Jul 2026 10:37:43 +0000 Message-Id: <20260720103744.71DE21F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] The driver fails to clear the MISCFCR0_UHOVRCURH hardware bit when= the `nuvoton,oc-active-high` device tree property is absent, inheriting po= tentially incorrect bootloader state. - [Medium] The driver ignores the return value of regmap_read(), potentiall= y evaluating uninitialized stack memory if the read fails. -- --- Patch [3]: [PATCH v4 3/3] phy: nuvoton: phy-ma35d1-usb2: extend to dual= -port with OTG support --- Note: The format of this review is altered due to strict recitation restric= tions. Instead of inline patch quoting, a free-form summary of the findings= is provided below. Commit: 678e65678c8fb5e2363eb1d51e7a9a2159ca8dd9 Author: Joey Lu Subject: phy: nuvoton: phy-ma35d1-usb2: extend to dual-port with OTG support This commit extends the driver to manage both USB ports and updates the init polling logic to handle host-mode and device-mode clock stability. It also registers a read-only USB role switch and adds support for the rcalcode and oc-active-high device tree properties. [Severity: Medium] In ma35_usb_phy_init() and ma35_role_sw_get(), the return value of regmap_read() is not checked before evaluating the 'val' stack variable. If the register read fails, might the driver evaluate uninitialized memory, causing it to return an unpredictable USB role or falsely bypass the PHY initialization? [Severity: High] In ma35_usb_phy_probe(), the driver sets the MISCFCR0_UHOVRCURH bit if the "nuvoton,oc-active-high" property is present, but lacks an else path to cle= ar it if the property is absent. Does this allow the hardware to incorrectly inherit an inverted over-current polarity from the bootloader or a prior kernel instance? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260720102222.2511= 79-1-a0987203069@gmail.com?part=3D3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FAE0C44515 for ; Mon, 20 Jul 2026 10:37:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ctmM1AdAgrlI1P8sKqU7DbsMjLvSFdA4XHQ5zEBHKxw=; b=dlQLoY0igrk0AS hvAeEo8Us6bQNdoq0RSSkIaDT+MvCQe1pyy9y7JL0GVLEHlbJ7vLKTei+rmB12dKD1HZukxZCGy9B fwOdgnu8Qb4JhMj2aDR2afJjavp66GSQ0ujZS1ZTgn1wOaoe1UuZqb7oFBY2UKJW2PbOFyAu8LRla aTef6fS15Yp+kbd3ofxv8JWSt2T4F1sIHdS4/oaNTZSEAH6a0dr89h9T2h+JDqmdgO1FqfDxR1BbO XEu7m8PBLm/B+vlE5SyUVIzgcCbpHXeEyGkOJqt1swzV094nuyc2TwH1S1xzOZHgEdjIAO6ie7MsX FnbY6ncKo1665Wssx4hA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wllNa-00000006VMX-1AlI; Mon, 20 Jul 2026 10:37:46 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wllNZ-00000006VMI-16tq for linux-phy@lists.infradead.org; Mon, 20 Jul 2026 10:37:45 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id F383540602; Mon, 20 Jul 2026 10:37:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71DE21F000E9; Mon, 20 Jul 2026 10:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784543864; bh=5zXzbrMwUejUbMzW5JpHO5ucJIzu4vBKsITMaMIt9rg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=EMWwmDeBapJDjjr0gD89d322Z5Hg/A/xku0FPNHeflWr9wFlugzUHET7wa2RYRcAV tNO+9TgsFBy4Zh2xYJIDOBPrLQKQZVwvgjrJa3j7B57d0RBuKgi1IPB/rilh6zGLmQ LQi08aUbU/SaeVAhR6RH+F4P6ZAHW7LjoNJXBnqafHunobHMD2j55ZEFB4KkcmGrbB DxMolyKKcc53E3aZsmxhm2b/HQy78y1HX+08J+pQzvUWCMIhySGUFTwJIu4BiDMjRB lMtao9JCEbeMvcrkoy248a1SvT67b09WY0o1wt2HL33nluVza1sPuspPMiB7b2otQg hVzQIJYYxdAQQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 3/3] phy: nuvoton: phy-ma35d1-usb2: extend to dual-port with OTG support To: "Joey Lu" Cc: olteanv@gmail.com, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, vkoul@kernel.org In-Reply-To: <20260720102222.251179-4-a0987203069@gmail.com> References: <20260720102222.251179-1-a0987203069@gmail.com> <20260720102222.251179-4-a0987203069@gmail.com> Date: Mon, 20 Jul 2026 10:37:43 +0000 Message-Id: <20260720103744.71DE21F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIFRoZSBkcml2ZXIgZmFp bHMgdG8gY2xlYXIgdGhlIE1JU0NGQ1IwX1VIT1ZSQ1VSSCBoYXJkd2FyZSBiaXQgd2hlbiB0aGUg YG51dm90b24sb2MtYWN0aXZlLWhpZ2hgIGRldmljZSB0cmVlIHByb3BlcnR5IGlzIGFic2VudCwg aW5oZXJpdGluZyBwb3RlbnRpYWxseSBpbmNvcnJlY3QgYm9vdGxvYWRlciBzdGF0ZS4KLSBbTWVk aXVtXSBUaGUgZHJpdmVyIGlnbm9yZXMgdGhlIHJldHVybiB2YWx1ZSBvZiByZWdtYXBfcmVhZCgp LCBwb3RlbnRpYWxseSBldmFsdWF0aW5nIHVuaW5pdGlhbGl6ZWQgc3RhY2sgbWVtb3J5IGlmIHRo ZSByZWFkIGZhaWxzLgotLQoKLS0tIFBhdGNoIFszXTogW1BBVENIIHY0IDMvM10gcGh5OiBudXZv dG9uOiBwaHktbWEzNWQxLXVzYjI6IGV4dGVuZCB0byBkdWFsLXBvcnQgd2l0aCBPVEcgc3VwcG9y dCAtLS0KTm90ZTogVGhlIGZvcm1hdCBvZiB0aGlzIHJldmlldyBpcyBhbHRlcmVkIGR1ZSB0byBz dHJpY3QgcmVjaXRhdGlvbiByZXN0cmljdGlvbnMuIEluc3RlYWQgb2YgaW5saW5lIHBhdGNoIHF1 b3RpbmcsIGEgZnJlZS1mb3JtIHN1bW1hcnkgb2YgdGhlIGZpbmRpbmdzIGlzIHByb3ZpZGVkIGJl bG93LgoKQ29tbWl0OiA2NzhlNjU2NzhjOGZiNWUyMzYzZWIxZDUxZTdhOWEyMTU5Y2E4ZGQ5CkF1 dGhvcjogSm9leSBMdSA8YTA5ODcyMDMwNjlAZ21haWwuY29tPgpTdWJqZWN0OiBwaHk6IG51dm90 b246IHBoeS1tYTM1ZDEtdXNiMjogZXh0ZW5kIHRvIGR1YWwtcG9ydCB3aXRoIE9URyBzdXBwb3J0 CgpUaGlzIGNvbW1pdCBleHRlbmRzIHRoZSBkcml2ZXIgdG8gbWFuYWdlIGJvdGggVVNCIHBvcnRz IGFuZCB1cGRhdGVzIHRoZSBpbml0CnBvbGxpbmcgbG9naWMgdG8gaGFuZGxlIGhvc3QtbW9kZSBh bmQgZGV2aWNlLW1vZGUgY2xvY2sgc3RhYmlsaXR5LiBJdCBhbHNvCnJlZ2lzdGVycyBhIHJlYWQt b25seSBVU0Igcm9sZSBzd2l0Y2ggYW5kIGFkZHMgc3VwcG9ydCBmb3IgdGhlIHJjYWxjb2RlIGFu ZApvYy1hY3RpdmUtaGlnaCBkZXZpY2UgdHJlZSBwcm9wZXJ0aWVzLgoKW1NldmVyaXR5OiBNZWRp dW1dCkluIG1hMzVfdXNiX3BoeV9pbml0KCkgYW5kIG1hMzVfcm9sZV9zd19nZXQoKSwgdGhlIHJl dHVybiB2YWx1ZSBvZgpyZWdtYXBfcmVhZCgpIGlzIG5vdCBjaGVja2VkIGJlZm9yZSBldmFsdWF0 aW5nIHRoZSAndmFsJyBzdGFjayB2YXJpYWJsZS4gSWYKdGhlIHJlZ2lzdGVyIHJlYWQgZmFpbHMs IG1pZ2h0IHRoZSBkcml2ZXIgZXZhbHVhdGUgdW5pbml0aWFsaXplZCBtZW1vcnksCmNhdXNpbmcg aXQgdG8gcmV0dXJuIGFuIHVucHJlZGljdGFibGUgVVNCIHJvbGUgb3IgZmFsc2VseSBieXBhc3Mg dGhlIFBIWQppbml0aWFsaXphdGlvbj8KCltTZXZlcml0eTogSGlnaF0KSW4gbWEzNV91c2JfcGh5 X3Byb2JlKCksIHRoZSBkcml2ZXIgc2V0cyB0aGUgTUlTQ0ZDUjBfVUhPVlJDVVJIIGJpdCBpZiB0 aGUKIm51dm90b24sb2MtYWN0aXZlLWhpZ2giIHByb3BlcnR5IGlzIHByZXNlbnQsIGJ1dCBsYWNr cyBhbiBlbHNlIHBhdGggdG8gY2xlYXIKaXQgaWYgdGhlIHByb3BlcnR5IGlzIGFic2VudC4gRG9l cyB0aGlzIGFsbG93IHRoZSBoYXJkd2FyZSB0byBpbmNvcnJlY3RseQppbmhlcml0IGFuIGludmVy dGVkIG92ZXItY3VycmVudCBwb2xhcml0eSBmcm9tIHRoZSBib290bG9hZGVyIG9yIGEgcHJpb3IK a2VybmVsIGluc3RhbmNlPwoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlr by5kZXYvIy9wYXRjaHNldC8yMDI2MDcyMDEwMjIyMi4yNTExNzktMS1hMDk4NzIwMzA2OUBnbWFp bC5jb20/cGFydD0zCgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1waHkK