Re: [LTP] fsconfig04: Check FSCONFIG_SET_PATH

[linuxtestproject.agent@gmail.com]

Hi Wei,

On Mon, Jul 20 2026, Wei Gao wrote:
> fsconfig04: Check FSCONFIG_SET_PATH

> + * [Algorithm]
> + *
> + * Case acquires three loop devices (dev0, dev1, dev2).
> + * It formats dev1 and dev2 as external journal devices using the
> + * "-O journal_dev" option and assigns them the same UUID.
> + *
> + * Then, it formats dev0 (the main filesystem) multiple times,
> + * first associating it with dev1, then dev2, and finally back to
> + * dev1 again as an external journal using the "-J device=" option.
> + *
> + * Next, it calls fsopen() and configures the filesystem using
> + * fsconfig(FSCONFIG_SET_STRING, "source", dev0) and
> + * fsconfig(FSCONFIG_SET_PATH, "journal_path", dev2) to dynamically
> + * alter the external journal device.
> + *
> + * After applying FSCONFIG_CMD_CREATE, it verifies using tune2fs
> + * if the external journal device of dev0 has been successfully
> + * and dynamically switched to dev2.

The [Algorithm] section must be a bulleted list using '-', not prose
paragraphs. See documentation.md Section 4.

Something like:

 * [Algorithm]
 *
 * - Acquire three loop devices (dev0 from framework, dev1, dev2).
 * - Format dev1 and dev2 as external journal devices with the same UUID
 *   ("-O journal_dev -U <uuid>").
 * - Format dev0 three times to cycle journal associations:
 *   dev1 -> dev2 -> dev1, so both journal superblocks are consistent.
 * - Open dev0 via fsopen(2) and set the source and journal_path using
 *   fsconfig(FSCONFIG_SET_STRING) and fsconfig(FSCONFIG_SET_PATH).
 * - Apply FSCONFIG_CMD_CREATE and verify with tune2fs that dev0's
 *   journal device is now dev2.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp