From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A67AEC4452A for ; Mon, 20 Jul 2026 15:08:00 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wlpad-00022z-4n; Mon, 20 Jul 2026 11:07:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wlpaa-000224-Hu for qemu-devel@nongnu.org; Mon, 20 Jul 2026 11:07:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wlpaY-0007fn-Qa for qemu-devel@nongnu.org; Mon, 20 Jul 2026 11:07:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784560045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sd8/67oEpT5KaRl5lGevBokwnlHKGi+IbMM5DTzFikY=; b=cCbh1bmrgsroXf/N77YCUgsqhoLEuA0N/qzTl1pojxEQUHjOeuu7Lfi/ZTu2+BDaCAreK4 ZHam3kinDhbsuwugRbFnv4TuHhSIQiBI1onI+zB9N3I9A1ka8KcYT+AoL1P14fzljRG4ZM daptOx6RopsOIrylHT9UKKIgnvDutGI= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-LHepDEnRPlGHWsNGPysOEw-1; Mon, 20 Jul 2026 11:07:22 -0400 X-MC-Unique: LHepDEnRPlGHWsNGPysOEw-1 X-Mimecast-MFC-AGG-ID: LHepDEnRPlGHWsNGPysOEw_1784560039 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6E8E41955EBB; Mon, 20 Jul 2026 15:07:18 +0000 (UTC) Received: from localhost (unknown [10.2.16.104]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B18391956094; Mon, 20 Jul 2026 15:07:17 +0000 (UTC) Date: Mon, 20 Jul 2026 11:07:14 -0400 From: Stefan Hajnoczi To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org, Elena Ufimtseva , Jagannathan Raman , Gustavo Romero , Alex =?iso-8859-1?Q?Benn=E9e?= , Pierrick Bouvier Subject: Re: [PATCH 1/6] hw/remote/machine.c: Mark x-remote machine as OK for AArch64 and AArch32 Message-ID: <20260720150714.GA56010@fedora> References: <20260507194728.2034696-1-peter.maydell@linaro.org> <20260507194728.2034696-2-peter.maydell@linaro.org> <1bcf5fd5-b2ee-4adf-ad16-bac12050baa3@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="O69UMzIOjA4d63mA" Content-Disposition: inline In-Reply-To: <1bcf5fd5-b2ee-4adf-ad16-bac12050baa3@oss.qualcomm.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: permerror client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --O69UMzIOjA4d63mA Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 20, 2026 at 02:39:06PM +0200, Philippe Mathieu-Daud=E9 wrote: > +Stefan >=20 > On 7/5/26 21:47, Peter Maydell wrote: > > When we updated Arm and AArch64 board types to mark them for the > > target_machine_typename() filter, we forgot about the "x-remote" > > machine type, which meant that it disappeared from the set of board > > types exposed on the qemu-system-arm and qemu-system-aarch64 > > binaries. We didn't notice this, because although we have a > > functional test for it, it requires the KVM accelerator and we don't >=20 > I don't remember why it requires KVM. >=20 > $ git grep -i kvm hw/remote/ > hw/remote/Kconfig:3: depends on PCI && PCI_EXPRESS && KVM > hw/remote/proxy.c:36: kvm_irqchip_remove_irqfd_notifier_gsi(kvm_state, > &dev->intr, dev->virq); > hw/remote/proxy.c:45: kvm_irqchip_add_irqfd_notifier_gsi(kvm_state, > &dev->intr, >=20 > I suppose these 2 calls should be replaced by generic equivalents: > - accel_irqchip_remove_irqfd_notifier_gsi() > - accel_irqchip_add_irqfd_notifier_gsi() The generic functions call into KVM or MSHV or return -ENOSYS if neither are available in. While QEMU will compile, x-remote won't work at runtime. If someone wants to make x-remote actually work at runtime without KVM then that should be possible too: set up an EventNotifier that handles interrupt requests from the remote process and invokes QEMU's internal irq APIs to inject them into the guest. There may already be code to do that somewhere or, if not, it shouldn't be hard to write. Stefan --O69UMzIOjA4d63mA Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmpeOaIACgkQnKSrs4Gr c8gElQf/UA6VuWfY/VesbaaxJ8o8BRSqG7QQ4TeCmNuOu9RvgIn0OL7OnBBtDgCf /C4pYxhZHM+fpWwsHCoV/UlXuXf+RiZo68bEjdkCEq7CcKlNVYU4eXON5lASF2+x tn+LhuojYb6ldnLaqYN9K+JTH5DLgoJ8FrFO1x4tJzDcYTWwYutzDe5Tf0KKRv8b Fd8Q5qfzJf7Ytt9jFrhFFkvnIJ3ZMqhG16bWBpSBXVn0aNuiaXx81QgkkD7geakw s8r8O9BCT3CZaPBILnGy5USCBqxsPBAZqTKFzlpnhEuoCvlYf8s3feo8lMtiVvEe /tYYrt+VtDGLs+3VfiBQD3cDsmcUzA== =Wpb1 -----END PGP SIGNATURE----- --O69UMzIOjA4d63mA--