From: Jakub Kicinski <kuba@kernel.org>
To: Fan Wu <12321260@zju.edu.cn>
Cc: Simon Horman <horms@kernel.org>, Fan Wu <fanwu01@zju.edu.cn>,
netdev@vger.kernel.org, shenjian15@huawei.com,
salil.mehta@huawei.com, andrew+netdev@lunn.ch,
"David S . Miller" <davem@davemloft.net>,
edumazet@google.com, pabeni@redhat.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] net: hip04: quiesce tx coalesce timer before teardown
Date: Mon, 20 Jul 2026 16:32:39 -0700 [thread overview]
Message-ID: <20260720163239.3d8b9f88@kernel.org> (raw)
In-Reply-To: <4631C8F9-598D-4114-AD88-BEC5D8617BB6@zju.edu.cn>
On Sat, 11 Jul 2026 13:34:24 +0800 Fan Wu wrote:
> Thanks for the v1 review. The updated patch fixes the PHY teardown ordering
> and IRQ lifetime issues: hip04_remove() unregisters the netdev, running
> .ndo_stop and phy_stop(), before phy_disconnect(), and frees the devm-managed
> IRQ before free_netdev().
>
> The remaining NULL tx_desc cleanup in hip04_free_ring() and RX refill
> failure paths are independent pre-existing error-path issues. I will address them
> in separate patches rather than expanding this teardown fix. In particular, the
> RX fix must preserve the old descriptor mapping until a replacement buffer is
> successfully allocated and mapped.
If the patch matters you need to repost it, it wasn't processed in time
prev parent reply other threads:[~2026-07-20 23:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 5:01 [PATCH] net: hip04: quiesce tx coalesce timer before teardown Fan Wu
2026-07-09 12:43 ` Simon Horman
2026-07-11 5:34 ` Fan Wu
2026-07-20 23:32 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720163239.3d8b9f88@kernel.org \
--to=kuba@kernel.org \
--cc=12321260@zju.edu.cn \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fanwu01@zju.edu.cn \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.