From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A0B734F24C for ; Mon, 20 Jul 2026 17:55:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.69 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784570123; cv=none; b=QW+970Incp/EUIuTneC9zPJJwf9YrTgCwU8FAAY708UdlQuxm74X1OM+d2mGTnD6c5OmTmP1g23KUSqXg8TiHp31aRalbf8XKDLuoUBOHLpykcEILRmgZ2Iir1Dtiw9lSXIkKct3D8dKW1eY1NF2A1G+YSegIxno9Z8dW5HNWDc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784570123; c=relaxed/simple; bh=eZ+wX04/zXyvzuyqM8J6sRBfyy1fmlZivY1CAvP+j8s=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=ukyEu9PgCcglU+oLBne0Gd/mWA6/em5SkZCXsUdJrWkmyHgoDE+hGHVE3kn7c6/8EopDXAFwxULx+9QzqN7LbY3ybo4cJVvNzqgGlIBCmH8edhOF1VfLm206FoCU9v9VzvGqTvPb5m9ZYNgJNqrwW8bjIsn2awUjlmjmijP6uQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=PhcK0eeJ; arc=none smtp.client-ip=209.85.216.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PhcK0eeJ" Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38dbf293831so17136682a91.3 for ; Mon, 20 Jul 2026 10:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784570114; x=1785174914; darn=vger.kernel.org; h=content-type:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Hh+7obFCkE+FCg9itWlLHX9/KW1VGqY0DnXombaQNIU=; b=PhcK0eeJ8uKl7KuEHOpaS7x8ugPjxajY3qjkg8ec9nQA106azZafDg81M4/Jk1Ub/F nAZBfRhuvUBRbti4SwdAum1ZvnIkJVamTg2AVUEJ5CRvI4twqkD2RiLOCdCKnfbS+jGy 5/D31wx9sn4bKWH6aZmDnbXovL0MXsxYzhVsFnLcS0L83orJZgGS/N2PCtvug9z8FPhd oLk32Jwyn2S9R+u+8b6/zWIFs/oGrgiMAEnYDIvDvhLNVBjP6Dttukv1rTmUkSWECife ImoboMibh0RYqsiqaMPX2gCmabo7Eg0XEyX7/Dov3f/oK2Gw/q6J/pL4A3ePKyIhR7iZ JTCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784570114; x=1785174914; h=content-type:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Hh+7obFCkE+FCg9itWlLHX9/KW1VGqY0DnXombaQNIU=; b=KEXDyznzwUHALpRCWZpULynY3CJehZQJykGSb4c/rxqQWz7b7PaGZ/x+a/E5CTYbwg 8ENowNAEUnpSkgwKTyPm4EIXhf+pp0/9TKyQi6pIgjf5LVunmq4zXndKebzQKBm0ml/J Twl/wEyDrULeJGvqaah8FXWJcH3/DE/9JYVE2BufNUbkGqd/09uZBNH4FEdVCqo19g6t k2iJ8KTYzv+oPWgiU/Jyxp9g1xum/yMV9TDQ4jzaqfUtbix9zD3+eWyNhW3kWGHk49jp 73Sp/cgvEGiqJJ4slDO02pf3onYmLDfIl6mqXfXIeRqgfi9hvnChrD8WDrOm49VuKsh3 +L8Q== X-Forwarded-Encrypted: i=1; AHgh+Ro+dhrVBGlTSnPkLjC+LzWkCgZmzc193hhYmkb7fyidE01IrNTNFLnD9574RR6Pmm642PPslynwUlV9fYw=@vger.kernel.org X-Gm-Message-State: AOJu0Yzs6UZL3hW9lQFOLhTUT2QpFTc7xlE3/4qajhUbMk4qZ5ezCzuI AWSnuLQRo1XLxnnnYN1YMH2y8uZSZ7Ie7az54bvUJRUTen038xzMs846twQzLz4yy0cYwnQKZlP JaHHh0OP2ag== X-Received: from dled9-n2.prod.google.com ([2002:a05:701b:42c9:20b0:13c:d017:a244]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:3dce:b0:387:e0db:3fad with SMTP id 98e67ed59e1d1-38e4b5d3ec4mr15642504a91.38.1784570113414; Mon, 20 Jul 2026 10:55:13 -0700 (PDT) Date: Mon, 20 Jul 2026 10:54:52 -0700 In-Reply-To: <20260720175455.3645946-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260720175455.3645946-1-irogers@google.com> X-Mailer: git-send-email 2.55.0.229.g6434b31f56-goog Message-ID: <20260720175455.3645946-2-irogers@google.com> Subject: [PATCH v1 1/4] perf find-map: Remove PATH_MAX 128-byte stack array restriction From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Ravi Bangoria , Swapnil Sapkal , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Use getline() to dynamically allocate the required line buffer for maps parsing, guaranteeing bounds safety and preventing buffer overruns. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Ian Rogers --- tools/perf/util/find-map.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/find-map.c b/tools/perf/util/find-map.c index 7b2300588ece..4d740b32814f 100644 --- a/tools/perf/util/find-map.c +++ b/tools/perf/util/find-map.c @@ -1,8 +1,14 @@ // SPDX-License-Identifier: GPL-2.0 +#include +#include +#include + static int find_map(void **start, void **end, const char *name) { FILE *maps; - char line[128]; + char *line = NULL; + size_t len = 0; + ssize_t read_ret; int found = 0; maps = fopen("/proc/self/maps", "r"); @@ -11,7 +17,7 @@ static int find_map(void **start, void **end, const char *name) return -1; } - while (!found && fgets(line, sizeof(line), maps)) { + while (!found && (read_ret = getline(&line, &len, maps)) != -1) { int m = -1; /* We care only about private r-x mappings. */ @@ -25,6 +31,7 @@ static int find_map(void **start, void **end, const char *name) found = 1; } + free(line); fclose(maps); return !found; } -- 2.55.0.229.g6434b31f56-goog