Re: [PATCH] dt-bindings: extcon: ti,extcon-palmas: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree node name in the example uses an underscore (`palmas_usb`), which violates standard DT naming conventions. It should use a hyphen (e.g., `palmas-usb` or a generic name like `usb-comparator`). This change introduces a `dtc` warning (`node_name_chars_strict`) during `make dt_binding_check` that was not present in the original text binding.
--

--- Patch [1]: [PATCH] dt-bindings: extcon: ti,extcon-palmas: Convert to DT schema ---
commit bda055e9092743c0cf88faae7d326b21581d09bb
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: extcon: ti,extcon-palmas: Convert to DT schema
    
This commit converts the Texas Instruments Palmas USB Comparator binding from
the legacy text format to a modern DT schema.

> diff --git a/Documentation/devicetree/bindings/extcon/ti,extcon-palmas.yaml b/Documentation/devicetree/bindings/extcon/ti,extcon-palmas.yaml
> new file mode 100644
> index 0000000000000..0bcd8df79414a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/extcon/ti,extcon-palmas.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    palmas_usb {

[Severity: Low]
Is the underscore in this node name intentional? 

The original text binding used a hyphen (palmas-usb). Using an underscore
violates standard device tree naming conventions and will trigger a dtc 
node_name_chars_strict warning during make dt_binding_check.

Would it be better to stick with the original palmas-usb or use a generic
node name like usb-comparator?

> +        compatible = "ti,palmas-usb-vid";
> +        ti,wakeup;
> +        ti,enable-id-detection;
> +        ti,enable-vbus-detection;
> +        id-gpios = <&palmas_gpio 0 GPIO_ACTIVE_HIGH>;
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-ti-extcon-palmas-v1-1-cd4071f0b9d9@gmail.com?part=1