All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: Use %pe format specifier to print error pointers
Date: Mon, 20 Jul 2026 21:10:20 +0000	[thread overview]
Message-ID: <20260720211020.AF76C1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260720210839.1507406-1-kwilczynski@kernel.org>

> Currently, several files in the PCI tree print error pointers using
> the %ld format specifier together with an explicit PTR_ERR()
> conversion, which prints the numeric errno value.
> 
> Thus, at every affected call site, use the %pe format specifier, which
> exists specifically to print error pointers, and pass the error pointer
> directly.  With CONFIG_SYMBOLIC_ERRNAME enabled, this prints a symbolic
> error name such as -ENOMEM, falling back to the numeric errno value
> otherwise.  As such, the explicit PTR_ERR() conversion is no longer
> needed.
> 
> No functional changes intended.
> 
> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720210839.1507406-1-kwilczynski@kernel.org?part=1


      reply	other threads:[~2026-07-20 21:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20 21:08 [PATCH] PCI: Use %pe format specifier to print error pointers Krzysztof Wilczyński
2026-07-20 21:10 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260720211020.AF76C1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.