From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15610C44529 for ; Tue, 21 Jul 2026 04:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qQTz4/jmo4KNbDEWkA07JY+yXQomfy7bmrrAfdmJ+UE=; b=Dp5zvLieIbgKqp 3NM5fuPP78+EntXO69mNHCNZZNaAjz3G7jol4AyG98uwOOwSJSW36V9UpHtKRsHsBxwULp6y78Kl7 IUESvVxFgae4XqjgQ9caJDkFe4VL8dWbjLnUda9rWMRMW48iU7gEeU04A/z+/I4FjGy4KrBPcf/7U 22f24iOEXD96BeZx4TLk6y9QvXtspBaStfqpeJSX7+lg1+i2hkHfl2/3xGgCqsrtJTfK85bpPQEUM IClcvpEpKjkpCqfpGoqShCAJp719tRa59ftkdhU+vh7yuYZMoCvT/3cn57TR0yHf9Jx/Z2hYsixQd m3j/67KEptdIqkHsgt3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wm23S-00000008NkL-3Dwn; Tue, 21 Jul 2026 04:26:06 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wm23R-00000008Nk6-48ON for linux-i3c@lists.infradead.org; Tue, 21 Jul 2026 04:26:06 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 4449360A61; Tue, 21 Jul 2026 04:26:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87E791F00A3A; Tue, 21 Jul 2026 04:26:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784607965; bh=LAE26sMh6ZrJ8Lvg6zGD83jtaqtfFfO3Z4H0CXF5NvA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=SxxexnG6ImrXdafB/AEmKq2CeRelaaJvkwIj10W/hMUl7rGNWem3TPgN+p1miIc9g x7jFwnJXJXOEX2wGy4MXTKR+pd6ywz4ILsVsKn9uMetGt+EyS6xWkyDAtzQuR92Hsl nzqIlOBuZkWPd39ypaTz8dj+h2WkY8EaEO9z3U0w+53KyLNuihCZS56Qy3kHJT6k3Q jZKQhIF/6pu5/QS0G0z1XrjKUoNhqlMkBoyzhNsxk8PD6SJPICHNoXoQWiCuzJRT2F nP2XDg7qyRrHUgzGdLdNOVW/+7o5a/+jMP4+kxND1enZs3Obh0dT34EG+HV4V7R+fT v20cChD2O94EQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 05/12] i3c: master: Add support for devices without PID To: "Akhil R" Cc: Frank.Li@kernel.org, "Alexandre Belloni" , robh@kernel.org, devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org In-Reply-To: <20260721040805.1696503-6-akhilrajeev@nvidia.com> References: <20260721040805.1696503-1-akhilrajeev@nvidia.com> <20260721040805.1696503-6-akhilrajeev@nvidia.com> Date: Tue, 21 Jul 2026 04:26:04 +0000 Message-Id: <20260721042604.87E791F00A3A@smtp.kernel.org> X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gVGhlIHN0YXRpYyBh ZGRyZXNzIG1hdGNoaW5nIGxvZ2ljIGZvciBkZXZpY2VzIHdpdGhvdXQgYSBQSUQgaW4gYGkzY19t YXN0ZXJfYXR0YWNoX2JvYXJkaW5mb2AgaXMgdW5yZWFjaGFibGUgYW5kIGNvbnRhaW5zIGEgc3Ry dWN0dXJhbGx5IGltcG9zc2libGUgY29uZGl0aW9uLgotIFtNZWRpdW1dIERldmljZXMgcmVxdWly aW5nIGEgUElEIGNhbiBub3cgYmUgcmVnaXN0ZXJlZCB3aXRoIGFuIGludmFsaWQgTWFudWZhY3R1 cmVyIElEIG9mIDAuCi0tCgotLS0gUGF0Y2ggWzVdOiBbUEFUQ0ggdjYgMDUvMTJdIGkzYzogbWFz dGVyOiBBZGQgc3VwcG9ydCBmb3IgZGV2aWNlcyB3aXRob3V0IFBJRCAtLS0KY29tbWl0IDY3MWMz ZmFlNjYwMDJlODc0YTEzMDUxYTljOTU2ZTk5ODdkNzY2NzQKQXV0aG9yOiBBa2hpbCBSIDxha2hp bHJhamVldkBudmlkaWEuY29tPgoKaTNjOiBtYXN0ZXI6IEFkZCBzdXBwb3J0IGZvciBkZXZpY2Vz IHdpdGhvdXQgUElECiAgICAKRGV2aWNlcyB1c2luZyBTRVRBQVNBIGZvciBhZGRyZXNzIGFzc2ln bm1lbnQgYXJlIG5vdCByZXF1aXJlZCB0byBoYXZlCmEgNDgtYml0IFBJRCBhY2NvcmRpbmcgdG8g dGhlIEkzQyBzcGVjaWZpY2F0aW9uLiBBbGxvdyBzdWNoIGRldmljZXMgdG8KcmVnaXN0ZXIgYW5k IHVzZSB0aGUgc3RhdGljIGFkZHJlc3Mgd2hlcmUgUElEIHdhcyByZXF1aXJlZC4KCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvaTNjL21hc3Rlci5jIGIvZHJpdmVycy9pM2MvbWFzdGVyLmMKPiBpbmRl eCBiMThkZGE4OWM0NzM3Li43YjJmODE5YmY0NDM3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvaTNj L21hc3Rlci5jCj4gKysrIGIvZHJpdmVycy9pM2MvbWFzdGVyLmMKClsgLi4uIF0KCj4gQEAgLTIz ODksOCArMjM5OCwxOCBAQCBzdGF0aWMgdm9pZCBpM2NfbWFzdGVyX2F0dGFjaF9ib2FyZGluZm8o c3RydWN0IGkzY19kZXZfZGVzYyAqaTNjZGV2KQo+ICAJc3RydWN0IGkzY19kZXZfYm9hcmRpbmZv ICppM2Nib2FyZGluZm87Cj4gIAo+ICAJbGlzdF9mb3JfZWFjaF9lbnRyeShpM2Nib2FyZGluZm8s ICZtYXN0ZXItPmJvYXJkaW5mby5pM2MsIG5vZGUpIHsKPiAtCQlpZiAoaTNjZGV2LT5pbmZvLnBp ZCAhPSBpM2Nib2FyZGluZm8tPnBpZCkKPiAtCQkJY29udGludWU7Cj4gKwkJLyoKPiArCQkgKiBG b3IgZGV2aWNlcyB3aXRob3V0IFBJRCAoZS5nLiwgU0VUQUFTQSBkZXZpY2VzKSwgbWF0Y2ggYnkK PiArCQkgKiBzdGF0aWMgYWRkcmVzcy4gRm9yIGRldmljZXMgd2l0aCBQSUQsIG1hdGNoIGJ5IFBJ RC4KPiArCQkgKi8KPiArCQlpZiAoaTNjYm9hcmRpbmZvLT5waWQpIHsKPiArCQkJaWYgKGkzY2Rl di0+aW5mby5waWQgIT0gaTNjYm9hcmRpbmZvLT5waWQpCj4gKwkJCQljb250aW51ZTsKPiArCQl9 IGVsc2Ugewo+ICsJCQlpZiAoIWkzY2JvYXJkaW5mby0+c3RhdGljX2FkZHIgfHwKPiArCQkJICAg IGkzY2Rldi0+aW5mby5zdGF0aWNfYWRkciAhPSBpM2Nib2FyZGluZm8tPnN0YXRpY19hZGRyKQo+ ICsJCQkJY29udGludWU7Cj4gKwkJfQoKW1NldmVyaXR5OiBNZWRpdW1dCldpbGwgdGhpcyBzdGF0 aWMgYWRkcmVzcyBtYXRjaGluZyBsb2dpYyBldmVyIGV2YWx1YXRlIHRvIGZhbHNlPwoKU2luY2Ug aTNjX21hc3Rlcl9hdHRhY2hfYm9hcmRpbmZvKCkgaXMgb25seSBjYWxsZWQgZHVyaW5nIHRoZSBk eW5hbWljCmFkZHJlc3MgYXNzaWdubWVudCAoRU5UREFBKSBwaGFzZSwgaTNjZGV2LT5pbmZvLnN0 YXRpY19hZGRyIGlzIGluaGVyZW50bHkgMAppbiB0aGlzIGNvbnRleHQuCgpCZWNhdXNlIGkzY2Jv YXJkaW5mby0+c3RhdGljX2FkZHIgaXMgdmFsaWRhdGVkIHRvIGJlIG5vbi16ZXJvIGF0IGNyZWF0 aW9uLAp0aGUgY29uZGl0aW9uIGkzY2Rldi0+aW5mby5zdGF0aWNfYWRkciAhPSBpM2Nib2FyZGlu Zm8tPnN0YXRpY19hZGRyIHdpbGwKZXZhbHVhdGUgdG8gMCAhPSBub24temVybywgd2hpY2ggaXMg YWx3YXlzIHRydWUuCgpUaGlzIG1lYW5zIHRoZSBsb29wIHdpbGwgYWx3YXlzIGNvbnRpbnVlLCBt YWtpbmcgdGhpcyBicmFuY2ggZWZmZWN0aXZlbHkKZGVhZCBjb2RlIHRoYXQgZmFpbHMgdG8gcGVy Zm9ybSB0aGUgaW50ZW5kZWQgbWF0Y2hpbmcuCgo+ICAKPiAgCQlpM2NkZXYtPmJvYXJkaW5mbyA9 IGkzY2JvYXJkaW5mbzsKPiAgCQlpM2NkZXYtPmluZm8uc3RhdGljX2FkZHIgPSBpM2Nib2FyZGlu Zm8tPnN0YXRpY19hZGRyOwoKWyAuLi4gXQoKPiBAQCAtMjg0OCw5ICsyODcxLDE2IEBAIGkzY19t YXN0ZXJfYWRkX2kzY19ib2FyZGluZm8oc3RydWN0IGkzY19tYXN0ZXJfY29udHJvbGxlciAqbWFz dGVyLAo+ICAKPiAgCWJvYXJkaW5mby0+cGlkID0gKCh1NjQpcmVnWzFdIDw8IDMyKSB8IHJlZ1sy XTsKPiAgCj4gLQlpZiAoKGJvYXJkaW5mby0+cGlkICYgR0VOTUFTS19VTEwoNjMsIDQ4KSkgfHwK PiAtCSAgICBJM0NfUElEX1JORF9MT1dFUl8zMkJJVFMoYm9hcmRpbmZvLT5waWQpKQo+IC0JCXJl dHVybiAtRUlOVkFMOwo+ICsJLyogRm9yIFNFVEFBU0EgZGV2aWNlcywgdmFsaWRhdGUgdGhlIHN0 YXRpYyBhZGRyZXNzIGluc3RlYWQgb2YgUElEICovCj4gKwlpZiAoYm9hcmRpbmZvLT5zdGF0aWNf YWRkcl9tZXRob2QgJiBJM0NfQUREUl9NRVRIT0RfU0VUQUFTQSkgewo+ICsJCWlmICghYm9hcmRp bmZvLT5zdGF0aWNfYWRkcikKPiArCQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwl9IGVsc2Ugewo+ICsJ CWlmICghYm9hcmRpbmZvLT5waWQgfHwKPiArCQkgICAgKGJvYXJkaW5mby0+cGlkICYgR0VOTUFT S19VTEwoNjMsIDQ4KSkgfHwKPiArCQkgICAgSTNDX1BJRF9STkRfTE9XRVJfMzJCSVRTKGJvYXJk aW5mby0+cGlkKSkKPiArCQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwl9Cj4gIAo+ICAJYm9hcmRpbmZv LT5pbml0X2R5bl9hZGRyID0gaW5pdF9keW5fYWRkcjsKPiAgCWJvYXJkaW5mby0+Zndub2RlID0g Zndub2RlX2hhbmRsZV9nZXQoZndub2RlKTsKPiBAQCAtMjg3MywxMCArMjkwMywxMCBAQCBzdGF0 aWMgaW50IGkzY19tYXN0ZXJfYWRkX29mX2RldihzdHJ1Y3QgaTNjX21hc3Rlcl9jb250cm9sbGVy ICptYXN0ZXIsCj4gIAkJcmV0dXJuIHJldDsKPiAgCj4gIAkvKgo+IC0JICogVGhlIG1hbnVmYWN0 dXJlciBJRCBjYW4ndCBiZSAwLiBJZiByZWdbMV0gPT0gMCB0aGF0IG1lYW5zIHdlJ3JlCj4gLQkg KiBkZWFsaW5nIHdpdGggYW4gSTJDIGRldmljZS4KPiArCSAqIEkzQyBkZXZpY2Ugc2hvdWxkIGhh dmUgZWl0aGVyIHRoZSBtYW51ZmFjdHVyZXIgSUQgc3BlY2lmaWVkIG9yIHRoZQo+ICsJICogYWRk cmVzcyBkaXNjb3ZlcnkgbWV0aG9kIHNwZWNpZmllZC4gRWxzZSB0cmVhdCBpdCBhcyBhbiBJMkMg ZGV2aWNlLgo+ICAJICovCj4gLQlpZiAoIXJlZ1sxXSkKPiArCWlmICghcmVnWzFdICYmICFmd25v ZGVfcHJvcGVydHlfcHJlc2VudChmd25vZGUsICJtaXBpLWkzYy1zdGF0aWMtbWV0aG9kIikpCj4g IAkJcmV0ID0gaTNjX21hc3Rlcl9hZGRfaTJjX2JvYXJkaW5mbyhtYXN0ZXIsIGZ3bm9kZSwgcmVn KTsKPiAgCWVsc2UKPiAgCQlyZXQgPSBpM2NfbWFzdGVyX2FkZF9pM2NfYm9hcmRpbmZvKG1hc3Rl ciwgZndub2RlLCByZWcpOwoKW1NldmVyaXR5OiBNZWRpdW1dCkNvdWxkIHRoaXMgY2hhbmdlIGFs bG93IGRldmljZXMgcmVxdWlyaW5nIGEgUElEIHRvIGJlIHJlZ2lzdGVyZWQgd2l0aCBhbgppbnZh bGlkIE1hbnVmYWN0dXJlciBJRCBvZiAwPwoKQnkgcGVybWl0dGluZyByZWdbMV0gPT0gMCB3aGVu IG1pcGktaTNjLXN0YXRpYy1tZXRob2QgaXMgcHJlc2VudCBpbgppM2NfbWFzdGVyX2FkZF9vZl9k ZXYoKSwgaXQgYXBwZWFycyB3ZSBjYW4gYnlwYXNzIHRoZSBzdHJpY3QgTWFudWZhY3R1cmVyIElE CnZhbGlkYXRpb24gaW4gaTNjX21hc3Rlcl9hZGRfaTNjX2JvYXJkaW5mbygpLgoKSWYgdGhlIG1l dGhvZCBpcyBTRVREQVNBLCB3aGljaCBzdGlsbCByZXF1aXJlcyBhIFBJRCwgYm9hcmRpbmZvLT5w aWQgaXMgc2V0CnRvICgodTY0KTAgPDwgMzIpIHwgcmVnWzJdLiAgSWYgcmVnWzJdIGlzIG5vbi16 ZXJvLCAhYm9hcmRpbmZvLT5waWQgaXMgZmFsc2UuCgpXb3VsZCB0aGlzIHJlc3VsdCBpbiBzdWNj ZXNzZnVsbHkgcmVnaXN0ZXJpbmcgdGhlIGRldmljZSBkZXNwaXRlIHRoZSB6ZXJvCk1hbnVmYWN0 dXJlciBJRCwgdmlvbGF0aW5nIHRoZSBNSVBJIEkzQyBzcGVjaWZpY2F0aW9uPwoKLS0gClNhc2hp a28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDcyMTA0 MDgwNS4xNjk2NTAzLTEtYWtoaWxyYWplZXZAbnZpZGlhLmNvbT9wYXJ0PTUKCi0tIApsaW51eC1p M2MgbWFpbGluZyBsaXN0CmxpbnV4LWkzY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtaTNjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12BBF3EDAA2; Tue, 21 Jul 2026 04:26:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607966; cv=none; b=hY3YCzjil4UIFgwDkBvA3FmV9n87hWBJttkVCDBvb3cHICRFziHC6ITo9MfgSUVXqUD+1reS/gYrVuLXQwT5v6Fc7WL4+SHrCBPi9xIh8xKtLeWxLhog39X3n7plciSMsa8vL0M2wIXlZMpNrlcrnnQhk9gv1EUOoaRwUmLifmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607966; c=relaxed/simple; bh=WaciNlMmRDh7Si+nV3k6wSn77k9JJZ932HQtSDAj8Sg=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=TuBpwHOw2yt2J2aHjrLaLlJCimQSabxSTLmPjG92blq40JJ89b36aYa/YfgQxR3HI1kGR+rVSzNBvkju2ya6OjewXDZt0uCTDC4LyoVYd39mIpYpo6ly7k/2FpqdjQqjCBkQDhy6605PxQ1vkECF8lT/w6PnxgjLYlr788GDtrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SxxexnG6; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SxxexnG6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87E791F00A3A; Tue, 21 Jul 2026 04:26:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784607965; bh=LAE26sMh6ZrJ8Lvg6zGD83jtaqtfFfO3Z4H0CXF5NvA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=SxxexnG6ImrXdafB/AEmKq2CeRelaaJvkwIj10W/hMUl7rGNWem3TPgN+p1miIc9g x7jFwnJXJXOEX2wGy4MXTKR+pd6ywz4ILsVsKn9uMetGt+EyS6xWkyDAtzQuR92Hsl nzqIlOBuZkWPd39ypaTz8dj+h2WkY8EaEO9z3U0w+53KyLNuihCZS56Qy3kHJT6k3Q jZKQhIF/6pu5/QS0G0z1XrjKUoNhqlMkBoyzhNsxk8PD6SJPICHNoXoQWiCuzJRT2F nP2XDg7qyRrHUgzGdLdNOVW/+7o5a/+jMP4+kxND1enZs3Obh0dT34EG+HV4V7R+fT v20cChD2O94EQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 05/12] i3c: master: Add support for devices without PID Reply-To: sashiko-reviews@lists.linux.dev To: "Akhil R" Cc: Frank.Li@kernel.org, "Alexandre Belloni" , robh@kernel.org, devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org In-Reply-To: <20260721040805.1696503-6-akhilrajeev@nvidia.com> References: <20260721040805.1696503-1-akhilrajeev@nvidia.com> <20260721040805.1696503-6-akhilrajeev@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 21 Jul 2026 04:26:04 +0000 Message-Id: <20260721042604.87E791F00A3A@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Medium] The static address matching logic for devices without a PID in `= i3c_master_attach_boardinfo` is unreachable and contains a structurally imp= ossible condition. - [Medium] Devices requiring a PID can now be registered with an invalid Ma= nufacturer ID of 0. -- --- Patch [5]: [PATCH v6 05/12] i3c: master: Add support for devices withou= t PID --- commit 671c3fae66002e874a13051a9c956e9987d76674 Author: Akhil R i3c: master: Add support for devices without PID =20 Devices using SETAASA for address assignment are not required to have a 48-bit PID according to the I3C specification. Allow such devices to register and use the static address where PID was required. > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c > index b18dda89c4737..7b2f819bf4437 100644 > --- a/drivers/i3c/master.c > +++ b/drivers/i3c/master.c [ ... ] > @@ -2389,8 +2398,18 @@ static void i3c_master_attach_boardinfo(struct i3c= _dev_desc *i3cdev) > struct i3c_dev_boardinfo *i3cboardinfo; > =20 > list_for_each_entry(i3cboardinfo, &master->boardinfo.i3c, node) { > - if (i3cdev->info.pid !=3D i3cboardinfo->pid) > - continue; > + /* > + * For devices without PID (e.g., SETAASA devices), match by > + * static address. For devices with PID, match by PID. > + */ > + if (i3cboardinfo->pid) { > + if (i3cdev->info.pid !=3D i3cboardinfo->pid) > + continue; > + } else { > + if (!i3cboardinfo->static_addr || > + i3cdev->info.static_addr !=3D i3cboardinfo->static_addr) > + continue; > + } [Severity: Medium] Will this static address matching logic ever evaluate to false? Since i3c_master_attach_boardinfo() is only called during the dynamic address assignment (ENTDAA) phase, i3cdev->info.static_addr is inherently 0 in this context. Because i3cboardinfo->static_addr is validated to be non-zero at creation, the condition i3cdev->info.static_addr !=3D i3cboardinfo->static_addr will evaluate to 0 !=3D non-zero, which is always true. This means the loop will always continue, making this branch effectively dead code that fails to perform the intended matching. > =20 > i3cdev->boardinfo =3D i3cboardinfo; > i3cdev->info.static_addr =3D i3cboardinfo->static_addr; [ ... ] > @@ -2848,9 +2871,16 @@ i3c_master_add_i3c_boardinfo(struct i3c_master_con= troller *master, > =20 > boardinfo->pid =3D ((u64)reg[1] << 32) | reg[2]; > =20 > - if ((boardinfo->pid & GENMASK_ULL(63, 48)) || > - I3C_PID_RND_LOWER_32BITS(boardinfo->pid)) > - return -EINVAL; > + /* For SETAASA devices, validate the static address instead of PID */ > + if (boardinfo->static_addr_method & I3C_ADDR_METHOD_SETAASA) { > + if (!boardinfo->static_addr) > + return -EINVAL; > + } else { > + if (!boardinfo->pid || > + (boardinfo->pid & GENMASK_ULL(63, 48)) || > + I3C_PID_RND_LOWER_32BITS(boardinfo->pid)) > + return -EINVAL; > + } > =20 > boardinfo->init_dyn_addr =3D init_dyn_addr; > boardinfo->fwnode =3D fwnode_handle_get(fwnode); > @@ -2873,10 +2903,10 @@ static int i3c_master_add_of_dev(struct i3c_maste= r_controller *master, > return ret; > =20 > /* > - * The manufacturer ID can't be 0. If reg[1] =3D=3D 0 that means we're > - * dealing with an I2C device. > + * I3C device should have either the manufacturer ID specified or the > + * address discovery method specified. Else treat it as an I2C device. > */ > - if (!reg[1]) > + if (!reg[1] && !fwnode_property_present(fwnode, "mipi-i3c-static-method= ")) > ret =3D i3c_master_add_i2c_boardinfo(master, fwnode, reg); > else > ret =3D i3c_master_add_i3c_boardinfo(master, fwnode, reg); [Severity: Medium] Could this change allow devices requiring a PID to be registered with an invalid Manufacturer ID of 0? By permitting reg[1] =3D=3D 0 when mipi-i3c-static-method is present in i3c_master_add_of_dev(), it appears we can bypass the strict Manufacturer ID validation in i3c_master_add_i3c_boardinfo(). If the method is SETDASA, which still requires a PID, boardinfo->pid is set to ((u64)0 << 32) | reg[2]. If reg[2] is non-zero, !boardinfo->pid is fals= e. Would this result in successfully registering the device despite the zero Manufacturer ID, violating the MIPI I3C specification? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260721040805.1696= 503-1-akhilrajeev@nvidia.com?part=3D5