From: kr494167@gmail.com
To: lee@kernel.org, pavel@kernel.org
Cc: kauschluss@disroot.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, surendra <kr494167@gmail.com>
Subject: [PATCH 1/2] leds: rgb: s2m: wire up of_match_table in platform driver
Date: Tue, 21 Jul 2026 11:18:45 +0530 [thread overview]
Message-ID: <20260721054846.34318-2-kr494167@gmail.com> (raw)
In-Reply-To: <20260721054846.34318-1-kr494167@gmail.com>
From: surendra <kr494167@gmail.com>
The driver defines and registers s2m_rgb_of_match_table via
MODULE_DEVICE_TABLE(of, ...) but never assigns it to the platform
driver's .of_match_table field. As a result the kernel never matches
this driver against a DT node with compatible "samsung,s2mu005-rgb",
making the MODULE_DEVICE_TABLE entry dead code.
Wire the table up so that DT-based probing and module auto-loading
work as intended.
Fixes: 63ccd117f425 ("leds: rgb: Add support for Samsung S2M series PMIC RGB LED device")
Signed-off-by: surendra <kr494167@gmail.com>
---
drivers/leds/rgb/leds-s2m-rgb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/rgb/leds-s2m-rgb.c b/drivers/leds/rgb/leds-s2m-rgb.c
index d239f54eee90..28964de6920c 100644
--- a/drivers/leds/rgb/leds-s2m-rgb.c
+++ b/drivers/leds/rgb/leds-s2m-rgb.c
@@ -415,6 +415,7 @@ MODULE_DEVICE_TABLE(of, s2m_rgb_of_match_table);
static struct platform_driver s2m_rgb_driver = {
.driver = {
.name = "s2m-rgb",
+ .of_match_table = s2m_rgb_of_match_table,
},
.probe = s2m_rgb_probe,
.id_table = s2m_rgb_id_table,
--
2.55.0
next prev parent reply other threads:[~2026-07-21 5:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 5:48 [PATCH 0/2] leds: s2m: wire up missing of_match_table in platform drivers kr494167
2026-07-21 5:48 ` kr494167 [this message]
2026-07-21 5:58 ` [PATCH 1/2] leds: rgb: s2m: wire up of_match_table in platform driver sashiko-bot
2026-07-22 12:52 ` Lee Jones
2026-07-21 5:48 ` [PATCH 2/2] leds: flash: " kr494167
2026-07-21 5:57 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721054846.34318-2-kr494167@gmail.com \
--to=kr494167@gmail.com \
--cc=kauschluss@disroot.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.