From: sashiko-bot@kernel.org
To: "Gaurav Kohli" <gaurav.kohli@oss.qualcomm.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v5 3/9] remoteproc: qcom: pas: add support for TMD thermal cooling devices
Date: Tue, 21 Jul 2026 06:45:39 +0000 [thread overview]
Message-ID: <20260721064539.A20FE1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260721-b4-qmi-tmd-v5-3-99620e07f505@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The Kconfig symbol QCOM_Q6V5_PAS unconditionally selects QCOM_QMI_TMD without inheriting its NET dependency, leading to unmet dependency warnings and potential build failures.
--
--- Patch [3]: [PATCH v5 3/9] remoteproc: qcom: pas: add support for TMD thermal cooling devices ---
commit 55e78a265d3400a946df10d192ba5fdd761cbe31
Author: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
remoteproc: qcom: pas: add support for TMD thermal cooling devices
This commit registers Thermal Mitigation Devices (TMDs) for PAS-managed
remote processors to enable thermal throttling through QMI. It updates
Kconfig to select the necessary QMI TMD support and adds the device tree
parsing and initialization logic.
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 65befdbfa5f7d..f7c02edf395fe 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -229,6 +229,7 @@ config QCOM_Q6V5_PAS
> select QCOM_PIL_INFO
> select QCOM_MDT_LOADER
> select QCOM_Q6V5_COMMON
> + select QCOM_QMI_TMD
[Severity: Low]
Does selecting QCOM_QMI_TMD here without inheriting its dependency on NET
cause Kconfig unmet dependency warnings and potential build failures when
CONFIG_NET=n?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-b4-qmi-tmd-v5-0-99620e07f505@oss.qualcomm.com?part=3
next prev parent reply other threads:[~2026-07-21 6:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 6:28 [PATCH v5 0/9] Add support for Qualcomm remoteproc subsystem cooling Gaurav Kohli
2026-07-21 6:28 ` [PATCH v5 1/9] dt-bindings: remoteproc: qcom,pas: add #cooling-cells property Gaurav Kohli
2026-07-22 7:06 ` Krzysztof Kozlowski
2026-07-22 13:38 ` Gaurav Kohli
2026-07-23 7:22 ` Krzysztof Kozlowski
2026-07-21 6:28 ` [PATCH v5 2/9] soc: qcom: Add QMI TMD support for remote thermal mitigation Gaurav Kohli
2026-07-21 6:48 ` sashiko-bot
2026-07-22 13:25 ` Gaurav Kohli
2026-07-22 13:33 ` Dmitry Baryshkov
2026-07-23 13:50 ` Gaurav Kohli
2026-07-21 6:29 ` [PATCH v5 3/9] remoteproc: qcom: pas: add support for TMD thermal cooling devices Gaurav Kohli
2026-07-21 6:45 ` sashiko-bot [this message]
2026-07-21 23:07 ` Dmitry Baryshkov
2026-07-23 14:35 ` Gaurav Kohli
2026-07-21 6:29 ` [PATCH v5 4/9] remoteproc: qcom_q6v5_pas: enable QMI TMD cooling support Gaurav Kohli
2026-07-21 6:29 ` [PATCH v5 5/9] arm64: dts: qcom: kodiak: Enable CDSP & Modem cooling Gaurav Kohli
2026-07-21 23:11 ` Dmitry Baryshkov
2026-07-22 13:32 ` Gaurav Kohli
2026-07-21 6:29 ` [PATCH v5 6/9] arm64: dts: qcom: lemans: Enable CDSP cooling Gaurav Kohli
2026-07-21 23:12 ` Dmitry Baryshkov
2026-07-21 6:29 ` [PATCH v5 7/9] arm64: dts: qcom: talos: " Gaurav Kohli
2026-07-21 23:12 ` Dmitry Baryshkov
2026-07-21 6:29 ` [PATCH v5 8/9] arm64: dts: qcom: monaco: " Gaurav Kohli
2026-07-21 23:12 ` Dmitry Baryshkov
2026-07-21 6:29 ` [PATCH v5 9/9] arm64: dts: qcom: hamoa: " Gaurav Kohli
2026-07-21 23:13 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721064539.A20FE1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gaurav.kohli@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.