Re: [PATCH 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add x1e80100 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `qcom,x1e80100-inline-crypto-engine` compatible string was omitted from the `allOf` conditional block that enforces required properties (`power-domains` and `clock-names`).
--

--- Patch [1]: [PATCH 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add x1e80100 support ---
commit cfe29b614f97bbb01610fe15e88b3fd50c7177bb
Author: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com>

dt-bindings: crypto: qcom,inline-crypto-engine: Add x1e80100 support
    
Add the compatible string for the Qualcomm X1E80100 SoC,
which is used on the Hamoa IoT EVK board.

> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> index db895c50e2d25..29c9a1ff638c5 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> @@ -25,6 +25,7 @@ properties:
>            - qcom,sm8550-inline-crypto-engine
>            - qcom,sm8650-inline-crypto-engine
>            - qcom,sm8750-inline-crypto-engine
> +          - qcom,x1e80100-inline-crypto-engine

[Severity: Medium]
Does this cause a regression in schema validation by omitting the new
compatible string from the conditional block?

Looking further down in qcom,inline-crypto-engine.yaml, there is an allOf
block that enforces power-domains and clock-names:

Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml:allOf:
  - if:
      properties:
        compatible:
          contains:
            enum:
              - qcom,eliza-inline-crypto-engine
              - qcom,milos-inline-crypto-engine

    then:
      required:
        - power-domains
        - clock-names

Omitting the new qcom,x1e80100-inline-crypto-engine compatible string from
this block allows incomplete device tree nodes missing power domains or
interface clocks to pass schema validation.

Could we add the new compatible string to this enum if it shares the same
hardware constraints?

>        - const: qcom,inline-crypto-engine
>  
>    reg:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-devtool-v1-0-ade633accb41@oss.qualcomm.com?part=1