From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Nick Li <nick.li@foursemi.com>,
Herve Codina <herve.codina@bootlin.com>
Cc: Support Opensource <support.opensource@diasemi.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Srinivas Kandagatla <srini@kernel.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>, Sen Wang <sen@ti.com>,
Oder Chiou <oder_chiou@realtek.com>,
Linus Walleij <linusw@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
u.kleine-koenig@baylibre.com, Zhang Yi <zhangyi@everest-semi.com>,
Marco Crivellari <marco.crivellari@suse.com>,
Kees Cook <kees@kernel.org>, HyeongJun An <sammiee5311@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Qianfeng Rong <rongqianfeng@vivo.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH v4 19/29] ASoC: codecs: rt5665: Use guard() for mutex locks
Date: Tue, 21 Jul 2026 17:25:50 +0700 [thread overview]
Message-ID: <20260721102600.523199-20-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260721102600.523199-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
Clean up the code using guard() for mutex locks.
Merely code refactoring, and no behavior change.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/codecs/rt5665.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/sound/soc/codecs/rt5665.c b/sound/soc/codecs/rt5665.c
index 48f57cd0920d..1d987472ba42 100644
--- a/sound/soc/codecs/rt5665.c
+++ b/sound/soc/codecs/rt5665.c
@@ -6,6 +6,7 @@
* Author: Bard Liao <bardliao@realtek.com>
*/
+#include <linux/cleanup.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/init.h>
@@ -1208,7 +1209,7 @@ static void rt5665_jack_detect_handler(struct work_struct *work)
usleep_range(10000, 15000);
}
- mutex_lock(&rt5665->calibrate_mutex);
+ guard(mutex)(&rt5665->calibrate_mutex);
val = snd_soc_component_read(rt5665->component, RT5665_AJD1_CTRL) & 0x0010;
if (!val) {
@@ -1274,8 +1275,6 @@ static void rt5665_jack_detect_handler(struct work_struct *work)
schedule_delayed_work(&rt5665->jd_check_work, 0);
else
cancel_delayed_work_sync(&rt5665->jd_check_work);
-
- mutex_unlock(&rt5665->calibrate_mutex);
}
static const char * const rt5665_clk_sync[] = {
@@ -4564,7 +4563,7 @@ static void rt5665_calibrate(struct rt5665_priv *rt5665)
{
int value, count;
- mutex_lock(&rt5665->calibrate_mutex);
+ guard(mutex)(&rt5665->calibrate_mutex);
regcache_cache_bypass(rt5665->regmap, true);
@@ -4601,7 +4600,8 @@ static void rt5665_calibrate(struct rt5665_priv *rt5665)
pr_err("HP Calibration Failure\n");
regmap_write(rt5665->regmap, RT5665_RESET, 0);
regcache_cache_bypass(rt5665->regmap, false);
- goto out_unlock;
+ rt5665->calibration_done = true;
+ return;
}
count++;
@@ -4620,7 +4620,8 @@ static void rt5665_calibrate(struct rt5665_priv *rt5665)
pr_err("MONO Calibration Failure\n");
regmap_write(rt5665->regmap, RT5665_RESET, 0);
regcache_cache_bypass(rt5665->regmap, false);
- goto out_unlock;
+ rt5665->calibration_done = true;
+ return;
}
count++;
@@ -4635,9 +4636,7 @@ static void rt5665_calibrate(struct rt5665_priv *rt5665)
regmap_write(rt5665->regmap, RT5665_BIAS_CUR_CTRL_8, 0xa602);
regmap_write(rt5665->regmap, RT5665_ASRC_8, 0x0120);
-out_unlock:
rt5665->calibration_done = true;
- mutex_unlock(&rt5665->calibrate_mutex);
}
static void rt5665_calibrate_handler(struct work_struct *work)
--
2.43.0
next prev parent reply other threads:[~2026-07-21 10:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 10:25 [PATCH v4 00/29] ASoC: codecs: Use guard() for mutex & spin locks - part 2 phucduc.bui
2026-07-21 10:25 ` [PATCH v4 01/29] ASoC: codecs: da7213: Use guard() for mutex locks phucduc.bui
2026-07-21 10:25 ` [PATCH v4 02/29] ASoC: codecs: da7219: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 03/29] ASoC: codecs: es8316: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 04/29] ASoC: codecs: es8326: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 05/29] ASoC: codecs: es9356: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 06/29] ASoC: codecs: fs210x: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 07/29] ASoC: codecs: hdac_hdmi: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 08/29] ASoC: codecs: hdmi-codec: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 09/29] ASoC: codecs: idt821034: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 10/29] ASoC: codecs: lpass-macro: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 11/29] ASoC: codecs: madera: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 12/29] ASoC: codecs: max98095: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 13/29] ASoC: codecs: mt6359-accdet: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 14/29] ASoC: codecs: pcm512x: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 15/29] ASoC: codecs: pcm6240: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 16/29] ASoC: codecs: peb2466: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 17/29] ASoC: codecs: rt5514-spi: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 18/29] ASoC: codecs: rt5645: " phucduc.bui
2026-07-21 10:25 ` phucduc.bui [this message]
2026-07-21 10:25 ` [PATCH v4 20/29] ASoC: codecs: rt5668: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 21/29] ASoC: codecs: rt5677: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 22/29] ASoC: codecs: rt5682: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 23/29] ASoC: codecs: rt700: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 24/29] ASoC: codecs: rt711: " phucduc.bui
2026-07-21 10:25 ` [PATCH v4 25/29] ASoC: codecs: rt712-sdca-sdw: Simplify regcache error handling in resume phucduc.bui
2026-07-21 10:25 ` [PATCH v4 26/29] ASoC: codecs: rt712: Use guard() for mutex locks phucduc.bui
2026-07-21 10:25 ` [PATCH v4 27/29] ASoC: codecs: rt721-sdca-sdw: Simplify regcache error handling in resume phucduc.bui
2026-07-21 10:25 ` [PATCH v4 28/29] ASoC: codecs: rt721: Use guard() for mutex locks phucduc.bui
2026-07-21 10:26 ` [PATCH v4 29/29] ASoC: codecs: rt722: " phucduc.bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721102600.523199-20-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=herve.codina@bootlin.com \
--cc=kees@kernel.org \
--cc=kevin-lu@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=matthias.bgg@gmail.com \
--cc=nick.li@foursemi.com \
--cc=oder_chiou@realtek.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=rongqianfeng@vivo.com \
--cc=sammiee5311@gmail.com \
--cc=sen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=srini@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=zhangyi@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.