From: Jakub Kicinski <kuba@kernel.org>
To: Thaison Phan <thaisonphan@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Fengyuan Gong <gfengyuan@google.com>,
Stan Iliev <stani@google.com>, Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Petr Machata <petrm@nvidia.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: net: update wait mechanism for relocating netdevsim to a new ns
Date: Tue, 21 Jul 2026 11:53:39 -0700 [thread overview]
Message-ID: <20260721115339.09a3ea0e@kernel.org> (raw)
In-Reply-To: <20260709160807.23650-1-thaisonphan@google.com>
On Thu, 9 Jul 2026 16:08:07 +0000 Thaison Phan wrote:
> When netdevsim devices are reloaded into a non-default network namespace
> via 'devlink dev reload', the host's udev daemon does not receive the
> subsequent device creation events since it is generally associated to the
> default network namespace, so the host udevd queue never officially clears.
> As a result, running 'udevadm settle' blocks indefinitely and eventually
> times out.
>
> Fixed this by bypassing 'udevadm settle' when a namespace ('ns') is
> provided by utilizing the namespace-aware 'self.wait_for_netdevs()'
> helper to poll the namespace's sysfs until the interfaces are visible.
> For host-only configurations (where 'ns' is None), preserve the original
> 'udevadm settle' behavior to ensure udev renaming rules are completed.
I don't get it. I never saw it hang. And if the event is scoped udevadm
settle should return immediately, rather than hang. We generally run
on latest systemd udev in Fedora and CentOS. Please explain your problem
better.
> Also fixed minor bug in wait_for_devs() where wrong exception was caught
> from if get_ifnames() failed. Now the if get_ifnames() results in a
> command failure exception, wait_for_devs() will catch the exception and
> set an empty list for the interface names rather than the exception
> propogating upward.
Should be a separate patch
--
pw-bot: cr
prev parent reply other threads:[~2026-07-21 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 16:08 [PATCH net-next] selftests: net: update wait mechanism for relocating netdevsim to a new ns Thaison Phan
2026-07-21 18:53 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721115339.09a3ea0e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gfengyuan@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=stani@google.com \
--cc=thaisonphan@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.