Re: [PATCH v4] arm64: dts: qcom: sm8650-ayaneo-pocket-s2: add display nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The `goodix,gt911` touchscreen node is missing the `irq-gpios` property, preventing hardware reset and reliable I2C address selection.
- [Medium] The `mdp_vsync_active` and `mdp_vsync_suspend` pinctrl states are defined but never referenced, leaving the hardware vsync pin unconfigured.
--

--- Patch [1]: [PATCH v4] arm64: dts: qcom: sm8650-ayaneo-pocket-s2: add display nodes ---
commit 4aa8da2a051a6d25d51dd20f442ad0cf6d0b5e21
Author: KancyJoe <kancy2333@outlook.com>
Date:   Tue Jul 21 12:10:55 2026 +0000

arm64: dts: qcom: sm8650-ayaneo-pocket-s2: add display nodes

Add nodes for the dual DSI panel, the SGM3804 regulator, the
SY7758 backlight controller, the touch controller, and enable
the GPU to enable full display support.

Link: https://patch.msgid.link/20260702-topic-sm8650-ayaneo-pocket-s2-display-dt-v3-1-e6de68d33f9b@linaro.org
Link: https://patch.msgid.link/20260522-topic-sm8650-ayaneo-pocket-s2-display-dt-v2-1-cdd4b70e5a16@linaro.org
Link: https://patch.msgid.link/20260428-topic-sm8650-ayaneo-pocket-s2-display-dt-v1-1-ff132c00d076@linaro.org

> diff --git a/arch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts b/arch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts
> index 0dc994f4e48d9..035efeacc7db7 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts

[ ... ]

> @@ -1016,6 +1037,30 @@ wcd_usbss_sbu_mux: endpoint {
>  	};
>  };
>  
> +&i2c4 {
> +	clock-frequency = <400000>;
> +
> +	status = "okay";
> +
> +	touchscreen@5d {
> +		compatible = "goodix,gt911";
> +		reg = <0x5d>;
> +
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <162 IRQ_TYPE_EDGE_FALLING>;
> +
> +		reset-gpios = <&tlmm 161 GPIO_ACTIVE_HIGH>;
> +		VDDIO-supply = <&vreg_l14b_3p2>;
> +		AVDD28-supply = <&vreg_l14b_3p2>;

[Severity: High]
Is this node missing the irq-gpios property? The goodix driver needs both
reset-gpios and irq-gpios to execute its hardware reset and i2c address
selection sequence.

Without irq-gpios, the driver skips the reset sequence completely, which can
leave the controller in an undefined state and cause initialization to fail.

> +
> +		touchscreen-size-x = <1440>;
> +		touchscreen-size-y = <2560>;
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&ts_reset_default>, <&ts_irq_default>;
> +	};
> +};
> +

[ ... ]

> @@ -1073,6 +1163,93 @@ &mdss_dp0_out {
> +&mdss_dsi0 {
> +	vdda-supply = <&vreg_l3i_1p2>;
> +
> +	qcom,master-dsi;
> +	qcom,dual-dsi-mode;
> +	qcom,sync-dual-dsi;
> +
> +	status = "okay";
> +
> +	panel@0 {
> +		status = "okay";
> +		compatible = "ayaneo,wt0630-2k", "renesas,r63419";
> +		reg = <0>;
> +
> +		pinctrl-0 = <&disp0_reset_n_active>;
> +		pinctrl-1 = <&disp0_reset_n_suspend>;
> +		pinctrl-names = "default", "sleep";

[Severity: Medium]
Should the mdp_vsync_active and mdp_vsync_suspend states be referenced
here? 

They are defined later in this file to configure the hardware vsync pin, but
without being included in these pinctrl properties, the pin remains
unconfigured. This could break hardware tearing effect synchronization
delivery to the DPU and lead to display tearing or update timeouts.

> +
> +		vddio-supply = <&vreg_l12b_1p8>;
> +		vdd-supply = <&vreg_l11b_1p2>;
> +		vsp-supply = <&sgm3804_pos>;
> +		vsn-supply = <&sgm3804_neg>;
> +		vci-supply = <&vreg_l13b_3p0>;
> +

[ ... ]

> @@ -1411,6 +1602,20 @@ fan_int: fan-int-state {
>  		bias-pull-up;
>  	};
>  
> +	mdp_vsync_active: mdp-vsync-active-state {
> +		pins = "gpio86";
> +		function = "mdp_vsync";
> +		drive-strength = <2>;
> +		bias-pull-down;
> +	};
> +
> +	mdp_vsync_suspend: mdp-vsync-suspend-state {
> +		pins = "gpio86";
> +		function = "mdp_vsync";
> +		drive-strength = <2>;
> +		bias-pull-down;
> +	};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-topic-sm8650-ayaneo-pocket-s2-display-dt-v4-1-68e5fa9056ad@linaro.org?part=1