Re: [PATCH v2 2/4] dt-bindings: mfd: syscon: Allow syscon compatible for Loongson-2K0300 chip id

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The compatible string added in the patch contains a typographical error ('cphipid' instead of 'chipid').
--

--- Patch [2]: [PATCH v2 2/4] dt-bindings: mfd: syscon: Allow syscon compatible for Loongson-2K0300 chip id ---
commit 5db600cb90f648eab2d8d155fce1a1ef7e8cd50e
Author: Binbin Zhou <zhoubinbin@loongson.cn>

dt-bindings: mfd: syscon: Allow syscon compatible for Loongson-2K0300 chip id

The Loongson-2K0300 SoC exposes its chip ID registers through a syscon
interface. This commit adds a specific compatible string to the syscon
bindings list so it can be referenced by a phandle.

> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index e228670880631..c5b2e28f6cedd 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -76,6 +76,7 @@ select:
>            - hpe,gxp-sysreg
>            - loongson,ls1b-syscon
>            - loongson,ls1c-syscon
> +          - loongson,ls2k0300-cphipid-syscon

[Severity: Medium]
Is this spelling correct? The commit message mentions the compatible string
should be "loongson,ls2k0300-chipid-syscon", but this adds "cphipid" instead.
Will this cause schema validation to fail for device trees using the correctly
spelled chipid string?

>            - lsi,axxia-syscon
>            - marvell,armada-3700-cpu-misc
>            - marvell,armada-3700-nb-pm
[ ... ]
> @@ -189,6 +190,7 @@ properties:
>                - hpe,gxp-sysreg
>                - loongson,ls1b-syscon
>                - loongson,ls1c-syscon
> +              - loongson,ls2k0300-cphipid-syscon

[Severity: Medium]
Does this also contain the same "cphipid" typo as the select block above?

>                - lsi,axxia-syscon
>                - marvell,armada-3700-cpu-misc
>                - marvell,armada-3700-nb-pm

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1784619512.git.zhoubinbin@loongson.cn?part=2