Re: [PATCH v7 1/2] arm64: dts: qcom: sdm845-google: Add dual front IMX355 cameras

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Mismatched Pinctrl Sleep State: `&cci0_sleep` overridden instead of `&cci1_sleep`
--

--- Patch [1]: [PATCH v7 1/2] arm64: dts: qcom: sdm845-google: Add dual front IMX355 cameras ---
commit 6f3cf4398dc835a329292905a7fe098ccc06dc9c
Author: David Heidelberg <david@ixit.cz>

arm64: dts: qcom: sdm845-google: Add dual front IMX355 cameras

This patch adds support for the dual front IMX355 cameras on the Pixel 3.
The cameras are connected via CSIPHY ports 1 and 2, and are controlled over
the CCI I2C1 bus.

> diff --git a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
> index 9368fd6b87515..c8a28133fb38d 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi

[ ... ]

> +&cci0_sleep {
> +	/* bus has external pull-up */
> +	/delete-property/ bias-pull-down;
> +	bias-disable;
> +};

[Severity: Medium]
Is it intentional to modify the sleep state for &cci0_sleep here?

The new front cameras are added to the &cci_i2c1 bus below, which depends on
&cci1_sleep for its suspend state. Modifying &cci0_sleep means &cci1_sleep 
will retain its default bias-pull-down configuration.

During suspend, the SoC will actively pull down the &cci_i2c1 pins, which
will fight the external pull-up resistors on that bus and cause continuous
leakage current and battery drain.

Should this remove the bias-pull-down property on &cci1_sleep instead?

> +
>  &cci {
>  	status = "okay";
>  };
> @@ -358,7 +444,63 @@ &cci {
>  &cci_i2c1 {
>  	/* actuator @0c */
>  
> -	/* front camera, imx355 @1a */
> +	front_cam: camera@10 {

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-pixel3-camera-v7-0-82d323c6c5d2@ixit.cz?part=1