Re: [PATCH] doc: ABI: sysfs-class-backlight: update outdated HAL userspace reference

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch incompletely updates the 'Users: HAL' references, missing the occurrence under 'actual_brightness'.
--

--- Patch [1]: [PATCH] doc: ABI: sysfs-class-backlight: update outdated HAL userspace reference ---
commit 394037cb75e2eb0f44c91b48f3a8658b6c642c06
Author: Shivank Sharma <shivanksharma2376543@gmail.com>

doc: ABI: sysfs-class-backlight: update outdated HAL userspace reference

This commit replaces the deprecated HAL userspace references in the
sysfs-class-backlight ABI documentation with modern userspace references.

> diff --git a/Documentation/ABI/stable/sysfs-class-backlight b/Documentation/ABI/stable/sysfs-class-backlight
> index 40b8c46b95b28..2f60dd3f40a5c 100644
> --- a/Documentation/ABI/stable/sysfs-class-backlight
> +++ b/Documentation/ABI/stable/sysfs-class-backlight
[ ... ]
> @@ -19,7 +19,7 @@ Description:
>  		are between 0 and max_brightness. This file will also
>  		show the brightness level stored in the driver, which
>  		may not be the actual brightness (see actual_brightness).
> -Users:		HAL
> +Users:		systemd-logind, udev, general userspace.
>  
>  What:		/sys/class/backlight/<backlight>/actual_brightness
>  Date:		March 2006

[Severity: Low]
Did this patch miss updating the Users field for actual_brightness?

In Documentation/ABI/stable/sysfs-class-backlight, actual_brightness also
has HAL listed as the user, but it appears to have been left out of this
update:

What:           /sys/class/backlight/<backlight>/actual_brightness
Date:           March 2006
KernelVersion:  2.6.17
Contact:        Richard Purdie <rpurdie@rpsys.net>
Description:
                Show the actual brightness by querying the hardware. Due
...
Users:          HAL

> @@ -40,7 +40,7 @@ KernelVersion:	2.6.12
>  Contact:	Richard Purdie <rpurdie@rpsys.net>
>  Description:
>  		Maximum brightness for <backlight>.
> -Users:		HAL
> +Users:		systemd-logind, udev, general userspace.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721132253.256422-1-shivanksharma2376543@gmail.com?part=1