From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8FCF3B8120; Tue, 21 Jul 2026 22:34:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673268; cv=none; b=IOYpzfGAJuzZWXtrwf105Yt1ak1Qe2/L+32GMFPpmpeKPo3J+rkfmt+U1YzDMVEg4GxZhpyffucEzlsv4c4rsSr3Ws5Zd754+BVngnUh8FihBHMxK4343cmwpid+NLGQUhVClellkjA4zCb7dEu0j4wQQZbRhjJHb3ZR9/O8gtA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673268; c=relaxed/simple; bh=/Ewb7GfVKBrDhVN9czNlviTBr5ZwdQGCRSdgauKuY2w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=seU5AyEKC7lyhaXXZ8V2AoZlu4rBqs+aN7f4ysvsqMgUXSZGoluyYTB+voIkKAGdXgyUxnTgVCPU16tsMLVcfVgqEg1SVyzOVOAZtdkeWhae7804Tg+gv0BNOYK7YeyAj4PtmSdA4VBzw6eNgqE+TRhp+VT7U/xInysMzhaQBAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=oOUHhJ8f; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="oOUHhJ8f" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A9531F000E9; Tue, 21 Jul 2026 22:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673266; bh=y+T42fv0xK2BrlDYU4XXQvHBlH/AlkjNCtg2N04TQFk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=oOUHhJ8fqSLOqOWfDAcTg2BOTBbUe+TU77KOUTjHswRrADdSRrqyr3zIeKMeKnDmz eLTK4QEQeeF8sESdMJ1+lw6NoexWU+GQwpEWYnQJvY2KRy0k4+pyik+ICKxRWg0/nu T0GuM+CxFQdUgpYQ98WXq7Kwz0f7TkSn1OTfjHyg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Maoyi Xie Subject: [PATCH 5.10 099/699] usb: gadget: composite: fix dead empty check in the USB_DT_OTG handler Date: Tue, 21 Jul 2026 17:17:38 +0200 Message-ID: <20260721152357.934253163@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maoyi Xie commit f8f680609c2b3ab795ffcd6f21585b6dfc46d395 upstream. The OTG branch of composite_setup() falls back to the first configuration when none is selected: if (cdev->config) config = cdev->config; else config = list_first_entry(&cdev->configs, struct usb_configuration, list); if (!config) goto done; ... memcpy(req->buf, config->descriptors[0], value); list_first_entry() never returns NULL. On an empty list it returns container_of() of the list head. So the "if (!config)" check is dead. When cdev->configs is empty, config points at the head inside struct usb_composite_dev. config->descriptors[0] reads whatever sits at that offset. The memcpy copies up to w_length bytes of it into the response buffer. cdev->configs can be empty in two cases. One is a teardown race on gadget unbind with a control transfer in flight. The other is a driver that sets is_otg before it adds a config. A reproducer that holds cdev->configs empty triggers a KASAN fault in this branch. Use list_first_entry_or_null() so the existing check does its job. Fixes: 53e6242db8d6 ("usb: gadget: composite: add USB_DT_OTG request handling") Cc: stable Signed-off-by: Maoyi Xie Link: https://patch.msgid.link/20260527150832.2943293-1-maoyixie.tju@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/composite.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -1747,9 +1747,10 @@ composite_setup(struct usb_gadget *gadge if (cdev->config) config = cdev->config; else - config = list_first_entry( + config = list_first_entry_or_null( &cdev->configs, - struct usb_configuration, list); + struct usb_configuration, + list); if (!config) goto done;