From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 580C8367B63; Tue, 21 Jul 2026 22:37:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673424; cv=none; b=tyRc6tbwxcTArQT/T346MFJ0OWZOeALD8eEKdoeu9K4znKLg8iLH0urHU9t0Xqi27V4I7v+9eck9WFLmXYGUfHRfLbpcumYxkvl+J7H0SUr19av2UypzAhLAtuBRbo33AX8PLGa5NPIsHqSNUg55zqrN8FdXncLvJ5GNknkaIY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673424; c=relaxed/simple; bh=n0aJQjuKNkQLAqmmWA0V4EOSUpiy/cP8hAnNZByMphs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W39x+P/NiyMaVrd9Bnh/joY6v+OHZI0FmnMLqD9Tei5/3yuSRJPYL/0wCnvkCmyrozaryQsmoFjFlweCCV3OypwoFO9QABerhq+CO9uHIb2OZ5fXWuMWBYI8CdD29Q/gKdAY8Ft2YJFwmf27X9MzV37Q9mEzcPWLr8hOwFDrHAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KHFwxDJ9; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KHFwxDJ9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEB481F000E9; Tue, 21 Jul 2026 22:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673423; bh=4NDyf37xb0Zzkt7BnYgVcAiIbXj0LLXOyOuK65p4Idg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=KHFwxDJ90RVw7fEmcQyjhkAxVeWYEx0ALIpBpLND1KeZRPJn3lY92JbvwvSOkJdPh mti/6F/jo94xXSLM+7aHnxsV/nIn0w1uvW/gVZcvk101mqmP3TOn6BvcsJDggy290T pbbBTNDSJqo5EWCjJoFLEXuXhMJJp6U68myFjAQg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alberto Ruiz , Miklos Szeredi Subject: [PATCH 5.10 156/699] fuse: fix device node leak in cuse_process_init_reply() Date: Tue, 21 Jul 2026 17:18:35 +0200 Message-ID: <20260721152359.220824868@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alberto Ruiz commit 9fa4f7a53406430ee9982f2f636a15b338185122 upstream. If device_add() succeeds during CUSE initialization but a subsequent step (cdev_alloc() or cdev_add()) fails, the error path calls put_device() without first calling device_del(). This leaks the devtmpfs entry created by device_add(), leaving a stale /dev/ node that persists until reboot. Since the cuse_conn is never linked into cuse_conntbl on the failure path, cuse_channel_release() sees cc->dev == NULL and skips device_unregister(), so no other code path cleans up the node. This has several consequences: - The device name is permanently poisoned: any subsequent attempt to create a CUSE device with the same name hits the stale sysfs entry, device_add() fails, and the new device is aborted. - The collision manifests as ENODEV returned to userspace with no dmesg diagnostic, making it very difficult to debug. - The failure is self-perpetuating: once a name is leaked, all future attempts with that name fail identically. Fix this by introducing an err_dev label that calls device_del() to undo device_add() before falling through to err_unlock. The existing err_unlock path from a device_add() failure correctly skips device_del() since the device was never added. Testing instructions can be found at the lore link below. Link: https://lore.kernel.org/all/20260408-wip-cuse-leak-fix-v1-0-1c028d575e97@redhat.com/ Signed-off-by: Alberto Ruiz Fixes: 151060ac1314 ("CUSE: implement CUSE - Character device in Userspace") Cc: stable@vger.kernel.org Signed-off-by: Miklos Szeredi Signed-off-by: Greg Kroah-Hartman --- fs/fuse/cuse.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/fs/fuse/cuse.c +++ b/fs/fuse/cuse.c @@ -386,7 +386,7 @@ static void cuse_process_init_reply(stru rc = -ENOMEM; cdev = cdev_alloc(); if (!cdev) - goto err_unlock; + goto err_dev; cdev->owner = THIS_MODULE; cdev->ops = &cuse_frontend_fops; @@ -412,6 +412,8 @@ out: err_cdev: cdev_del(cdev); +err_dev: + device_del(dev); err_unlock: mutex_unlock(&cuse_lock); put_device(dev);