From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D72E408617; Tue, 21 Jul 2026 22:37:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673464; cv=none; b=Sai3G/NYiA80zCmkN9sAD3eFX0egoO7hNGwlLSRg3xYGTAuYy5vAZAI9wgDQGmwdeBPmKo6Hvye7nzIZWvNiE+iJv1d3OAE4DX81wLgTF6ClvX/v+mmxG1jNdkOYHPli6GQSDkon/0nmACfagpt9S5vRWwtG+JyrgGi1bPTIrbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673464; c=relaxed/simple; bh=BDxvnrdJfhdO62CCpCQNnHBMIAK4vrbUggOaP4Sa3Zw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BcyoISAGV3wyq2Y2Hyc9KCiYXgwbOc7RH7Aj8Tev3PDmU1I1h8Dv3wGU2glDQ//kkekHM7x0J+UUCMqraRvh2euzR9edWxq3t97Sj6PnsWDcf8zeFaLLvoINLgAFQbZCzJHsot31LqfHIL0Em1jtN3vO9tyZUzwSBqZ56Xstku0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lqnklKpf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lqnklKpf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EDFC1F000E9; Tue, 21 Jul 2026 22:37:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673462; bh=MdCrOiBonlT4q2C6kwUarVxHKybxSj73G26sjcrujqM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=lqnklKpfE/aV2kGcK68W0gjvQegygsmz90pGCuial3bij+ugQtri8dmYWtVIYnZva +3V9RbD6jjTOUFBj9u7wb8aaFfHRbuHldw26CmIW5lNqykvQSbXR82D3VPdCI0U5Hv fGgBsbNY0UP/5PUVHsxxpNJk7TBvNjRU0Ycd2X/c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuho Choi , Alex Deucher , Sasha Levin Subject: [PATCH 5.10 170/699] drm/radeon: fix memory leak in radeon_ring_restore() on lock failure Date: Tue, 21 Jul 2026 17:18:49 +0200 Message-ID: <20260721152359.536347544@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yuho Choi [ Upstream commit 82f1d6042611d45b8b9de423bbcb4e0ced9ec62b ] radeon_ring_restore() takes ownership of the data buffer allocated by radeon_ring_backup(). The caller (radeon_gpu_reset()) only frees it in the non-restore branch; in the restore branch it relies on radeon_ring_restore() to free it. If radeon_ring_lock() fails, the function returned early without calling kvfree(data), leaking the ring backup buffer on every GPU reset that fails at the lock stage. During repeated GPU resets this causes cumulative kernel memory exhaustion. Free data before returning the error. Fixes: 55d7c22192be ("drm/radeon: implement ring saving on reset v4") Signed-off-by: Yuho Choi Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/radeon/radeon_ring.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_ring.c b/drivers/gpu/drm/radeon/radeon_ring.c index 37093cea24c59d..4da91b12c84dee 100644 --- a/drivers/gpu/drm/radeon/radeon_ring.c +++ b/drivers/gpu/drm/radeon/radeon_ring.c @@ -352,8 +352,10 @@ int radeon_ring_restore(struct radeon_device *rdev, struct radeon_ring *ring, /* restore the saved ring content */ r = radeon_ring_lock(rdev, ring, size); - if (r) + if (r) { + kvfree(data); return r; + } for (i = 0; i < size; ++i) { radeon_ring_write(ring, data[i]); -- 2.53.0