From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2DE03C1400; Tue, 21 Jul 2026 22:38:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673528; cv=none; b=P/nre2FQJZYnDreCMDNz837OGLBkVRibp1a/qnBi1D0KwC7QyShs+8PWRqKm/lIqHivLvDtfy+ke+M5Ul9sDqsT8KaTsAoDQC8fG+QXR82lCr0+GFuSm2ZIeAp+TCzMso4YBBPkl4y6XzNusv2X/iJdaPJ01/jMwrrE50+S0rAc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673528; c=relaxed/simple; bh=UzOM5dTpOvoaCVA0SIfWoFBgvR7VJaNLVet6HGZeP9w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mRcREPGURe9j7rWZnZ2ljWspb06iWO5bWHqKdEZk9b3gJZlHH6Wq3Q618pQ0Z4nFo7qMVUqBKVn4LttTaRfh6m8tUt6eEMvL/9yA1RTq1O71xQrA1BZjLt52cfVmwICyXgRwNp0fg4PXz2yN24twECgdvgnBXXeIyxQuC7093zI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VJEu+rc2; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VJEu+rc2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2531C1F000E9; Tue, 21 Jul 2026 22:38:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673527; bh=Cq88UZY7/2cj3z7YUSJq0z6O58BKTtx/tNAXK7su9jc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=VJEu+rc2jFmkhB75OZe3cwxAnp9FATW43zdL1tyOUNL9o/O2H4IUL1Cm49LDCHv16 y+4y4utMFfRALssvuzCiE9cCQb9BWjiNGelmfgaYi/q27Gn+ZdYbRPh6eISnMb4dHh ugKiZACZ7jTfR19nmuWxsvaTROrRQAVba+52VRmc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Stepan Ionichev , Sasha Levin Subject: [PATCH 5.10 196/699] device property: fix fwnode reference leak in fwnode_graph_get_endpoint_by_id() Date: Tue, 21 Jul 2026 17:19:15 +0200 Message-ID: <20260721152400.117117624@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stepan Ionichev [ Upstream commit 9582485a65eacfd7245ec7f0a9d7e2c34749d669 ] When called with FWNODE_GRAPH_ENDPOINT_NEXT, the function walks every endpoint under the requested port and, for any endpoint whose ID is greater than or equal to the requested one, may store a fwnode reference in best_ep via fwnode_handle_get(). If a later iteration finds an exact-ID match, the function returns that endpoint directly without dropping the reference held by best_ep, leaking it. Drop the saved candidate before returning the exact-match endpoint. This affects callers that use FWNODE_GRAPH_ENDPOINT_NEXT to ask for the next endpoint with ID >= the requested one (used by a number of media drivers, e.g. imx7/8, sun6i CSI, omap3isp, xilinx-csi2, stm32-csi). Each leak retains a fwnode reference until reboot/unbind. Fixes: 0fcc2bdc8aff ("device property: Add fwnode_graph_get_endpoint_by_id()") Signed-off-by: Stepan Ionichev Link: https://patch.msgid.link/20260514171455.27271-1-sozdayvek@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/base/property.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/base/property.c b/drivers/base/property.c index c26ce7fd6832fc..cbd0c2f1a041e8 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -1238,8 +1238,10 @@ fwnode_graph_get_endpoint_by_id(const struct fwnode_handle *fwnode, if (fwnode_ep.port != port) continue; - if (fwnode_ep.id == endpoint) + if (fwnode_ep.id == endpoint) { + fwnode_handle_put(best_ep); return ep; + } if (!endpoint_next) continue; -- 2.53.0